Skip to content

@kmaglione /stdin.txt

Embed URL


Subversion checkout URL

You can clone with
Download ZIP
ID: shopping-assistant
Name: Shopping Assistant: Compare with Amazon, eBay .etc
Type: Full Update
Action: Prelim
Version: 3.1.1
File: ☑ All Platforms 140192
This version didn't pass full review because of the following issues:
1) Your add-on creates DOM nodes from HTML strings containing unsanitized data, by assigning to innerHTML or through similar means. Aside from being inefficient, this is a major security risk. For more information, see
2) Your add-on uses the 'eval' function or Function constructor unnecessarily, which is something we normally don't accept. There are many reasons *not* to use 'eval', and also simple alternatives to using it. You can read more about it here:
3) I get the following errors in the Error Console:
Error: setTimeout is not defined
Source file: resource://ruyitao/search-engine.js
Line: 234
Error: 2012-01-10 07:22:54 [ERROR]get site config failed: status code(500)
We recommend that you use the prefwindow element ( or inline options ( to manage your preferences. They are more portable and consistent than hand-rolled UIs, and can save you some coding time.
You need to correct them to get full approval. Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.