| 1 2 3 4 5 6 7 8 9 10 11 12 13 14 |
|
Thanks for sharing this, however, this doesn't seem to work because the html tags within the conditional comments are empty and they will close before the header opens. This code validates, of course, because the code inside the comments will be ignored but effectively, in IE the page it's outside the element
This is the generated code:
<!DOCTYPE html><!--[if lt IE 7]><html lang="en" class="no-js ie6 oldie"></html><![endif]--><!--[if IE 7]><html lang="en" class="no-js ie7 oldie"></html><![endif]--><!--[if IE 8]><html lang="en" class="no-js ie8 oldie"></html><![endif]--><!-- [if gt IE 8] <!--><html lang="en" class="no-js"><!-- <![endif]--><head><title>Home</title></head><body>body</body></html>
hey gui, check out https://github.com/robrighter/node-boilerplate/blob/master/templates/views/layout.jade i use that one and it works fine (although I update mine to current h5b - eg lt-ie8 class instead of ie8 class
Hi David, I've C+P the code on that link into a jade template and this is how it renders:
<!DOCTYPE html><!--[if lt IE 7]><html lang="en" class="no-js ie6 oldie"></html><![endif]--><!--[if IE 7]><html lang="en" class="no-js ie7 oldie"></html><![endif]--><!--[if IE 8]><html lang="en" class="no-js ie8 oldie"> </html><![endif]--><!--[if gt IE 8]><!-->
As you can see there's a </html> tag at the end of each conditional clause. Of course it will work on every non IE browser since the code is commented out and I'm not sure how IE copes with the problem, but in theory that would place the <head> and <body> as siblings of the <html> plus you have an unmatched </html> at the end.
I'm not at a computer totest this, but jade must have changed something in its engine since this was/is working fine for me with no extra closing HTML tags. I'll test it out.
This is the exact Jade I use:
//- # Layout
//- paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/
!!! 5
//- H5BP implementation inspired by https://gist.github.com/888338/.
//if lt IE 7
//if IE 7
//if IE 8
//[if gt IE 8]><!
html(class='no-js', lang='en')
//<![endif]
And I can confirm it definately doesn't generate an extra closing
tag,
so if that doesn't work for you Kelly is probably right
HI David, that explains. The Jade on your last comment is more or less how I'm doing it at the moment and it does work but this is not the same code as the original one because all you are doing is writing literal HTML for the opening tag. The original code, on the other hand, instructs Jade to create a <html> element that Jade automatically closes. Or am I missing something?
@guioconnor: The one from David is correct. By using literal tags it stops Jade from attempting to auto close the tag, like yours is doing.
You do need to remember to use a literal close at the end of your Jade document though.
Here's another take using comments and literals: https://gist.github.com/3879867
I recommend the following since jade renders a closing html tag
!!! 5
//if lt IE 7
<html class="no-js lt-ie9 lt-ie8 lt-ie7">
//if IE 7
<html class="no-js lt-ie9 lt-ie8">
//if IE 8
<html class="no-js lt-ie9">
// [if gt IE 8] <!
html(class="no-js", lang="en")
// <![endif]
head
Nice improvement @jwerre -- have you attempted to remove the unwanted white space between these at all? I'm fairly confident there isn't really a way to do it, but if there is I'd love to find out as I'm completely OCD about stuff like that :)
please do note that this behaviour has been ripped out of jade now...
https://github.com/visionmedia/jade/issues/1345
Now, you have to just use this:
<!--[if lt IE 8]>
link(rel='stylesheet', href='style-ie8.css')
<![endif]-->
Can you please define 'now'?
Which versions are concerned by the // IE 8 syntax and which are not?
Thanks.
thanks so much for making this available, I couldn't seem to get the indenting right or something and all the html tags weren't wrapping the content, they we're just immediately closing. Anyway, cheers.