Created
January 14, 2010 17:06
-
-
Save kokx/277318 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[23:56:55] <DASPRiD> ralphschindler, we got a naming issue here, you must help out, this is urgent :) | |
[23:57:12] <ralphschindler> ha, sure | |
[23:57:31] <DASPRiD> topic: http://framework.zend.com/svn/framework/standard/trunk/library/Zend/Markup/Renderer/RendererAbstract.php | |
[23:58:03] <DASPRiD> you can add "replacements" (as i call them) to the renderer, which define how tokens are converted to some kind of output | |
[23:58:31] <DASPRiD> kokx currently had them named "tags", as for the specific html renderer, the replacements *can* generate html tags | |
[23:59:14] <DASPRiD> but since they a) dont have to generate html tags, b) nor any html at all, tags is a completly misleading naming imho | |
[23:59:19] <DASPRiD> ralphschindler, what do you think? | |
[23:59:44] <ralphschindler> that sounds fair | |
[23:59:51] <DASPRiD> (problem is, matthew moved the beta release to tomorrow, because their was already some refactoring required) | |
[00:00:01] <DASPRiD> would you call them "replacements" as well? | |
[00:00:16] *** Quits: cwt137_ (i=9770056f@gateway/web/freenode/x-fnbjvsvyjvlytzen) ("Page closed") | |
[00:00:46] <ralphschindler> that sounds like a good word for it | |
[00:00:49] <StasM> anybody responsible for Zend_Application_Resource_Mail here? | |
[00:00:54] <kokx> my opinion is that replacements isn't the best name, because there also is a 'replace' term there ;) | |
[00:01:10] <kokx> (as a type of replacement) | |
[00:01:31] <DASPRiD> kokx, line? | |
[00:01:46] <kokx> its in the first five lines of the class | |
[00:02:03] <DASPRiD> which one? | |
[00:02:07] <kokx> const TYPE_REPLACEMENT = .... | |
[00:02:07] <DASPRiD> renderer abstract? | |
[00:02:12] <kokx> * TYPE_REPLACE | |
[00:02:13] <ralphschindler> hmm | |
[00:02:16] <kokx> the abstract renderer yes | |
[00:02:31] <DASPRiD> kokx, just call it TYPE_SIMPLE | |
[00:02:40] <DASPRiD> as any markup parser does ;) | |
[00:02:43] <kokx> there also is a TYPE_SIMPLE >_> | |
[00:02:52] <DASPRiD> i just see callback, replace and alias | |
[00:03:03] <DASPRiD> and TAG_SINGLE and TAG_NORMAL | |
[00:03:11] <ralphschindler> inToken / outToken ? | |
[00:03:30] <DASPRiD> ralphschindler, its about the constants which define the replacement type | |
[00:03:38] <kokx> hmmz, i can call the constant TYPE_SIMPLE yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment