Skip to content

Instantly share code, notes, and snippets.

@kopylovvlad
Created June 17, 2018 20:05
Show Gist options
  • Save kopylovvlad/119e46154ea9b943a16056b353ac702d to your computer and use it in GitHub Desktop.
Save kopylovvlad/119e46154ea9b943a16056b353ac702d to your computer and use it in GitHub Desktop.
# Before
# Metrics/MethodLength: Method has too many lines. [13/10]
def foo1(number)
if number == 1
'one'
elsif number == 2
'two'
elsif number == 3
'three'
elsif number == 4
'four'
elsif number == 5
'five'
else
'many'
end
end
# After
DICTIONARY = {
1 => 'one',
2 => 'two',
3 => 'three',
4 => 'four',
5 => 'five'
}.freeze
def foo2(number)
DICTIONARY[number] || 'many'
end
@araslanov-e
Copy link

DICTIONARY.fetch(number, 'many')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment