Skip to content

Instantly share code, notes, and snippets.

@kuwa72
Created April 24, 2013 10:50
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save kuwa72/5451284 to your computer and use it in GitHub Desktop.
Save kuwa72/5451284 to your computer and use it in GitHub Desktop.
TestLink 1.9.6 and Redmine2 interface patch(for Japanese). Fixed call htmlentities with character encoding for broked multibyte chars. Fix Issues url path.
diff -ru tm//lib/issuetrackerintegration/redminerestInterface.class.php /var/www/tm/lib/issue[0/494]integration/redminerestInterface.class.php
--- tm//lib/issuetrackerintegration/redminerestInterface.class.php 2013-03-10 02:20:54.000000000 +0900
+++ /var/www/tm/lib/issuetrackerintegration/redminerestInterface.class.php 2013-04-24 19:13:06.622029202 +0900
@@ -55,7 +55,7 @@
$base = trim($this->cfg->uribase,"/") . '/'; // be sure no double // at end
if( !property_exists($this->cfg,'uriview') )
{
- $this->cfg->uriview = $base . 'issues/show/';
+ $this->cfg->uriview = $base . 'issues/';
}
if( !property_exists($this->cfg,'uricreate') )
@@ -254,8 +254,8 @@
{
// needs json or xml
$issueXmlObj = new SimpleXMLElement('<?xml version="1.0"?><issue></issue>');
- $issueXmlObj->addChild('subject', htmlentities($summary));
- $issueXmlObj->addChild('description', htmlentities($description));
+ $issueXmlObj->addChild('subject', htmlentities($summary, ENT_COMPAT|ENT_XML1, 'UTF-8'));
+ $issueXmlObj->addChild('description', htmlentities($description, ENT_COMPAT|ENT_XML1, 'UTF-8'));
$issueXmlObj->addChild('project_id', (string)$this->cfg->projectidentifier);
$issueXmlObj->addChild('tracker_id', (string)$this->cfg->trackerid);
// $issueXmlObj->addChild('priority_id', $priority_id);
@@ -297,4 +297,4 @@
return $template;
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment