Skip to content

Instantly share code, notes, and snippets.

@kybishop
Last active January 15, 2016 19:01
Show Gist options
  • Save kybishop/859f89dd83561355ccf6 to your computer and use it in GitHub Desktop.
Save kybishop/859f89dd83561355ccf6 to your computer and use it in GitHub Desktop.
Computed Property fails to set input to a maximum
import Ember from 'ember';
export default Ember.Controller.extend({
myProperty: 1,
myPropertyComputed: Ember.computed('myProperty', {
get(key) {
return this.get('myProperty');
},
set(key, value) {
if (value > 2) {
value = 2;
} else if (value < 0) {
value = 0;
}
this.set('myProperty', value);
return value;
}
})
});
<p>On pressing the "increment" button, the input will stop from incrementing past the maximum, 2, only once. The input then continues to increment, even though the setter in the computed property sets the backing property and returned value to 2.</p>
<br>
{{input type="number" min=0 value=myPropertyComputed}}
<br>
<br>
{
"version": "0.5.0",
"EmberENV": {
"FEATURES": {}
},
"options": {
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.3/jquery.js",
"ember": "https://cdnjs.cloudflare.com/ajax/libs/ember.js/2.2.0/ember.debug.js",
"ember-data": "https://cdnjs.cloudflare.com/ajax/libs/ember-data.js/2.2.0/ember-data.js",
"ember-template-compiler": "https://cdnjs.cloudflare.com/ajax/libs/ember.js/2.2.0/ember-template-compiler.js"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment