Deprecations

gistfile1.txt

src/text-editor.coffee
465:    Grim.deprecate("This is now a view method. Call TextEditorElement::onDidChangeScrollTop instead.")
470:    Grim.deprecate("This is now a view method. Call TextEditorElement::onDidChangeScrollLeft instead.")
1273:  # Deprecated: Start an open-ended transaction.
1275:    Grim.deprecate('Transactions should be performed via TextEditor::transact only')
1278:  # Deprecated: Commit an open-ended transaction started with {::beginTransaction}.
1280:    Grim.deprecate('Transactions should be performed via TextEditor::transact only')
1505:  # Deprecated: Get all the decorations within a screen row range on the default
3080:    Grim.deprecate("This is now a view method. Call TextEditorElement::scrollToTop instead.")
3085:    Grim.deprecate("This is now a view method. Call TextEditorElement::scrollToTop instead.")
3092:    Grim.deprecate("This is now a view method. Call TextEditorElement::getHorizontalScrollbarHeight instead.")
3097:    Grim.deprecate("This is now a view method. Call TextEditorElement::getVerticalScrollbarWidth instead.")
3161:    Grim.deprecate("This method is deprecated on the model layer. Use `TextEditorElement::pixelPositionForBufferPosition` instead")
3165:    Grim.deprecate("This method is deprecated on the model layer. Use `TextEditorElement::pixelPositionForScreenPosition` instead")
3194:      Grim.deprecate("This is now a view method. Call TextEditorElement::setHeight instead.")
3198:    Grim.deprecate("This is now a view method. Call TextEditorElement::getHeight instead.")
3207:      Grim.deprecate("This is now a view method. Call TextEditorElement::setWidth instead.")
3211:    Grim.deprecate("This is now a view method. Call TextEditorElement::getWidth instead.")
3250:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollTop instead.")
3255:    Grim.deprecate("This is now a view method. Call TextEditorElement::setScrollTop instead.")
3260:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollBottom instead.")
3265:    Grim.deprecate("This is now a view method. Call TextEditorElement::setScrollBottom instead.")
3270:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollLeft instead.")
3275:    Grim.deprecate("This is now a view method. Call TextEditorElement::setScrollLeft instead.")
3280:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollRight instead.")
3285:    Grim.deprecate("This is now a view method. Call TextEditorElement::setScrollRight instead.")
3290:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollHeight instead.")
3295:    Grim.deprecate("This is now a view method. Call TextEditorElement::getScrollWidth instead.")
3300:    Grim.deprecate("This is now a view method. Call TextEditorElement::getMaxScrollTop instead.")
3305:    Grim.deprecate("This is now a view method. Call TextEditorElement::intersectsVisibleRowRange instead.")
3310:    Grim.deprecate("This is now a view method. Call TextEditorElement::selectionIntersectsVisibleRowRange instead.")
3315:    Grim.deprecate("This is now a view method. Call TextEditorElement::screenPositionForPixelPosition instead.")
3320:    Grim.deprecate("This is now a view method. Call TextEditorElement::pixelRectForScreenRange instead.")

Based on some shifts in our thinking, I'm actually thinking we might want to un-deprecate these methods. We'll need to handle the scenario where the editor is detached from the DOM when they're called however.