Skip to content

Instantly share code, notes, and snippets.

@lizan
Created October 26, 2018 20:29
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save lizan/aa391001a938530c419dd99cb3558946 to your computer and use it in GitHub Desktop.
Save lizan/aa391001a938530c419dd99cb3558946 to your computer and use it in GitHub Desktop.
This file has been truncated, but you can view the full file.
Enabled checks:
abseil-string-find-startswith
bugprone-argument-comment
bugprone-assert-side-effect
bugprone-bool-pointer-implicit-conversion
bugprone-copy-constructor-init
bugprone-dangling-handle
bugprone-exception-escape
bugprone-fold-init-type
bugprone-forward-declaration-namespace
bugprone-forwarding-reference-overload
bugprone-inaccurate-erase
bugprone-incorrect-roundings
bugprone-integer-division
bugprone-lambda-function-name
bugprone-macro-parentheses
bugprone-macro-repeated-side-effects
bugprone-misplaced-operator-in-strlen-in-alloc
bugprone-misplaced-widening-cast
bugprone-move-forwarding-reference
bugprone-multiple-statement-macro
bugprone-narrowing-conversions
bugprone-parent-virtual-call
bugprone-sizeof-container
bugprone-sizeof-expression
bugprone-string-constructor
bugprone-string-integer-assignment
bugprone-string-literal-with-embedded-nul
bugprone-suspicious-enum-usage
bugprone-suspicious-memset-usage
bugprone-suspicious-missing-comma
bugprone-suspicious-semicolon
bugprone-suspicious-string-compare
bugprone-swapped-arguments
bugprone-terminating-continue
bugprone-throw-keyword-missing
bugprone-undefined-memory-manipulation
bugprone-undelegated-constructor
bugprone-unused-raii
bugprone-unused-return-value
bugprone-use-after-move
bugprone-virtual-near-miss
clang-analyzer-apiModeling.TrustNonnull
clang-analyzer-apiModeling.google.GTest
clang-analyzer-core.CallAndMessage
clang-analyzer-core.DivideZero
clang-analyzer-core.DynamicTypePropagation
clang-analyzer-core.NonNullParamChecker
clang-analyzer-core.NonnilStringConstants
clang-analyzer-core.NullDereference
clang-analyzer-core.StackAddressEscape
clang-analyzer-core.UndefinedBinaryOperatorResult
clang-analyzer-core.VLASize
clang-analyzer-core.builtin.BuiltinFunctions
clang-analyzer-core.builtin.NoReturnFunctions
clang-analyzer-core.uninitialized.ArraySubscript
clang-analyzer-core.uninitialized.Assign
clang-analyzer-core.uninitialized.Branch
clang-analyzer-core.uninitialized.CapturedBlockVariable
clang-analyzer-core.uninitialized.UndefReturn
clang-analyzer-cplusplus.InnerPointer
clang-analyzer-cplusplus.NewDelete
clang-analyzer-cplusplus.NewDeleteLeaks
clang-analyzer-cplusplus.SelfAssignment
clang-analyzer-deadcode.DeadStores
clang-analyzer-llvm.Conventions
clang-analyzer-nullability.NullPassedToNonnull
clang-analyzer-nullability.NullReturnedFromNonnull
clang-analyzer-nullability.NullableDereferenced
clang-analyzer-nullability.NullablePassedToNonnull
clang-analyzer-nullability.NullableReturnedFromNonnull
clang-analyzer-optin.cplusplus.VirtualCall
clang-analyzer-optin.mpi.MPI-Checker
clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker
clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker
clang-analyzer-optin.performance.GCDAntipattern
clang-analyzer-optin.performance.Padding
clang-analyzer-optin.portability.UnixAPI
clang-analyzer-osx.API
clang-analyzer-osx.NumberObjectConversion
clang-analyzer-osx.ObjCProperty
clang-analyzer-osx.SecKeychainAPI
clang-analyzer-osx.cocoa.AtSync
clang-analyzer-osx.cocoa.AutoreleaseWrite
clang-analyzer-osx.cocoa.ClassRelease
clang-analyzer-osx.cocoa.Dealloc
clang-analyzer-osx.cocoa.IncompatibleMethodTypes
clang-analyzer-osx.cocoa.Loops
clang-analyzer-osx.cocoa.MissingSuperCall
clang-analyzer-osx.cocoa.NSAutoreleasePool
clang-analyzer-osx.cocoa.NSError
clang-analyzer-osx.cocoa.NilArg
clang-analyzer-osx.cocoa.NonNilReturnValue
clang-analyzer-osx.cocoa.ObjCGenerics
clang-analyzer-osx.cocoa.RetainCount
clang-analyzer-osx.cocoa.RunLoopAutoreleaseLeak
clang-analyzer-osx.cocoa.SelfInit
clang-analyzer-osx.cocoa.SuperDealloc
clang-analyzer-osx.cocoa.UnusedIvars
clang-analyzer-osx.cocoa.VariadicMethodTypes
clang-analyzer-osx.coreFoundation.CFError
clang-analyzer-osx.coreFoundation.CFNumber
clang-analyzer-osx.coreFoundation.CFRetainRelease
clang-analyzer-osx.coreFoundation.containers.OutOfBounds
clang-analyzer-osx.coreFoundation.containers.PointerSizedValues
clang-analyzer-security.FloatLoopCounter
clang-analyzer-security.insecureAPI.UncheckedReturn
clang-analyzer-security.insecureAPI.bcmp
clang-analyzer-security.insecureAPI.bcopy
clang-analyzer-security.insecureAPI.bzero
clang-analyzer-security.insecureAPI.getpw
clang-analyzer-security.insecureAPI.gets
clang-analyzer-security.insecureAPI.mkstemp
clang-analyzer-security.insecureAPI.mktemp
clang-analyzer-security.insecureAPI.rand
clang-analyzer-security.insecureAPI.strcpy
clang-analyzer-security.insecureAPI.vfork
clang-analyzer-unix.API
clang-analyzer-unix.Malloc
clang-analyzer-unix.MallocSizeof
clang-analyzer-unix.MismatchedDeallocator
clang-analyzer-unix.StdCLibraryFunctions
clang-analyzer-unix.Vfork
clang-analyzer-unix.cstring.BadSizeArg
clang-analyzer-unix.cstring.NullArg
clang-analyzer-valist.CopyToSelf
clang-analyzer-valist.Uninitialized
clang-analyzer-valist.Unterminated
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-raw-string-literal
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-replace-random-shuffle
modernize-return-braced-init-list
modernize-shrink-to-fit
modernize-unary-static-assert
modernize-use-auto
modernize-use-bool-literals
modernize-use-default-member-init
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-noexcept
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-uncaught-exceptions
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-conversion-in-loop
performance-inefficient-algorithm
performance-inefficient-string-concatenation
performance-inefficient-vector-operation
performance-move-const-arg
performance-move-constructor-init
performance-noexcept-move-constructor
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param
readability-braces-around-statements
readability-redundant-control-flow
readability-redundant-declaration
readability-redundant-function-ptr-dereference
readability-redundant-member-init
readability-redundant-smartptr-get
readability-redundant-string-cstr
readability-redundant-string-init
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/init_manager_impl.cc:10:56: warning: the parameter 'callback' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void InitManagerImpl::initialize(std::function<void()> callback) {
~~~ ^
const &
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/guarddog_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/init_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/overload_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/worker_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/connection_handler_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/proto_descriptors.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/lds_subscription.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/lds_api.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/drain_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/watchdog_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/async_client.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/admin.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc:40:3: warning: use range-based for loop instead [modernize-loop-convert]
for (size_t i = 0; i < ARRAY_SIZE(spdlog::level::level_names); i++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto level_name : spdlog::level::level_names)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc:243:27: warning: use emplace_back instead of push_back [modernize-use-emplace]
component_log_levels_.push_back(
^~~~~~~~~~
emplace_back
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc:253:26: warning: pass by value and use std::move [modernize-pass-by-value]
OptionsImpl::OptionsImpl(const std::string& service_cluster, const std::string& service_node,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc:253:62: warning: pass by value and use std::move [modernize-pass-by-value]
OptionsImpl::OptionsImpl(const std::string& service_cluster, const std::string& service_node,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/options_impl.cc:254:26: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& service_zone, spdlog::level::level_enum log_level)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/worker_impl.cc:72:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_.reset(new Thread::Thread([this, &guard_dog]() -> void { threadRoutine(guard_dog); }));
~^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/lds_api.cc:77:23: warning: the const qualified variable 'listener_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string listener_name = listener.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/guarddog_impl.cc:139:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_.reset(new Thread::Thread([this]() -> void { threadRoutine(); }));
~^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:3:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:72:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
SharedMemory* shmem = reinterpret_cast<SharedMemory*>(mmapRes.rc_);
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:133:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
stats_set_.reset(new RawStatDataSet(stats_set_options_, options.restartEpoch() == 0,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RawStatDataSet>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:240:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
RpcGetListenSocketReply* reply =
^~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:272:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
RpcGetStatsReply* reply = receiveTypedRpc<RpcGetStatsReply, RpcMessageType::GetStatsReply>();
^~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:422:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
RpcGetListenSocketRequest* message =
^~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/hot_restart_impl.cc:467:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
RpcShutdownAdminReply* reply =
^~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/overload_manager_impl.cc:23:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
bool updateValue(double value) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/overload_manager_impl.cc:29:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
bool isFired() const { return value_.has_value() && value_ >= threshold_; }
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/overload_manager_impl.cc:121:25: warning: the const qualified variable 'resource' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string resource = trigger.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/overload_manager_impl.cc:229:23: warning: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long') [bugprone-narrowing-conversions]
pressure_gauge_.set(usage.resource_pressure_ * 100); // convert to percent
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/cluster_manager.cc:13:62: warning: parameter 'dns_resolver' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: ProdClusterManagerFactory(runtime, stats, tls, random, dns_resolver, ssl_context_manager,
^~~~~~~~~~~~~
std::move()
de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/dispatcher.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/cluster_manager.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/api.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/dns.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/configuration_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/config_tracker_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/signal_action.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/terminate_handler.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/hystrix.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/metrics_service/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/metrics_service/grpc_metrics_service_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/statsd/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/dog_statsd/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/env/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/config_tracker_impl.cc:9:74: warning: std::move of the const variable 'key' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg]
? std::make_unique<ConfigTrackerImpl::EntryOwnerImpl>(map_, std::move(key))
^~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/config_tracker_impl.cc:15:51: warning: pass by value and use std::move [modernize-pass-by-value]
ConfigTrackerImpl::EntryOwnerImpl::EntryOwnerImpl(const std::shared_ptr<ConfigTracker::CbsMap>& map,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::shared_ptr<ConfigTracker::CbsMap>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/config_tracker_impl.cc:16:51: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& key)
^~~~~~~~~~~~~~~~~~
std::string
external/com_github_bombela_backward/backward.hpp:501:33: warning: Returning null reference [clang-analyzer-core.uninitialized.UndefReturn]
ref_t operator[](size_t idx) { return _val[idx]; }
^
source/exe/signal_action.cc:15:7: note: Assuming the condition is false
if (ucontext != nullptr) {
^
source/exe/signal_action.cc:15:3: note: Taking false branch
if (ucontext != nullptr) {
^
source/exe/signal_action.cc:32:3: note: Taking false branch
if (error_pc != 0) {
^
source/exe/signal_action.cc:37:3: note: Calling 'BackwardsTrace::logTrace'
tracer.logTrace();
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Calling implicit default constructor for 'TraceResolver'
backward::TraceResolver resolver;
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Calling implicit default constructor for 'TraceResolverImpl<backward::system_tag::linux_tag>'
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Calling implicit default constructor for 'TraceResolverLinuxImpl<backward::trace_resolver_tag::backtrace_symbol>'
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Calling default constructor for 'handle<char **, backward::details::deleter<void, void *, &free>>'
external/com_github_bombela_backward/backward.hpp:449:21: note: Null pointer value stored to 'resolver._symbols._val'
explicit handle(): _val(), _empty(true) {}
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Returning from default constructor for 'handle<char **, backward::details::deleter<void, void *, &free>>'
backward::TraceResolver resolver;
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Returning from default constructor for 'TraceResolverLinuxImpl<backward::trace_resolver_tag::backtrace_symbol>'
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Returning from default constructor for 'TraceResolverImpl<backward::system_tag::linux_tag>'
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:72:29: note: Returning from default constructor for 'TraceResolver'
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:77:9: note: Assuming the condition is false
if (stack_trace_.size() < 2) {
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:77:5: note: Taking false branch
if (stack_trace_.size() < 2) {
^
bazel-out/k8-fastbuild/bin/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:83:49: note: Calling 'TraceResolverLinuxImpl::resolve'
backward::ResolvedTrace first_frame_trace = resolver.resolve(stack_trace_[0]);
^
external/com_github_bombela_backward/backward.hpp:875:20: note: Calling 'handle::operator[]'
char* filename = _symbols[trace.idx];
^
external/com_github_bombela_backward/backward.hpp:501:33: note: Returning null reference
ref_t operator[](size_t idx) { return _val[idx]; }
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/signal_action.cc:3:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/signal_action.cc:12:20: warning: use nullptr [modernize-use-nullptr]
void* error_pc = 0;
^~
nullptr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/signal_action.cc:14:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const ucontext_t* ucontext = reinterpret_cast<const ucontext_t*>(context);
^~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/signal_action.cc:32:19: warning: use nullptr [modernize-use-nullptr]
if (error_pc != 0) {
^~
nullptr
bazel-out/k8-fastbuild/bin/source/server/config_validation/_virtual_includes/server_lib/server/config_validation/server.h:68:12: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
return dispatcher().createDnsResolver({});
^
source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
source/server/config_validation/server.cc:90:52: note: Calling 'ValidationInstance::dnsResolver'
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
bazel-out/k8-fastbuild/bin/source/server/config_validation/_virtual_includes/server_lib/server/config_validation/server.h:68:12: note: Call to virtual function during construction
return dispatcher().createDnsResolver({});
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:27:53: warning: parameter 'local_address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
ValidationInstance server(options, time_system, local_address, stats_store, access_log_lock,
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:25: warning: parameter 'local_address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
initialize(options, local_address, component_factory);
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:77:15: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
local_info_.reset(
~^~~~~~
= std::make_unique<LocalInfo::LocalInfoImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:78:54: warning: parameter 'local_address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
new LocalInfo::LocalInfoImpl(bootstrap.node(), local_address, options.serviceZone(),
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:82:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
overload_manager_.reset(
~^~~~~~
= std::make_unique<OverloadManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:31: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:31: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:45: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:45: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:54: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:83:54: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:84:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
listener_manager_.reset(new ListenerManagerImpl(*this, *this, *this, time_system_));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<ListenerManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:87:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
secret_manager_.reset(new Secret::SecretManagerImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Secret::SecretManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:88:24: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ssl_context_manager_.reset(new Ssl::ContextManagerImpl(*runtime_loader_, time_system_));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Ssl::ContextManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:89:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cluster_manager_factory_.reset(new Upstream::ValidationClusterManagerFactory(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Upstream::ValidationClusterManagerFactory>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:7: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:7: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:18: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:18: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:27: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:27: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:42: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:42: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:52: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:52: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:67: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:67: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:88: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:90:88: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:91:7: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
localInfo(), *secret_manager_));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:91:7: note: Call to virtual function during construction
localInfo(), *secret_manager_));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:93:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Configuration::MainImpl* main_config = new Configuration::MainImpl();
^~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:97:3: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
clusterManager().setInitializedCb(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: This constructor of an object of type 'ValidationInstance' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:48:5: note: Calling 'ValidationInstance::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/config_validation/server.cc:97:3: note: Call to virtual function during construction
clusterManager().setInitializedCb(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/configuration_impl.cc:83:31: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ratelimit_client_factory_.reset(
~^~~~~~
= std::make_unique<RateLimit::GrpcFactoryImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/configuration_impl.cc:87:31: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ratelimit_client_factory_.reset(new RateLimit::NullFactoryImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RateLimit::NullFactoryImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/configuration_impl.cc:98:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
http_tracer_.reset(new Tracing::HttpNullTracer());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Tracing::HttpNullTracer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/configuration_impl.cc:139:14: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
runtime_.reset(new RuntimeImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RuntimeImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/config.cc:25:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return std::unique_ptr<envoy::config::metrics::v2::HystrixSink>(
^~~~~~~~~~~~~~~~
std::make_unique
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/metrics_service/grpc_metrics_service_impl.cc:36:40: warning: pass by value and use std::move [modernize-pass-by-value]
MetricsServiceSink::MetricsServiceSink(const GrpcMetricsStreamerSharedPtr& grpc_metrics_streamer,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GrpcMetricsStreamerSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/statsd/config.cc:42:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return std::unique_ptr<envoy::config::metrics::v2::StatsdSink>(
^~~~~~~~~~~~~~~~
std::make_unique
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:3:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:25: warning: parameter 'local_address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
initialize(options, local_address, component_factory);
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:236:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
server_stats_.reset(
~^~~~~~
= std::make_unique<ServerStats>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:242:3: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
failHealthcheck(false);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:242:3: note: Call to virtual function during construction
failHealthcheck(false);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:252:15: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
local_info_.reset(
~^~~~~~
= std::make_unique<LocalInfo::LocalInfoImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:253:55: warning: parameter 'local_address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
new LocalInfo::LocalInfoImpl(bootstrap_.node(), local_address, options.serviceZone(),
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:262:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
admin_.reset(new AdminImpl(initial_config.admin().profilePath(), *this));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<AdminImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:283:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
overload_manager_.reset(
~^~~~~~
= std::make_unique<OverloadManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:31: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:31: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:45: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:45: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:54: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:284:54: note: Call to virtual function during construction
new OverloadManagerImpl(dispatcher(), stats(), threadLocal(), bootstrap_.overload_manager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:287:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
listener_manager_.reset(
~^~~~~~
= std::make_unique<ListenerManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:302:24: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ssl_context_manager_.reset(new Ssl::ContextManagerImpl(*runtime_loader_, time_system_));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Ssl::ContextManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:304:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cluster_manager_factory_.reset(new Upstream::ProdClusterManagerFactory(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Upstream::ProdClusterManagerFactory>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:7: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:7: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:18: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:18: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:27: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:27: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:42: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:42: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:52: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:52: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:67: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:67: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:88: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:305:88: note: Call to virtual function during construction
runtime(), stats(), threadLocal(), random(), dnsResolver(), sslContextManager(), dispatcher(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:306:7: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
localInfo(), secretManager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:306:7: note: Call to virtual function during construction
localInfo(), secretManager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:306:20: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
localInfo(), secretManager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:306:20: note: Call to virtual function during construction
localInfo(), secretManager()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:310:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Configuration::MainImpl* main_config = new Configuration::MainImpl();
^~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:323:9: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
clusterManager(), thread_local_, time_system_);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:323:9: note: Call to virtual function during construction
clusterManager(), thread_local_, time_system_);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:324:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
hds_delegate_.reset(new Upstream::HdsDelegate(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Upstream::HdsDelegate>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:325:28: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
bootstrap_.node(), stats(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:325:28: note: Call to virtual function during construction
bootstrap_.node(), stats(),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:326:92: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
Config::Utility::factoryForGrpcApiConfigSource(*async_client_manager_, hds_config, stats())
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:326:92: note: Call to virtual function during construction
Config::Utility::factoryForGrpcApiConfigSource(*async_client_manager_, hds_config, stats())
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:9: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:9: note: Call to virtual function during construction
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:23: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:23: note: Call to virtual function during construction
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:34: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:34: note: Call to virtual function during construction
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:43: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:43: note: Call to virtual function during construction
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:64: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:328:64: note: Call to virtual function during construction
dispatcher(), runtime(), stats(), sslContextManager(), random(), info_factory_,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:329:30: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
access_log_manager_, clusterManager(), localInfo()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:329:30: note: Call to virtual function during construction
access_log_manager_, clusterManager(), localInfo()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:329:48: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
access_log_manager_, clusterManager(), localInfo()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:316:3: note: Taking false branch
if (bootstrap_.dynamic_resources().has_lds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:320:3: note: Taking true branch
if (bootstrap_.has_hds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:329:48: note: Call to virtual function during construction
access_log_manager_, clusterManager(), localInfo()));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:343:14: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
guard_dog_.reset(new Server::GuardDogImpl(stats_store_, *config_, time_system_));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Server::GuardDogImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:384:5: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
failHealthcheck(true);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:9: note: Assuming the condition is false
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:65:5: note: Taking false branch
if (!options.logPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: This constructor of an object of type 'InstanceImpl' has not returned when the virtual method was called
initialize(options, local_address, component_factory);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:77:5: note: Calling 'InstanceImpl::initialize'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:7: note: Assuming the condition is false
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:245:3: note: Taking false branch
if (!StringUtil::atoul(VersionInfo::revision().substr(0, 6).c_str(), version_int, 16)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:263:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:9: note: Assuming the condition is false
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:264:5: note: Taking false branch
if (initial_config.admin().accessLogPath().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:276:3: note: Taking true branch
if (initial_config.admin().address()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:280:3: note: Calling 'InstanceImpl::loadServerFlags'
loadServerFlags(initial_config.flagsPath());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:377:3: note: Taking false branch
if (!flags_path) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:382:7: note: Assuming the condition is true
if (api_->fileExists(flags_path.value() + "/drain")) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:382:3: note: Taking true branch
if (api_->fileExists(flags_path.value() + "/drain")) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:384:5: note: Call to virtual function during construction
failHealthcheck(true);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:393:44: warning: the parameter 'workers_start_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void()> workers_start_cb) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:485:7: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
if (listener_manager_.get() != nullptr) {
^~~~~~~~~~~~~~~~~~~~~~~
listener_manager_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:494:7: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
if (config_.get() != nullptr && config_->clusterManager() != nullptr) {
^~~~~~~~~~~~~
config_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/server.cc:507:10: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
ASSERT(run_helper_.get() != nullptr);
^~~~~~~~~~~~~~~~~
run_helper_
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:40:86: note: expanded from macro 'ASSERT'
#define ASSERT(...) _ASSERT_SELECTOR(__VA_ARGS__, _ASSERT_VERBOSE, _ASSERT_ORIGINAL)(__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:32:44: note: expanded from macro '_ASSERT_ORIGINAL'
#define _ASSERT_ORIGINAL(X) RELEASE_ASSERT(X, "")
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:22:11: note: expanded from macro 'RELEASE_ASSERT'
if (!(X)) { \
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:39:33: warning: the const qualified variable 'string_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const ProtobufTypes::String string_name = proto_config.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:69:33: warning: the const qualified variable 'string_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const ProtobufTypes::String string_name = proto_config.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:119:68: warning: pass by value and use std::move [modernize-pass-by-value]
ListenerImpl::ListenerImpl(const envoy::api::v2::Listener& config, const std::string& version_info,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:120:57: warning: pass by value and use std::move [modernize-pass-by-value]
ListenerManagerImpl& parent, const std::string& name, bool modifiable,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:136:5: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
addListenSocketOptions(Network::SocketOptionFactory::buildIpTransparentOptions());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:7: note: Assuming the condition is false
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:3: note: Taking false branch
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:8: note: Assuming the condition is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:62: note: Left side of '&&' is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:8: note: Assuming the condition is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:60: note: Left side of '&&' is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:3: note: Taking false branch
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:654:11: note: Calling constructor for 'ListenerImpl'
new ListenerImpl(config, version_info, *this, name, modifiable, workers_started_, hash));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:135:3: note: Taking true branch
if (config.has_transparent()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:136:5: note: This constructor of an object of type 'ListenerImpl' has not returned when the virtual method was called
addListenSocketOptions(Network::SocketOptionFactory::buildIpTransparentOptions());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:136:5: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:139:5: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
addListenSocketOptions(Network::SocketOptionFactory::buildIpFreebindOptions());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:7: note: Assuming the condition is false
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:3: note: Taking false branch
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:8: note: Assuming the condition is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:62: note: Left side of '&&' is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:8: note: Assuming the condition is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:60: note: Left side of '&&' is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:3: note: Taking false branch
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:654:11: note: Calling constructor for 'ListenerImpl'
new ListenerImpl(config, version_info, *this, name, modifiable, workers_started_, hash));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:135:3: note: Taking false branch
if (config.has_transparent()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:138:3: note: Taking true branch
if (config.has_freebind()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:139:5: note: This constructor of an object of type 'ListenerImpl' has not returned when the virtual method was called
addListenSocketOptions(Network::SocketOptionFactory::buildIpFreebindOptions());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:139:5: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:142:5: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
addListenSocketOptions(Network::SocketOptionFactory::buildTcpFastOpenOptions(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:7: note: Assuming the condition is false
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:3: note: Taking false branch
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:8: note: Assuming the condition is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:62: note: Left side of '&&' is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:8: note: Assuming the condition is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:60: note: Left side of '&&' is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:3: note: Taking false branch
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:654:11: note: Calling constructor for 'ListenerImpl'
new ListenerImpl(config, version_info, *this, name, modifiable, workers_started_, hash));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:135:3: note: Taking false branch
if (config.has_transparent()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:138:3: note: Taking false branch
if (config.has_freebind()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:141:3: note: Taking true branch
if (config.has_tcp_fast_open_queue_length()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:142:5: note: This constructor of an object of type 'ListenerImpl' has not returned when the virtual method was called
addListenSocketOptions(Network::SocketOptionFactory::buildTcpFastOpenOptions(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:142:5: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:147:5: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
addListenSocketOptions(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:7: note: Assuming the condition is false
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:3: note: Taking false branch
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:8: note: Assuming the condition is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:62: note: Left side of '&&' is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:8: note: Assuming the condition is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:60: note: Left side of '&&' is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:3: note: Taking false branch
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:654:11: note: Calling constructor for 'ListenerImpl'
new ListenerImpl(config, version_info, *this, name, modifiable, workers_started_, hash));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:135:3: note: Taking false branch
if (config.has_transparent()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:138:3: note: Taking false branch
if (config.has_freebind()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:141:3: note: Taking false branch
if (config.has_tcp_fast_open_queue_length()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:146:7: note: Assuming the condition is true
if (config.socket_options().size() > 0) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:146:3: note: Taking true branch
if (config.socket_options().size() > 0) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:147:5: note: This constructor of an object of type 'ListenerImpl' has not returned when the virtual method was called
addListenSocketOptions(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:147:5: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:234:36: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
factory_context.setInitManager(initManager());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:7: note: Assuming the condition is false
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:632:3: note: Taking false branch
if (!config.name().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:8: note: Assuming the condition is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:62: note: Left side of '&&' is false
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:8: note: Assuming the condition is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:647:60: note: Left side of '&&' is false
(existing_active_listener != active_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:645:3: note: Taking false branch
if ((existing_warming_listener != warming_listeners_.end() &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:654:11: note: Calling constructor for 'ListenerImpl'
new ListenerImpl(config, version_info, *this, name, modifiable, workers_started_, hash));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:135:3: note: Taking false branch
if (config.has_transparent()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:138:3: note: Taking false branch
if (config.has_freebind()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:141:3: note: Taking false branch
if (config.has_tcp_fast_open_queue_length()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:146:7: note: Assuming the condition is false
if (config.socket_options().size() > 0) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:146:3: note: Taking false branch
if (config.socket_options().size() > 0) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:151:7: note: Assuming the condition is false
if (!config.listener_filters().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:151:3: note: Taking false branch
if (!config.listener_filters().empty()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:156:3: note: Taking false branch
if (PROTOBUF_GET_WRAPPED_OR_DEFAULT(config, use_original_dst, false)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:167:3: note: Taking false branch
if (PROTOBUF_GET_WRAPPED_OR_DEFAULT(config.filter_chains()[0], use_proxy_proto, false)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:181:5: note: Taking false branch
if (filter_chains.find(filter_chain_match) != filter_chains.end()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:192:5: note: Taking true branch
if (!filter_chain.has_transport_socket()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:193:7: note: Taking false branch
if (filter_chain.has_tls_context()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:234:36: note: This constructor of an object of type 'ListenerImpl' has not returned when the virtual method was called
factory_context.setInitManager(initManager());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:234:36: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:760:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<DrainingListener>::iterator draining_it = draining_listeners_.emplace(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/listener_manager_impl.cc:816:9: warning: use emplace_back instead of push_back [modernize-use-emplace]
ret.push_back(*listener);
^~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/dog_statsd/config.cc:29:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return std::unique_ptr<envoy::config::metrics::v2::DogStatsdSink>(
^~~~~~~~~~~~~~~~
std::make_unique
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/hystrix.cc:25:38: warning: pass by value and use std::move [modernize-pass-by-value]
ClusterStatsCache::ClusterStatsCache(const std::string& cluster_name)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/hystrix.cc:41:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto specific_stat_vec_itr = rolling_window.begin();
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(unsigned long & specific_stat_vec_itr : rolling_window)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/hystrix.cc:53:8: warning: the type of the loop variable 'element' is different from the one returned by the iterator and generates an implicit conversion; you can either change the type to the matching one ('const std::pair<const double, double> &' but 'const auto&' is always a valid option) or remove the reference to make it explicit that you are creating a new value [performance-implicit-conversion-in-loop]
for (const std::pair<double, double>& element : latency_map) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/hystrix/hystrix.cc:86:21: warning: the const qualified variable 'cluster_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string cluster_name = cluster_info.name();
^
&
oy/source/extensions/stat_sinks/common/statsd/statsd.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/retry/host/other_hosts/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/retry/priority/other_priority/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/retry/priority/other_priority/other_priority.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/file/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/file/file_access_log_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/http_grpc/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/http_grpc/grpc_access_log_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_frame_protector.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_handshaker.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/capture/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/capture/capture.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/ssl/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/raw_buffer/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/grpc_credentials/file_based_metadata/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/grpc_c/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/retry/priority/other_priority/other_priority.cc:45:5: warning: use range-based for loop instead [modernize-loop-convert]
for (size_t i = 0; i < excluded_priorities_.size(); ++i) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto && excluded_prioritie : excluded_priorities_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/file/config.cc:35:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
formatter.reset(new AccessLog::FormatterImpl(fal_config.format()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<AccessLog::FormatterImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/file/config.cc:40:15: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
formatter.reset(new AccessLog::JsonFormatterImpl(json_format_map));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<AccessLog::JsonFormatterImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/file/config.cc:57:66: warning: the parameter 'json_format' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
FileAccessLogFactory::convertJsonFormatToMap(ProtobufWkt::Struct json_format) {
~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_handshaker.cc:14:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
TsiHandshaker* handshaker = static_cast<TsiHandshaker*>(user_data);
^~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc:56:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
restarter_.reset(new Server::HotRestartImpl(options_));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Server::HotRestartImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc:59:9: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
if (restarter_.get() == nullptr) {
^~~~~~~~~~~~~~~~
restarter_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc:60:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
restarter_.reset(new Server::HotRestartNopImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Server::HotRestartNopImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc:63:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
tls_.reset(new ThreadLocal::InstanceImpl);
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<ThreadLocal::InstanceImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/exe/main_common.cc:81:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
restarter_.reset(new Server::HotRestartNopImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Server::HotRestartNopImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/stat_sinks/common/statsd/statsd.cc:23:57: warning: the parameter 'address' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Writer::Writer(Network::Address::InstanceConstSharedPtr address) {
~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/capture/capture.cc:96:5: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& path_prefix,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/http_grpc/grpc_access_log_impl.cc:69:5: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::config::accesslog::v2::HttpGrpcAccessLogConfig& config,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::config::accesslog::v2::HttpGrpcAccessLogConfig
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/http_grpc/grpc_access_log_impl.cc:70:5: warning: pass by value and use std::move [modernize-pass-by-value]
GrpcAccessLogStreamerSharedPtr grpc_access_log_streamer)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/access_loggers/http_grpc/grpc_access_log_impl.cc:72:33: warning: parameter 'grpc_access_log_streamer' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
grpc_access_log_streamer_(grpc_access_log_streamer) {
^~~~~~~~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc:65:38: warning: the const qualified parameter 'config' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
Filter::Filter(const ConfigSharedPtr config) : config_(config), ssl_(config_->newSsl()) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc:191:3: warning: the value returned by this function should be used [bugprone-unused-return-value]
bio.release();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc:191:3: note: cast the expression to void to silence this warning
redentials/example/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/tls_inspector/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/tls_inspector/tls_inspector.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/original_dst/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/original_dst/original_dst.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/proxy_protocol/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/ratelimit/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/ratelimit/ratelimit.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/codec_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/conn_pool_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/proxy_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/tcp_proxy/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot//home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:13:22: warning: pass by value and use std::move [modernize-pass-by-value]
TsiSocket::TsiSocket(HandshakerFactory handshaker_factory, HandshakeValidator handshake_validator,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:13:60: warning: pass by value and use std::move [modernize-pass-by-value]
TsiSocket::TsiSocket(HandshakerFactory handshaker_factory, HandshakeValidator handshake_validator,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:15:27: warning: parameter 'handshaker_factory' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: handshaker_factory_(handshaker_factory), handshake_validator_(handshake_validator),
^~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:15:69: warning: parameter 'handshake_validator' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: handshaker_factory_(handshaker_factory), handshake_validator_(handshake_validator),
^~~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:19:17: warning: parameter 'handshaker_factory' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: TsiSocket(handshaker_factory, handshake_validator,
^~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:19:37: warning: parameter 'handshake_validator' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: TsiSocket(handshaker_factory, handshake_validator,
^~~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/transport_sockets/alts/tsi_socket.cc:124:73: warning: use nullptr [modernize-use-nullptr]
tsi_handshaker_result_create_frame_protector(handshaker_result, NULL, &frame_protector);
^~~~~
nullptr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/codec_impl.cc:136:27: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
pending_value_root_.reset(new RespValue());
~^~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RespValue>
bazel-out/k8-fastbuild/bin/source/common/stats/_virtual_includes/histogram_lib/common/stats/histogram_impl.h:23:51: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
HistogramStatisticsImpl() : computed_quantiles_(supportedQuantiles().size(), 0.0) {}
^
source/server/http/admin.cc:958:63: note: Calling 'AdminImpl::handlerStats'
{"/stats", "print server stats", MAKE_ADMIN_HANDLER(handlerStats), false, false},
^
bazel-out/k8-fastbuild/bin/include/envoy/server/_virtual_includes/admin_interface/envoy/server/admin.h:58:12: note: expanded from macro 'MAKE_ADMIN_HANDLER'
return X(path_and_query, response_headers, data, admin_stream); \
^
source/server/http/admin.cc:536:27: note: Assuming the condition is true
const bool has_format = !(params.find("format") == params.end());
^
source/server/http/admin.cc:538:7: note: Assuming the condition is false
(params.find("filter") != params.end())
^
source/server/http/admin.cc:538:7: note: '?' condition is false
source/server/http/admin.cc:555:3: note: Taking true branch
if (has_format) {
^
source/server/http/admin.cc:557:5: note: Taking true branch
if (format_value == "json") {
^
source/server/http/admin.cc:561:11: note: Calling 'AdminImpl::statsAsJson'
AdminImpl::statsAsJson(all_stats, server_.stats().histograms(), used_only, regex));
^
source/server/http/admin.cc:677:5: note: Taking true branch
if (shouldShowMetric(histogram, used_only, regex)) {
^
source/server/http/admin.cc:678:7: note: Taking true branch
if (!found_used_histogram) {
^
source/server/http/admin.cc:681:40: note: Calling default constructor for 'HistogramStatisticsImpl'
Stats::HistogramStatisticsImpl empty_statistics;
^
bazel-out/k8-fastbuild/bin/source/common/stats/_virtual_includes/histogram_lib/common/stats/histogram_impl.h:23:51: note: This constructor of an object of type 'HistogramStatisticsImpl' has not returned when the virtual method was called
HistogramStatisticsImpl() : computed_quantiles_(supportedQuantiles().size(), 0.0) {}
^
bazel-out/k8-fastbuild/bin/source/common/stats/_virtual_includes/histogram_lib/common/stats/histogram_impl.h:23:51: note: Call to virtual function during construction
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:206:106: warning: Access to field 'size' results in a dereference of a null pointer (loaded from field 'chunkHead_') [clang-analyzer-core.NullDereference]
if (originalPtr == reinterpret_cast<char *>(chunkHead_) + RAPIDJSON_ALIGN(sizeof(ChunkHeader)) + chunkHead_->size - originalSize) {
^
source/server/http/admin.cc:963:67: note: Calling 'AdminImpl::handlerRuntime'
{"/runtime", "print runtime values", MAKE_ADMIN_HANDLER(handlerRuntime), false, false},
^
bazel-out/k8-fastbuild/bin/include/envoy/server/_virtual_includes/admin_interface/envoy/server/admin.h:58:12: note: expanded from macro 'MAKE_ADMIN_HANDLER'
return X(path_and_query, response_headers, data, admin_stream); \
^
source/server/http/admin.cc:784:23: note: Calling default constructor for 'GenericDocument<rapidjson::UTF8<char>, rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator>, rapidjson::CrtAllocator>'
rapidjson::Document document;
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:2053:9: note: Taking true branch
if (!allocator_)
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:2054:56: note: Calling default constructor for 'MemoryPoolAllocator<rapidjson::CrtAllocator>'
ownAllocator_ = allocator_ = RAPIDJSON_NEW(Allocator());
^
external/com_github_tencent_rapidjson/include/rapidjson/error/../rapidjson.h:586:30: note: expanded from macro 'RAPIDJSON_NEW'
#define RAPIDJSON_NEW(x) new x
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:111:9: note: Null pointer value stored to field 'chunkHead_'
chunkHead_(0), chunk_capacity_(chunkSize), userBuffer_(0), baseAllocator_(baseAllocator), ownBaseAllocator_(0)
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:2054:56: note: Returning from default constructor for 'MemoryPoolAllocator<rapidjson::CrtAllocator>'
ownAllocator_ = allocator_ = RAPIDJSON_NEW(Allocator());
^
external/com_github_tencent_rapidjson/include/rapidjson/error/../rapidjson.h:586:30: note: expanded from macro 'RAPIDJSON_NEW'
#define RAPIDJSON_NEW(x) new x
^
source/server/http/admin.cc:784:23: note: Returning from default constructor for 'GenericDocument<rapidjson::UTF8<char>, rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator>, rapidjson::CrtAllocator>'
rapidjson::Document document;
^
source/server/http/admin.cc:806:3: note: Calling 'GenericValue::AddMember'
document.AddMember("layers", std::move(layer_names), allocator);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1275:16: note: Calling 'GenericValue::AddMember'
return AddMember(n, value, allocator);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1187:9: note: '?' condition is true
RAPIDJSON_ASSERT(IsObject());
^
external/com_github_tencent_rapidjson/include/rapidjson/error/../rapidjson.h:402:29: note: expanded from macro 'RAPIDJSON_ASSERT'
#define RAPIDJSON_ASSERT(x) assert(x)
^
/usr/include/assert.h:89:4: note: expanded from macro 'assert'
((expr) \
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1188:9: note: '?' condition is true
RAPIDJSON_ASSERT(name.IsString());
^
external/com_github_tencent_rapidjson/include/rapidjson/error/../rapidjson.h:402:29: note: expanded from macro 'RAPIDJSON_ASSERT'
#define RAPIDJSON_ASSERT(x) assert(x)
^
/usr/include/assert.h:89:4: note: expanded from macro 'assert'
((expr) \
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1191:9: note: Taking true branch
if (o.size >= o.capacity) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1192:13: note: Taking false branch
if (o.capacity == 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1199:61: note: Calling 'MemoryPoolAllocator::Realloc'
SetMembersPointer(reinterpret_cast<Member*>(allocator.Realloc(GetMembersPointer(), oldCapacity * sizeof(Member), o.capacity * sizeof(Member))));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:192:13: note: Assuming 'originalPtr' is not equal to null
if (originalPtr == 0)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:192:9: note: Taking false branch
if (originalPtr == 0)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:195:13: note: Assuming 'newSize' is not equal to 0
if (newSize == 0)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:195:9: note: Taking false branch
if (newSize == 0)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:202:13: note: Assuming 'originalSize' is < 'newSize'
if (originalSize >= newSize)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:202:9: note: Taking false branch
if (originalSize >= newSize)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/../allocators.h:206:106: note: Access to field 'size' results in a dereference of a null pointer (loaded from field 'chunkHead_')
if (originalPtr == reinterpret_cast<char *>(chunkHead_) + RAPIDJSON_ALIGN(sizeof(ChunkHeader)) + chunkHead_->size - originalSize) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:370:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto stat : all_stats) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:482:5: warning: use range-based for loop instead [modernize-loop-convert]
for (size_t i = 0; i < ARRAY_SIZE(spdlog::level::level_names); i++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto level_name : spdlog::level::level_names)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:570:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto stat : all_stats) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:582:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto histogram : all_histograms) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:606:5: warning: 'push_back' is called inside a loop; consider pre-allocating the vector capacity before the loop [performance-inefficient-vector-operation]
buf.push_back(fmt::format("{}=\"{}\"", sanitizeName(tag.name_), tag.value_));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:649:79: warning: the const qualified parameter 'regex' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
const bool used_only, const absl::optional<std::regex> regex,
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:655:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto stat : all_stats) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/server/http/admin.cc:924:22: warning: pass by value and use std::move [modernize-pass-by-value]
AdminImpl::AdminImpl(const std::string& profile_path, Server::Instance& server)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc:3:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
^~~~~~~~~~
<cstring>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc:288:18: warning: function 'memcmp' is called without explicitly comparing result [bugprone-suspicious-string-compare]
} else if (memcmp(buf_, PROXY_PROTO_V1_SIGNATURE, PROXY_PROTO_V1_SIGNATURE_LEN)) {
^ ~
!= 0
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/deserializer_impl.cc:8:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
RpcInvocationImpl::~RpcInvocationImpl() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/deserializer_impl.cc:9:38: warning: pass by value and use std::move [modernize-pass-by-value]
RpcInvocationImpl::RpcInvocationImpl(const std::string& method_name,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/deserializer_impl.cc:10:38: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& service_name,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/deserializer_impl.cc:11:38: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& service_version)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/proxy_filter.cc:33:63: warning: pass by value and use std::move [modernize-pass-by-value]
CommandSplitter::Instance& splitter, ProxyFilterConfigSharedPtr config)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/proxy_filter.cc:35:15: warning: parameter 'config' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
config_(config) {
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/conn_pool_impl.cc:20:59: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
ClientPtr ClientImpl::create(Upstream::HostConstSharedPtr host, Event::Dispatcher& dispatcher,
~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/conn_pool_impl.cc:34:53: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
ClientImpl::ClientImpl(Upstream::HostConstSharedPtr host, Event::Dispatcher& dispatcher,
~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/conn_pool_impl.cc:252:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
client.reset(new ThreadLocalActiveClient(*this));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<ThreadLocalActiveClient>
envoy/source/extensions/filters/network/rbac/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/rbac/rbac_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/ext_authz/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/ext_authz/ext_authz.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/sni_cluster/sni_cluster.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/sni_cluster/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/buffer_helper.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/hessian_utils.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/deserializer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/hessian_deserializer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/dubbo_protocol_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/echo/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/echo/echo.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/bson_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/proxy.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/sou/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc:32:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::list<Http::FilterFactoryCb> FilterFactoriesList;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using FilterFactoriesList = std::list<Http::FilterFactoryCb>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc:33:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::map<std::string, std::unique_ptr<FilterFactoriesList>> FilterFactoryMap;
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc:226:32: warning: use emplace_back instead of push_back [modernize-use-emplace]
request_headers_for_tags.push_back(Http::LowerCaseString(header));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc:236:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
tracing_config_.reset(new Http::TracingConnectionManagerConfig(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Http::TracingConnectionManagerConfig>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/http_connection_manager/config.cc:272:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto upgrade_config : config.upgrade_configs()) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/hessian_utils.cc:413:3: warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
return;
~~^~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/dubbo_proxy/hessian_deserializer_impl.cc:55:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
RpcResponseType type = static_cast<RpcResponseType>(HessianUtils::peekInt(buffer, &total_size));
^~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc:115:34: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request_ptr->pending_response_.reset(new RespValue());
~^~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RespValue>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc:188:34: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request_ptr->pending_response_.reset(new RespValue());
~^~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RespValue>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc:255:34: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request_ptr->pending_response_.reset(new RespValue());
~^~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RespValue>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/bson_impl.cc:350:24: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
return fmt::format("[\"{}\", \"{}\"]", value_.regex_value_.pattern_,
^~~~~~~~~~~~~~~~~~~
R"(["{}", "{}"])"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/bson_impl.cc:430:24: warning: std::move of the variable 'value' of the trivially-copyable type 'Field::ObjectId' (aka 'array<unsigned char, 12>') has no effect; remove std::move() [performance-move-const-arg]
addObjectId(key, std::move(value));
^~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/app_exception_impl.cc:11:26: warning: redundant string initialization [readability-redundant-string-init]
static const std::string StopField = "";
^~~~~~~~~~~~~~~
StopField
rce/extensions/filters/network/mongo_proxy/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/codec_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/buffer_helper.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/thrift_object_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/auto_protocol_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/app_exception_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/auto_transport_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/unframed_transport_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/binary_protocol_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/header_transport_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_ratelimit_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/config.cc:32:10: warning: the variable 'delay' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
auto delay = proto_config.delay();
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/binary_protocol_impl.cc:33:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
MessageType type = static_cast<MessageType>(buffer.peekInt<int8_t>(3));
^~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/binary_protocol_impl.cc:374:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
MessageType type = static_cast<MessageType>(buffer.peekInt<int8_t>(name_len + 4));
^~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/header_transport_impl.cc:97:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
HeaderProtocolType header_proto =
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/header_transport_impl.cc:210:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Buffer::Instance* hb = static_cast<Buffer::Instance*>(context);
^~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/proxy.cc:44:52: warning: pass by value and use std::move [modernize-pass-by-value]
Runtime::Loader& runtime, AccessLogSharedPtr access_log,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/proxy.cc:45:26: warning: pass by value and use std::move [modernize-pass-by-value]
const FaultConfigSharedPtr& fault_config,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
FaultConfigSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/proxy.cc:50:19: warning: parameter 'access_log' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
access_log_(access_log), fault_config_(fault_config), time_system_(time_system) {
^~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/codec_impl.cc:361:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Message::OpCode op_code = static_cast<Message::OpCode>(Bson::BufferHelper::removeInt32(data));
^~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/mongo_proxy/codec_impl.cc:429:44: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
while (data.length() > 0 && decode(data))
^
{
source/extensions/filters/network/thrift_proxy/config.cc:28:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::map<envoy::config::filter::network::thrift_proxy::v2alpha1::TransportType,
^
source/extensions/filters/network/thrift_proxy/config.cc:47:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::map<envoy::config::filter::network::thrift_proxy::v2alpha1::ProtocolType, ProtocolType>
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_ratelimit_impl.cc:74:21: warning: use emplace_back instead of push_back [modernize-use-emplace]
action_headers_.push_back(header_matcher);
^~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/filters/ratelimit/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/filters/ratelimit/ratelimit.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/framed_transport_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/client_ssl_auth/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/client_ssl_auth/client_ssl_auth.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ratelimit/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ratelimit/ratelimit.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/cors/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/cors/cors_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ip_tagging/ip_tagging_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ip_tagging/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/router/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/rbac/rbac_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/rbac/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/mast/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:26:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::StructBegin, handler_.messageBegin(metadata_));
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:35:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::Done, handler_.messageEnd());
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:45:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::FieldBegin, handler_.structBegin(absl::string_view(name)));
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:55:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(next_state, handler_.structEnd());
^~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:74:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::FieldValue,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
{
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:94:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::FieldBegin, handler_.fieldEnd());
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:107:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::ListValue, handler_.listBegin(elem_type, size));
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:116:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(popReturnState(), FilterStatus::Continue);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:130:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(next_state, handler_.listEnd());
^~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:143:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::MapKey, handler_.mapBegin(key_type, value_type, size));
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:152:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(popReturnState(), FilterStatus::Continue);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:176:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(next_state, handler_.mapEnd());
^~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:189:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::SetValue, handler_.setBegin(elem_type, size));
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:198:12: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(popReturnState(), FilterStatus::Continue);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:212:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(next_state, handler_.setEnd());
^~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/decoder.cc:284:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return DecoderStatus(ProtocolState::WaitForData);
^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
{ }
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc:37:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
MessageType type = static_cast<MessageType>((version & ~MagicMask) >> 5);
^~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc:59:25: warning: either cast from 'int' to 'uint64_t' (aka 'unsigned long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast]
if (buffer.length() < static_cast<uint64_t>(id_size + name_len_size + name_len + 2)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc:193:25: warning: either cast from 'int' to 'uint64_t' (aka 'unsigned long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast]
if (buffer.length() < static_cast<uint64_t>(s_size + 1)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/compact_protocol_impl.cc:371:25: warning: either cast from 'int' to 'uint64_t' (aka 'unsigned long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast]
if (buffer.length() < static_cast<uint64_t>(str_len + len_size)) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/cors/cors_filter.cc:15:61: warning: member initializer for 'is_cors_request_' is redundant [modernize-use-default-member-init]
CorsFilter::CorsFilter() : policies_({{nullptr, nullptr}}), is_cors_request_(false) {}
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:23:21: warning: use emplace_back instead of push_back [modernize-use-emplace]
config_headers_.push_back(header_map);
^~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:30:32: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
metadata_match_criteria_.reset(
~^~~~~~
= std::make_unique<Envoy::Router::MetadataMatchCriteriaImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:77:34: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
metadata_match_criteria_.reset(
~^~~~~~
= std::make_unique<Envoy::Router::MetadataMatchCriteriaImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:258:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
upstream_request_.reset(new UpstreamRequest(*this, *conn_pool, metadata, transport, protocol));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<UpstreamRequest>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:353:35: warning: parameter 'metadata' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
ProtocolConverter::messageBegin(metadata);
^~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:366:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
Router::UpstreamRequest::~UpstreamRequest() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/router/router_impl.cc:453:20: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
upstream_host_ = host;
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:25:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
ConnectionManager::~ConnectionManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:407:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::string& name = absl::any_cast<std::string&>(filter_context_);
^~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:424:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::tuple<std::string, FieldType, int16_t>& t =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:504:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::string& value = absl::any_cast<std::string&>(filter_context_);
^~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:516:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::tuple<FieldType, FieldType, uint32_t>& t =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:536:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::tuple<FieldType, uint32_t>& t =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/conn_manager.cc:555:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
std::tuple<FieldType, uint32_t>& t =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ip_tagging/ip_tagging_filter.cc:13:34: warning: pass by value and use std::move [modernize-pass-by-value]
IpTaggingFilter::IpTaggingFilter(IpTaggingFilterConfigSharedPtr config) : config_(config) {}
^ ~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ip_tagging/ip_tagging_filter.cc:13:83: warning: parameter 'config' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
IpTaggingFilter::IpTaggingFilter(IpTaggingFilterConfigSharedPtr config) : config_(config) {}
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ip_tagging/ip_tagging_filter.cc:15:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
IpTaggingFilter::~IpTaggingFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:30:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<StructNameValues> StructNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using StructNames = ConstSingleton<StructNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:44:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<RequestHeaderFieldNameValues> RequestHeaderFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using RequestHeaderFieldNames = ConstSingleton<RequestHeaderFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:49:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<ClientIdFieldNameValues> ClientIdFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using ClientIdFieldNames = ConstSingleton<ClientIdFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:55:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<DelegationFieldNameValues> DelegationFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using DelegationFieldNames = ConstSingleton<DelegationFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:61:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<RequestContextFieldNameValues> RequestContextFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using RequestContextFieldNames = ConstSingleton<RequestContextFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:67:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<ResponseHeaderFieldNameValues> ResponseHeaderFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using ResponseHeaderFieldNames = ConstSingleton<ResponseHeaderFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:78:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<SpanFieldNameValues> SpanFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using SpanFieldNames = ConstSingleton<SpanFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:85:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<AnnotationFieldNameValues> AnnotationFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using AnnotationFieldNames = ConstSingleton<AnnotationFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:93:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<BinaryAnnotationFieldNameValues> BinaryAnnotationFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using BinaryAnnotationFieldNames = ConstSingleton<BinaryAnnotationFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:100:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<EndpointFieldNameValues> EndpointFieldNames;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using EndpointFieldNames = ConstSingleton<EndpointFieldNameValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:119:10: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
static UnframedTransportImpl* transport = new UnframedTransportImpl();
^~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:124:10: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
static HeaderObjectProtocol* protocol = new HeaderObjectProtocol();
^~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:135:12: warning: pass by value and use std::move [modernize-pass-by-value]
ClientId(const std::string& name) : name_(name) {}
^~~~~~~~~~~~~~~~~~ ~~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:169:3: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
UpgradeReply() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:224:18: warning: pass by value and use std::move [modernize-pass-by-value]
RequestContext(const std::string& key, const std::string& value) : key_(key), value_(value) {}
^~~~~~~~~~~~~~~~~~ ~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:224:42: warning: pass by value and use std::move [modernize-pass-by-value]
RequestContext(const std::string& key, const std::string& value) : key_(key), value_(value) {}
^~~~~~~~~~~~~~~~~~ ~~~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:265:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::list<RequestContext> RequestContextList;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using RequestContextList = std::list<RequestContext>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:274:14: warning: pass by value and use std::move [modernize-pass-by-value]
Delegation(const std::string& src, const std::string& dst) : src_(src), dst_(dst) {}
^~~~~~~~~~~~~~~~~~ ~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:274:38: warning: pass by value and use std::move [modernize-pass-by-value]
Delegation(const std::string& src, const std::string& dst) : src_(src), dst_(dst) {}
^~~~~~~~~~~~~~~~~~ ~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:315:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::list<Delegation> DelegationList;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using DelegationList = std::list<Delegation>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:529:13: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const ThriftStructValue& ctxt_struct = elem->getValueTyped<ThriftStructValue>();
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:537:13: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const ThriftStructValue& ctxt_struct = elem->getValueTyped<ThriftStructValue>();
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:919:13: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const ThriftStructValue& ctxt_struct = elem->getValueTyped<ThriftStructValue>();
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/network/thrift_proxy/twitter_protocol_impl.cc:1114:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
UpgradeReply& upgrade_reply = dynamic_cast<UpgradeReply&>(response);
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/rbac/rbac_filter.cc:27:78: warning: the const qualified parameter 'route' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
RoleBasedAccessControlFilterConfig::engine(const Router::RouteConstSharedPtr route,
^
&
er/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ext_authz/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/ext_authz/ext_authz.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/transcoder_input_stream_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/lua_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/wrappers.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/fault/fault_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/fault/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/gzip/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/gzip/gzip_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/buffer/buffer_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/buffer/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/wrappers.cc:16:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
HeaderMapIterator* iterator = static_cast<HeaderMapIterator*>(context);
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:22:48: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
const std::regex SquashFilterConfig::ENV_REGEX("\\{\\{ (\\w+) \\}\\}");
^~~~~~~~~~~~~~~~~~~~~~~
R"(\{\{ (\w+) \}\})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:121:28: warning: pass by value and use std::move [modernize-pass-by-value]
SquashFilter::SquashFilter(SquashFilterConfigSharedPtr config, Upstream::ClusterManager& cm)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:122:15: warning: parameter 'config' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: config_(config), is_squashing_(false), debug_attachment_path_(),
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:122:46: warning: initializer for member 'debug_attachment_path_' is redundant [readability-redundant-member-init]
: config_(config), is_squashing_(false), debug_attachment_path_(),
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:131:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
SquashFilter::~SquashFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/squash/squash_filter.cc:149:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request->body().reset(new Buffer::OwnedImpl(config_->attachmentJson()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/gzip/gzip_filter.cc:105:24: warning: pass by value and use std::move [modernize-pass-by-value]
GzipFilter::GzipFilter(const GzipFilterConfigSharedPtr& config)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GzipFilterConfigSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/gzip/gzip_filter.cc:106:32: warning: initializer for member 'compressed_data_' is redundant [readability-redundant-member-init]
: skip_compression_{true}, compressed_data_(), compressor_(), config_(config) {}
^~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/gzip/gzip_filter.cc:106:52: warning: initializer for member 'compressor_' is redundant [readability-redundant-member-init]
: skip_compression_{true}, compressed_data_(), compressor_(), config_(config) {}
^~~~~~~~~~~~~~~
source/extensions/filters/http/fault/fault_filter.cc:48:8: warning: the type of the loop variable 'header_map' is different from the one returned by the iterator and generates an implicit conversion; you can either change the type to the matching one ('const envoy::api::v2::route::HeaderMatcher &' but 'const auto&' is always a valid option) or remove the reference to make it explicit that you are creating a new value [performance-implicit-conversion-in-loop]
for (const Http::HeaderUtility::HeaderData& header_map : fault.headers()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/fault/fault_filter.cc:65:26: warning: pass by value and use std::move [modernize-pass-by-value]
FaultFilter::FaultFilter(FaultFilterConfigSharedPtr config) : config_(config) {}
^ ~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/fault/fault_filter.cc:65:71: warning: parameter 'config' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
FaultFilter::FaultFilter(FaultFilterConfigSharedPtr config) : config_(config) {}
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/fault/fault_filter.cc:83:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const FaultSettings* tmp = route_entry->perFilterConfigTyped<FaultSettings>(name);
^~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc:124:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
type_helper_.reset(
~^~~~~~
= std::make_unique<google::grpc::transcoding::TypeHelper>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc:128:14: warning: the const qualified variable 'print_config' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const auto print_config = proto_config.print_options();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc:195:14: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
transcoder.reset(
~^~~~~~
= std::make_unique<TranscoderImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/buffer/buffer_filter.cc:46:56: warning: the parameter 'config' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
BufferFilter::BufferFilter(BufferFilterConfigSharedPtr config)
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/buffer/buffer_filter.cc:64:9: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const BufferFilterSettings* tmp = entry->perFilterConfigTyped<BufferFilterSettings>(name);
^~~~~~~~~~~~~~~~~~~~~
auto
/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/header_to_metadata/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/header_to_metadata/header_to_metadata_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/dynamo/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/dynamo/dynamo_request_parser.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/dynamo/dynamo_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/dynamo/dynamo_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/matcher.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/authenticator.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/filter_factory.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/jwks_cache.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/verifier.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_http1_bridge/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_http1_bridge/http1_bridge_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_web/grpc_web_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_liz/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/header_to_metadata/header_to_metadata_filter.cc:21:82: warning: the const qualified parameter 'config' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
Config::Config(const envoy::config::filter::http::header_to_metadata::v2::Config config) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/header_to_metadata/header_to_metadata_filter.cc:55:70: warning: the const qualified parameter 'config' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
HeaderToMetadataFilter::HeaderToMetadataFilter(const ConfigSharedPtr config) : config_(config) {}
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/header_to_metadata/header_to_metadata_filter.cc:57:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
HeaderToMetadataFilter::~HeaderToMetadataFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/lua_filter.cc:126:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
body.reset(new Buffer::OwnedImpl(raw_body, body_size));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/lua_filter.cc:182:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
message->body().reset(new Buffer::OwnedImpl(body, body_size));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/lua/lua_filter.cc:255:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
response_message->body().reset(new Buffer::OwnedImpl("upstream failure"));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:29:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<JwtConstValueStruct> JwtConstValues;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using JwtConstValues = ConstSingleton<JwtConstValueStruct>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:34:19: warning: pass by value and use std::move [modernize-pass-by-value]
JwtLocationBase(const std::string& token, const std::unordered_set<std::string>& issuers)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:104:24: warning: pass by value and use std::move [modernize-pass-by-value]
HeaderLocationSpec(const Http::LowerCaseString& header, const std::string& value_prefix)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Http::LowerCaseString
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:104:61: warning: pass by value and use std::move [modernize-pass-by-value]
HeaderLocationSpec(const Http::LowerCaseString& header, const std::string& value_prefix)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:113:3: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::unique_ptr<HeaderLocationSpec> HeaderLocationSpecPtr;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using HeaderLocationSpecPtr = std::unique_ptr<HeaderLocationSpec>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/extractor.cc:160:26: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
header_location_spec.reset(new HeaderLocationSpec(header_name, value_prefix));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<HeaderLocationSpec>
source/extensions/filters/http/jwt_authn/jwks_cache.cc:104:52: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
issuer_ptr_map_.emplace(provider.issuer(), findByProvider(it.first));
^
source/extensions/filters/http/jwt_authn/jwks_cache.cc:137:27: note: Calling constructor for 'JwksCacheImpl'
return JwksCachePtr(new JwksCacheImpl(config, time_source));
^
source/extensions/filters/http/jwt_authn/jwks_cache.cc:103:7: note: Taking true branch
if (issuer_ptr_map_.find(provider.issuer()) == issuer_ptr_map_.end()) {
^
source/extensions/filters/http/jwt_authn/jwks_cache.cc:104:52: note: This constructor of an object of type 'JwksCacheImpl' has not returned when the virtual method was called
issuer_ptr_map_.emplace(provider.issuer(), findByProvider(it.first));
^
source/extensions/filters/http/jwt_authn/jwks_cache.cc:104:52: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_web/grpc_web_filter.cc:192:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Buffer::Instance* temp = static_cast<Buffer::Instance*>(context);
^~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/filter.cc:14:38: warning: the parameter 'config' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Filter::Filter(FilterConfigSharedPtr config) : stats_(config->stats()), config_(config) {}
~~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/authenticator.cc:33:21: warning: pass by value and use std::move [modernize-pass-by-value]
const absl::optional<std::string>& provider, bool allow_failed,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::optional<std::string>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/authenticator.cc:35:21: warning: pass by value and use std::move [modernize-pass-by-value]
CreateJwksFetcherCb create_jwks_fetcher_cb, TimeSource& time_source)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/authenticator.cc:37:33: warning: parameter 'create_jwks_fetcher_cb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
create_jwks_fetcher_cb_(create_jwks_fetcher_cb), check_audience_(check_audience),
^~~~~~~~~~~~~~~~~~~~~~~
std::move()
an/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/grpc_web/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/health_check/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/health_check/health_check.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/rbac/matchers.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/rbac/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/rbac/engine_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/ext_authz_http_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/ext_authz_grpc_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/lua.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/wrappers.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/resource_monitors/fixed_heap/fixed_heap_monitor.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/resource_monitors/fixed_heap/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/resource_monitors/injected_resource/injected_resource_monitor.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/resource_monitors/injected_resource/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de2/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_buffer.cc:14:26: warning: std::move of the const variable 'span' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg]
span_buffer_.push_back(std::move(span));
^~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/matcher.cc:27:23: warning: use emplace_back instead of push_back [modernize-use-emplace]
config_headers_.push_back(header_map);
^~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/jwt_authn/matcher.cc:31:32: warning: use emplace_back instead of push_back [modernize-use-emplace]
config_query_parameters_.push_back(query_parameter);
^~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:21:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~JwksFetcherImpl() { cancel(); }
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:21:24: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
~JwksFetcherImpl() { cancel(); }
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:21:24: note: This destructor of an object of type '~JwksFetcherImpl' has not returned when the virtual method was called
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:21:24: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:23:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
void cancel() {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:31:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
void fetch(const ::envoy::api::v2::core::HttpUri& uri, JwksFetcher::JwksReceiver& receiver) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:47:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
void onSuccess(Http::MessagePtr&& response) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/http/common/jwks_fetcher.cc:77:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
void onFailure(Http::AsyncClient::FailureReason reason) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/rbac/engine_impl.cc:26:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = policies_.begin(); it != policies_.end(); it++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(const auto & policie : policies_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/lua.cc:65:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
LuaThreadLocal& tls = tls_slot_->getTyped<LuaThreadLocal>();
^~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/lua.cc:72:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
LuaThreadLocal& tls = tls_slot_->getTyped<LuaThreadLocal>();
^~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/lua.cc:88:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return CoroutinePtr{new Coroutine({lua_newthread(state), state})};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~
std::make_unique<Coroutine>( )
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/wrappers.cc:43:16: warning: the const qualified variable 'string_value' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const auto string_value = value.string_value();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/lua/wrappers.cc:52:16: warning: the const qualified variable 'list' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const auto list = value.list_value();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc:43:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Ssl::Connection* ssl = const_cast<Ssl::Connection*>(connection.ssl());
^~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc:81:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Envoy::Http::StreamDecoderFilterCallbacks* sdfc =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc:108:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Envoy::Protobuf::Map<Envoy::ProtobufTypes::String, Envoy::ProtobufTypes::String>*
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc:132:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Envoy::Http::StreamDecoderFilterCallbacks* cb =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/check_request_utils.cc:147:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Network::ReadFilterCallbacks* cb = const_cast<Network::ReadFilterCallbacks*>(callbacks);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/dynamic_ot/config.cc:27:21: warning: the const qualified variable 'library' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string library = dynaot_config.library();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:96:22: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
ZipkinJsonFieldNames::get().ANNOTATION_ENDPOINT.c_str());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ZipkinJsonFieldNames::get().ANNOTATION_ENDPOINT
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:136:22: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
ZipkinJsonFieldNames::get().BINARY_ANNOTATION_ENDPOINT.c_str());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ZipkinJsonFieldNames::get().BINARY_ANNOTATION_ENDPOINT
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:169:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = annotations_.begin(); it != annotations_.end(); it++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & annotation : annotations_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:206:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = annotations_.begin(); it != annotations_.end(); it++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & annotation : annotations_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:210:24: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
ZipkinJsonFieldNames::get().SPAN_ANNOTATIONS.c_str());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ZipkinJsonFieldNames::get().SPAN_ANNOTATIONS
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:213:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = binary_annotations_.begin(); it != binary_annotations_.end(); it++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & binary_annotation : binary_annotations_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc:217:24: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
ZipkinJsonFieldNames::get().SPAN_BINARY_ANNOTATIONS.c_str());
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ZipkinJsonFieldNames::get().SPAN_BINARY_ANNOTATIONS
4641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/dynamic_ot/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_buffer.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_context.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_context_extractor.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/util.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_core_types.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_tracer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/lightstep/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/lightstep/lightstep_tracer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/common/ot/opentracing_driver_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/health_checkers/redis/redis.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/health_checkers/redis/config.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/decompressor/zlib_decompressor_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ratelimit/ratelimit_impl.cc
clang-tidy-7 -header-filter=external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-'; // -0.0, Issue #289
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking true branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:44: note: Calling 'Writer::Double'
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:184:72: note: Calling 'Writer::WriteDouble'
bool Double(double d) { Prefix(kNumberType); return EndValue(WriteDouble(d)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:511:5: note: Taking false branch
if (internal::Double(d).IsNanOrInf()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:532:17: note: Calling 'dtoa'
char* end = internal::dtoa(d, buffer, maxDecimalPlaces_);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:219:5: note: Taking true branch
if (d.IsZero()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:220:9: note: Taking true branch
if (d.Sign())
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:14: note: Null pointer value stored to 'buffer'
*buffer++ = '-'; // -0.0, Issue #289
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:23: note: Dereference of null pointer
*buffer++ = '-'; // -0.0, Issue #289
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking true branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:44: note: Calling 'Writer::Double'
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:184:72: note: Calling 'Writer::WriteDouble'
bool Double(double d) { Prefix(kNumberType); return EndValue(WriteDouble(d)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:511:5: note: Taking false branch
if (internal::Double(d).IsNanOrInf()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:532:17: note: Calling 'dtoa'
char* end = internal::dtoa(d, buffer, maxDecimalPlaces_);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:219:5: note: Taking false branch
if (d.IsZero()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:228:9: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:14: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:23: note: Dereference of null pointer
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is >= 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking true branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is >= 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking true branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is < 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking false branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:13: note: Assuming 'value' is >= 10
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:9: note: Taking true branch
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is < 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking false branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:13: note: Assuming 'value' is < 10
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:9: note: Taking false branch
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:10: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:19: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is >= 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking true branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is >= 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking true branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:13: note: Assuming 'value' is >= 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:9: note: Taking true branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:13: note: Assuming 'value' is < 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:9: note: Taking false branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:10: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:19: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is >= 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking false branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:13: note: Assuming 'a' is >= 10
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:9: note: Taking true branch
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is >= 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking false branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:13: note: Assuming 'a' is < 10
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:9: note: Taking false branch
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking true branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:44: note: Calling 'Writer::Int'
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:174:72: note: Calling 'Writer::WriteInt'
bool Int(int i) { Prefix(kNumberType); return EndValue(WriteInt(i)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:480:23: note: Calling 'i32toa'
const char* end = internal::i32toa(i, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:115:9: note: Assuming 'value' is < 0
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:115:5: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:10: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:19: note: Dereference of null pointer
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is >= 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking true branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is >= 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking true branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is < 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking false branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:17: note: Assuming 'v' is >= 10
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:13: note: Taking true branch
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is < 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking false branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:17: note: Assuming 'v' is < 10
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:13: note: Taking false branch
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is >= 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking true branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is >= 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking true branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:17: note: Assuming 'value' is >= 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:13: note: Taking true branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:17: note: Assuming 'value' is < 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:13: note: Taking false branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is >= 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking true branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is >= 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking true branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is >= 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking true branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is >= 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking true branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d3];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is >= 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking true branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d3];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d3];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d3 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is >= 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking true branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d3 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d3 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d4];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is < 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking false branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:13: note: Assuming 'value' is >= 'kTen9'
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:9: note: Taking true branch
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d4];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d4];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d4 + 1];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is < 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking false branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:13: note: Assuming 'value' is < 'kTen9'
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:9: note: Taking false branch
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:210:9: note: Taking true branch
if (value >= kTen8)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d4 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d4 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is < 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking true branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is < 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking true branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is >= 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking false branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:18: note: Assuming 'a' is < 1000
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:14: note: Taking true branch
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is >= 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking false branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:18: note: Assuming 'a' is >= 1000
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:14: note: Taking false branch
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/extensions/tracers/zipkin/util.cc:38:7: note: Assuming the condition is false
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:38:3: note: Taking false branch
if (json_array.size() > 0) {
^
source/extensions/tracers/zipkin/util.cc:47:3: note: Calling 'Util::mergeJsons'
mergeJsons(target, stringified_json_array, field_name);
^
source/extensions/tracers/zipkin/util.cc:30:3: note: Calling 'GenericValue::Accept'
target_doc.Accept(w);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking true branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:44: note: Calling 'Writer::Int64'
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:176:72: note: Calling 'Writer::WriteInt64'
bool Int64(int64_t i64) { Prefix(kNumberType); return EndValue(WriteInt64(i64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:496:23: note: Calling 'i64toa'
const char* end = internal::i64toa(i64, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:293:9: note: Assuming 'value' is < 0
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:293:5: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:10: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:19: note: Dereference of null pointer
*buffer++ = '-';
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_context_extractor.cc:35:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
SpanContextExtractor::~SpanContextExtractor() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_context_extractor.cc:118:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return std::pair<SpanContext, bool>(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/span_context_extractor.cc:222:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return std::pair<SpanContext, bool>(
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc:23:18: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
cs.setEndpoint(std::move(ep));
^~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc:51:27: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
span_ptr->addAnnotation(std::move(cs));
^~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc:103:26: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
annotation.setEndpoint(std::move(ep));
^~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc:105:27: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
span_ptr->addAnnotation(std::move(annotation));
^~~~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/tracer.cc:128:27: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
reporter_->reportSpan(std::move(span));
^~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/ext_authz_http_impl.cc:43:5: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& cluster_name, Upstream::ClusterManager& cluster_manager,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/filters/common/ext_authz/ext_authz_http_impl.cc:44:63: warning: pass by value and use std::move [modernize-pass-by-value]
const absl::optional<std::chrono::milliseconds>& timeout, const std::string& path_prefix,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:47:12: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"^mongo(?=\\.).*?\\.collection(?=\\.).*?\\.callsite\\.((.*?)\\.).*?query.\\w+?$",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^mongo(?=\.).*?\.collection(?=\.).*?\.callsite\.((.*?)\.).*?query.\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:52:26: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(DYNAMO_TABLE, "^http(?=\\.).*?\\.dynamodb.(?:table|error)\\.((.*?)\\.)", ".dynamodb.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^http(?=\.).*?\.dynamodb.(?:table|error)\.((.*?)\.))"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:55:30: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(MONGO_COLLECTION, "^mongo(?=\\.).*?\\.collection\\.((.*?)\\.).*?query.\\w+?$",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^mongo(?=\.).*?\.collection\.((.*?)\.).*?query.\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:59:23: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(MONGO_CMD, "^mongo(?=\\.).*?\\.cmd\\.((.*?)\\.)\\w+?$", ".cmd.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^mongo(?=\.).*?\.cmd\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:62:32: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(GRPC_BRIDGE_METHOD, "^cluster(?=\\.).*?\\.grpc(?=\\.).*\\.((.*?)\\.)\\w+?$", ".grpc.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^cluster(?=\.).*?\.grpc(?=\.).*\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:65:29: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(HTTP_USER_AGENT, "^http(?=\\.).*?\\.user_agent\\.((.*?)\\.)\\w+?$", ".user_agent.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^http(?=\.).*?\.user_agent\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:68:29: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(VIRTUAL_CLUSTER, "^vhost(?=\\.).*?\\.vcluster\\.((.*?)\\.)\\w+?$", ".vcluster.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^vhost(?=\.).*?\.vcluster\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:71:38: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(FAULT_DOWNSTREAM_CLUSTER, "^http(?=\\.).*?\\.fault\\.((.*?)\\.)\\w+?$", ".fault.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^http(?=\.).*?\.fault\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:74:24: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(SSL_CIPHER, "^listener(?=\\.).*?\\.ssl\\.cipher(\\.(.*?))$");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^listener(?=\.).*?\.ssl\.cipher(\.(.*?))$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:77:30: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(SSL_CIPHER_SUITE, "^cluster(?=\\.).*?\\.ssl\\.ciphers(\\.(.*?))$", ".ssl.ciphers.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^cluster(?=\.).*?\.ssl\.ciphers(\.(.*?))$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:80:33: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(GRPC_BRIDGE_SERVICE, "^cluster(?=\\.).*?\\.grpc\\.((.*?)\\.)", ".grpc.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^cluster(?=\.).*?\.grpc\.((.*?)\.))"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:83:24: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(TCP_PREFIX, "^tcp\\.((.*?)\\.)\\w+?$");
^~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^tcp\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:86:30: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(CLIENTSSL_PREFIX, "^auth\\.clientssl\\.((.*?)\\.)\\w+?$");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^auth\.clientssl\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:89:30: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(RATELIMIT_PREFIX, "^ratelimit\\.((.*?)\\.)\\w+?$");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^ratelimit\.((.*?)\.)\w+?$)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:95:38: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
addRegex(HTTP_CONN_MANAGER_PREFIX, "^listener(?=\\.).*?\\.http\\.((.*?)\\.)", ".http.");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^listener(?=\.).*?\.http\.((.*?)\.))"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc:102:12: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"^listener\\.(((?:[_.[:digit:]]*|[_\\[\\]aAbBcCdDeEfF[:digit:]]*))\\.)");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^listener\.(((?:[_.[:digit:]]*|[_\[\]aAbBcCdDeEfF[:digit:]]*))\.))"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/common/ot/opentracing_driver_impl.cc:28:30: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
request_headers_.addCopy(std::move(lowercase_key), value);
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/common/ot/opentracing_driver_impl.cc:41:3: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::function<opentracing::expected<void>(opentracing::string_view,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using OpenTracingCb = std::function<opentracing::expected<void> (opentracing::string_view, opentracing::string_view)>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/common/ot/opentracing_driver_impl.cc:72:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
OpenTracingCb* callback = static_cast<OpenTracingCb*>(context);
^~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/decompressor/zlib_decompressor_impl.cc:49:25: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
chunk_char_ptr_.reset(new unsigned char[chunk_size_]);
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<unsigned char[]>chunk_size_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/metadata.cc:16:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto p : path) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/zipkin/zipkin_tracer_impl.cc:124:28: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& collector_endpoint)
^~~~~~~~~~~~~~~~~~
std::string
^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/cds_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/datasource.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/metadata.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/well_known_names.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/tls_context_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/lds_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/filter_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/address_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/grpc_mux_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/base_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/bootstrap_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/protocol_json.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/eds.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/maglev_lb.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/lightstep/lightstep_tracer_impl.cc:112:5: warning: pass by value and use std::move [modernize-pass-by-value]
const std::shared_ptr<lightstep::LightStepTracer>& tracer, LightStepDriver& driver,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::shared_ptr<lightstep::LightStepTracer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/lightstep/lightstep_tracer_impl.cc:165:34: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
tls_options.metrics_observer.reset(new LightStepMetricsObserver{*this});
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<LightStepMetricsObserver>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/extensions/tracers/lightstep/lightstep_tracer_impl.cc:166:29: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
tls_options.transporter.reset(new LightStepTransporter{*this});
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<LightStepTransporter>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/lds_json.cc:45:9: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"{\"deprecated_v1\": true, \"value\": " + json_filter->getObject("config")->asJsonString() +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"({"deprecated_v1": true, "value": )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/bootstrap_json.cc:73:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_listener : json_config.getObjectArray("listeners")) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:59:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_action : actions) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:123:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_virtual_host : json_route_config.getObjectArray("virtual_hosts", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:133:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto header_value :
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:144:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto header_value : json_route_config.getObjectArray("request_headers_to_add", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:165:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_route : json_virtual_host.getObjectArray("routes", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:175:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_virtual_cluster :
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:181:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_rate_limit : json_virtual_host.getObjectArray("rate_limits", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:186:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto header_value : json_virtual_host.getObjectArray("request_headers_to_add", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:232:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_header_matcher : json_route.getObjectArray("headers", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:237:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_query_parameter_matcher :
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:318:21: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto header_value : json_route.getObjectArray("request_headers_to_add", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/rds_json.cc:323:21: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_rate_limit : json_route.getObjectArray("rate_limits", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/grpc_mux_impl.cc:49:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto type_url : subscriptions_) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/grpc_mux_impl.cc:215:17: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto watched_resource_name : watch->resources_) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/thread_aware_lb_impl.cc:26:44: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
(*per_priority_state_vector)[priority].reset(new PerPriorityState);
~^~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<PerPriorityState>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/maglev_lb.cc:58:5: warning: use range-based for loop instead [modernize-loop-convert]
for (uint64_t i = 0; i < table_build_entries.size(); i++) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & entry : table_build_entries)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/filter_json.cc:164:9: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"{\"deprecated_v1\": true, \"value\": " + json_filter->getObject("config")->asJsonString() +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"({"deprecated_v1": true, "value": )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/filter_json.cc:294:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto json_header_matcher : json_config.getObjectArray("headers", true)) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/config/filter_json.cc:301:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto json_downstream_node : json_config.getStringArray("downstream_nodes", true)) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cds_api_impl.cc:65:23: warning: the const qualified variable 'cluster_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string cluster_name = cluster.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cds_api_impl.cc:72:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto cluster : clusters_to_remove) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/sds_subscription.cc:40:17: warning: redundant string initialization [readability-redundant-string-init]
std::string zone = "";
^~~~~~~~~~
zone
641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_checker_base_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/original_dst_cluster.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cds_api_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/sds_subscription.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_checker_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/thread_aware_lb_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cds_subscription.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_stats_reporter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_balancer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_discovery_service.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/host_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/ring_hash_lb.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/logical_dns_cluster.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stream_info/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de2464160/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:133:53: warning: pass by value and use std::move [modernize-pass-by-value]
TimeSource& time_source, EventLoggerSharedPtr event_logger)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:137:21: warning: parameter 'event_logger' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
event_logger_(event_logger), success_rate_average_(-1), success_rate_ejection_threshold_(-1) {
^~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:141:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto host : host_monitors_) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:155:75: warning: parameter 'event_logger' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
new DetectorImpl(cluster, config, dispatcher, runtime, time_source, event_logger));
^~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:186:49: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::addHostMonitor(HostSharedPtr host) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:198:54: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::checkHostForUneject(HostSharedPtr host, DetectorHostMonitorImpl* monitor,
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:256:44: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::ejectHost(HostSharedPtr host, EjectionType type) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:293:67: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::notifyMainThreadConsecutiveError(HostSharedPtr host, EjectionType type) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:314:36: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
notifyMainThreadConsecutiveError(host, EjectionType::Consecutive5xx);
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:318:36: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
notifyMainThreadConsecutiveError(host, EjectionType::ConsecutiveGatewayFailure);
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:321:59: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::onConsecutiveErrorWorker(HostSharedPtr host, EjectionType type) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:453:47: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void DetectorImpl::runCallbacks(HostSharedPtr host) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:465:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"time\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~
R"("time": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:466:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"secs_since_last_action\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("secs_since_last_action": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:467:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"cluster\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~
R"("cluster": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:468:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"upstream_url\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("upstream_url": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:469:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"action\": \"eject\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~
R"("action": "eject", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:470:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"type\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~
R"("type": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:472:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"enforced\": \"{}\"" +
^~~~~~~~~~~~~~~~~~~~~~
R"("enforced": "{}")"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:477:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"time\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~
R"("time": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:478:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"secs_since_last_action\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("secs_since_last_action": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:479:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"cluster\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~
R"("cluster": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:480:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"upstream_url\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("upstream_url": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:481:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"action\": \"eject\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~
R"("action": "eject", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:482:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"type\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~
R"("type": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:484:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"enforced\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~
R"("enforced": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:485:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"host_success_rate\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("host_success_rate": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:486:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"cluster_average_success_rate\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("cluster_average_success_rate": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:487:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"cluster_success_rate_ejection_threshold\": \"{}\"" +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("cluster_success_rate_ejection_threshold": "{}")"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:518:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"time\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~
R"("time": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:519:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"secs_since_last_action\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("secs_since_last_action": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:520:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"cluster\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~
R"("cluster": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:521:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"upstream_url\": \"{}\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("upstream_url": "{}", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:522:5: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"\"action\": \"uneject\", " +
^~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("action": "uneject", )"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/outlier_detection_impl.cc:571:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return absl::optional<double>(backup_success_rate_bucket_->success_request_counter_ * 100.0 /
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_checker_base_impl.cc:135:56: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void HealthCheckerImplBase::runCallbacks(HostSharedPtr host, HealthTransition changed_state) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_checker_base_impl.cc:186:50: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
HealthCheckerImplBase& parent, HostSharedPtr host)
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:23:5: warning: pass by value and use std::move [modernize-pass-by-value]
const absl::optional<envoy::api::v2::Cluster::RingHashLbConfig>& lb_ring_hash_config,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::optional<envoy::api::v2::Cluster::RingHashLbConfig>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:24:5: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::api::v2::Cluster::CommonLbConfig& common_config)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::api::v2::Cluster::CommonLbConfig
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:202:87: warning: the parameter 'new_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void(LbSubsetEntryPtr, HostPredicate, const SubsetMetadata&, bool)> new_cb) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:326:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto key : subset_keys) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:405:78: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void(LbSubsetEntryPtr)> cb) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:418:60: warning: pass by value and use std::move [modernize-pass-by-value]
HostPredicate predicate,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:420:7: warning: initializer for base class 'Envoy::Upstream::PrioritySetImpl' is redundant [readability-redundant-member-init]
: PrioritySetImpl(), original_priority_set_(subset_lb.original_priority_set_),
^~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:421:18: warning: parameter 'predicate' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
predicate_(predicate), locality_weight_aware_(locality_weight_aware) {
^~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:433:9: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new LeastRequestLoadBalancer(*this, subset_lb.original_local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<LeastRequestLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:439:9: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new RandomLoadBalancer(*this, subset_lb.original_local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RandomLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:445:9: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new RoundRobinLoadBalancer(*this, subset_lb.original_local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RoundRobinLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:454:22: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_aware_lb_.reset(
~^~~~~~
= std::make_unique<RingHashLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:465:22: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_aware_lb_.reset(new MaglevLoadBalancer(*this, subset_lb.stats_, subset_lb.runtime_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<MaglevLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:483:82: warning: the parameter 'predicate' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<bool(const Host&)> predicate) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:487:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto host : hosts_added) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:495:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto host : hosts_removed) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/subset_lb.cc:507:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto host : original_host_set_.hosts()) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/health_checker_impl.cc:193:12: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
return service_cluster_healthchecked.find(parent_.service_name_.value()) == 0;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(service_cluster_healthchecked, parent_.service_name_.value())
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/libevent.cc:3:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_stats_reporter.cc:63:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto host : hosts) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_stats_reporter.cc:93:7: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
if (message_.get()) {
^~~~~~~~~~~~~~~
message_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_stats_reporter.cc:151:17: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto host : host_set->hosts()) {
~~~~ ^
const &
7fe25c5d5d5ad68d05f/execroot/envoy/source/common/stream_info/filter_state_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/profiler/profiler.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/html/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/libevent.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/dispatched_thread.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/event_impl_base.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/real_time_system.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/timer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/dispatcher_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/file_event_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/signal_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/secret_provider_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/sds_api.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/secret_manager_impl.csource/common/upstream/load_balancer_impl.cc:254:30: warning: The left operand of '>=' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:207:11: note: Calling 'ZoneAwareLoadBalancerBase::regenerateLocalityRoutingStructures'
regenerateLocalityRoutingStructures();
^
source/common/upstream/load_balancer_impl.cc:229:3: note: Taking false branch
if (earlyExitNonLocalityRouting()) {
^
source/common/upstream/load_balancer_impl.cc:250:3: note: Calling 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
calculateLocalityPercentage(host_set.healthyHostsPerLocality(), upstream_percentage);
^
source/common/upstream/load_balancer_impl.cc:250:3: note: Returning from 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
source/common/upstream/load_balancer_impl.cc:254:30: note: The left operand of '>=' is a garbage value
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:254:30: warning: The right operand of '>=' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:207:11: note: Calling 'ZoneAwareLoadBalancerBase::regenerateLocalityRoutingStructures'
regenerateLocalityRoutingStructures();
^
source/common/upstream/load_balancer_impl.cc:229:3: note: Taking false branch
if (earlyExitNonLocalityRouting()) {
^
source/common/upstream/load_balancer_impl.cc:248:3: note: Calling 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
calculateLocalityPercentage(localHostSet().healthyHostsPerLocality(), local_percentage);
^
source/common/upstream/load_balancer_impl.cc:248:3: note: Returning from 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
source/common/upstream/load_balancer_impl.cc:254:30: note: The right operand of '>=' is a garbage value
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:288:32: warning: The right operand of '>' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
if (upstream_percentage[i] > local_percentage[i]) {
^
source/common/upstream/load_balancer_impl.cc:207:11: note: Calling 'ZoneAwareLoadBalancerBase::regenerateLocalityRoutingStructures'
regenerateLocalityRoutingStructures();
^
source/common/upstream/load_balancer_impl.cc:229:3: note: Taking false branch
if (earlyExitNonLocalityRouting()) {
^
source/common/upstream/load_balancer_impl.cc:248:3: note: Calling 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
calculateLocalityPercentage(localHostSet().healthyHostsPerLocality(), local_percentage);
^
source/common/upstream/load_balancer_impl.cc:382:16: note: Assuming 'total_hosts' is > 0
ret[i++] = total_hosts > 0 ? 10000ULL * locality_hosts.size() / total_hosts : 0;
^
source/common/upstream/load_balancer_impl.cc:382:16: note: '?' condition is true
source/common/upstream/load_balancer_impl.cc:248:3: note: Returning from 'ZoneAwareLoadBalancerBase::calculateLocalityPercentage'
calculateLocalityPercentage(localHostSet().healthyHostsPerLocality(), local_percentage);
^
source/common/upstream/load_balancer_impl.cc:254:7: note: Assuming the condition is false
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:254:3: note: Taking false branch
if (upstream_percentage[0] >= local_percentage[0]) {
^
source/common/upstream/load_balancer_impl.cc:286:22: note: Assuming 'i' is < 'num_localities'
for (size_t i = 1; i < num_localities; ++i) {
^
source/common/upstream/load_balancer_impl.cc:286:3: note: Loop condition is true. Entering loop body
for (size_t i = 1; i < num_localities; ++i) {
^
source/common/upstream/load_balancer_impl.cc:288:32: note: The right operand of '>' is a garbage value
if (upstream_percentage[i] > local_percentage[i]) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/load_balancer_impl.cc:303:35: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
per_priority_state_.push_back(PerPriorityStatePtr{new PerPriorityState});
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/timer_impl.cc:12:51: warning: pass by value and use std::move [modernize-pass-by-value]
TimerImpl::TimerImpl(Libevent::BasePtr& libevent, TimerCb cb) : cb_(cb) {
^ ~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/timer_impl.cc:12:69: warning: parameter 'cb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
TimerImpl::TimerImpl(Libevent::BasePtr& libevent, TimerCb cb) : cb_(cb) {
^~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/logical_dns_cluster.cc:22:5: warning: pass by value and use std::move [modernize-pass-by-value]
Network::DnsResolverSharedPtr dns_resolver, ThreadLocal::SlotAllocator& tls,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/logical_dns_cluster.cc:26:21: warning: parameter 'dns_resolver' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
dns_resolver_(dns_resolver),
^~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/logical_dns_cluster.cc:132:15: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PerThreadCurrentHostData& data = tls_->getTyped<PerThreadCurrentHostData>();
^~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/logical_dns_cluster.cc:146:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PerThreadCurrentHostData& data = parent_.tls_->getTyped<PerThreadCurrentHostData>();
^~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/dispatched_thread.cc:17:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_.reset(new Thread::Thread([this, &guard_dog]() -> void { threadRoutine(guard_dog); }));
~^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/signal_impl.cc:10:78: warning: pass by value and use std::move [modernize-pass-by-value]
SignalEventImpl::SignalEventImpl(DispatcherImpl& dispatcher, int signal_num, SignalCb cb)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/signal_impl.cc:11:11: warning: parameter 'cb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: cb_(cb) {
^~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_impl.cc:32:5: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::config::filter::accesslog::v2::ComparisonFilter& config, Runtime::Loader& runtime)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::config::filter::accesslog::v2::ComparisonFilter
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_impl.cc:175:16: warning: use emplace_back instead of push_back [modernize-use-emplace]
header_data_.push_back(Http::HeaderUtility::HeaderData(config.header()));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:200:11: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
if (token.find("REQ(") == 0) {
^~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(token, "REQ(")
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:208:18: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
} else if (token.find("RESP(") == 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(token, "RESP(")
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:216:18: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
} else if (token.find("TRAILER(") == 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(token, "TRAILER(")
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:224:18: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
} else if (token.find(DYNAMIC_META_TOKEN) == 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(token, DYNAMIC_META_TOKEN)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:233:18: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
} else if (token.find("START_TIME") == 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(token, "START_TIME")
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:364:44: warning: pass by value and use std::move [modernize-pass-by-value]
PlainStringFormatter::PlainStringFormatter(const std::string& str) : str_(str) {}
^~~~~~~~~~~~~~~~~~ ~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:432:38: warning: pass by value and use std::move [modernize-pass-by-value]
MetadataFormatter::MetadataFormatter(const std::string& filter_namespace,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/access_log/access_log_formatter.cc:433:38: warning: pass by value and use std::move [modernize-pass-by-value]
const std::vector<std::string>& path,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::vector<std::string>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/file_event_impl.cc:13:66: warning: pass by value and use std::move [modernize-pass-by-value]
FileEventImpl::FileEventImpl(DispatcherImpl& dispatcher, int fd, FileReadyCb cb,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/file_event_impl.cc:15:11: warning: parameter 'cb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: cb_(cb), base_(&dispatcher.base()), fd_(fd), trigger_(trigger) {
^~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/file_event_impl.cc:45:18: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
FileEventImpl* event = static_cast<FileEventImpl*>(arg);
^~~~~~~~~~~~~~
auto
source/common/event/dispatcher_impl.cc:35:30: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
deferred_delete_timer_(createTimer([this]() -> void { clearDeferredDeleteList(); })),
^
source/common/event/dispatcher_impl.cc:35:30: note: This constructor of an object of type 'DispatcherImpl' has not returned when the virtual method was called
source/common/event/dispatcher_impl.cc:35:30: note: Call to virtual function during construction
source/common/event/dispatcher_impl.cc:36:19: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
post_timer_(createTimer([this]() -> void { runPostCallbacks(); })),
^
source/common/event/dispatcher_impl.cc:36:19: note: This constructor of an object of type 'DispatcherImpl' has not returned when the virtual method was called
source/common/event/dispatcher_impl.cc:36:19: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/event/dispatcher_impl.cc:41:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
DispatcherImpl::~DispatcherImpl() {}
^ ~~
= default;
source/common/upstream/health_discovery_service.cc:167:51: warning: 'message' used after it was moved [bugprone-use-after-move]
server_response_ms_ = PROTOBUF_GET_MS_REQUIRED(*message, interval);
^
source/common/upstream/health_discovery_service.cc:164:3: note: move occurred here
processMessage(std::move(message));
^
source/common/upstream/health_discovery_service.cc:205:3: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
initialize([] {});
^
source/common/upstream/health_discovery_service.cc:205:3: note: This constructor of an object of type 'HdsCluster' has not returned when the virtual method was called
source/common/upstream/health_discovery_service.cc:205:3: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:116:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
const PerConnectionCluster& per_connection_cluster =
^~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:165:32: warning: the parameter 'config' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Filter::Filter(ConfigSharedPtr config, Upstream::ClusterManager& cluster_manager,
~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:173:3: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
getStreamInfo().onRequestComplete();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:173:3: note: This destructor of an object of type '~Filter' has not returned when the virtual method was called
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:173:3: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:176:48: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
access_log->log(nullptr, nullptr, nullptr, getStreamInfo());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:176:48: note: This destructor of an object of type '~Filter' has not returned when the virtual method was called
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:176:48: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:457:39: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
std::move(upstream_callbacks_), std::move(idle_timer_),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:597:48: warning: pass by value and use std::move [modernize-pass-by-value]
Drainer::Drainer(UpstreamDrainManager& parent, const Config::SharedConfigSharedPtr& config,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Config::SharedConfigSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:598:18: warning: pass by value and use std::move [modernize-pass-by-value]
const std::shared_ptr<Filter::UpstreamCallbacks>& callbacks,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::shared_ptr<Filter::UpstreamCallbacks>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp_proxy/tcp_proxy.cc:600:18: warning: pass by value and use std::move [modernize-pass-by-value]
const Upstream::HostDescriptionConstSharedPtr& upstream_host)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Upstream::HostDescriptionConstSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/metadatamatchcriteria_impl.cc:23:19: warning: the loop variable's type is not a reference type; this creates a copy in each iteration; consider making this a reference [performance-for-range-copy]
for (const auto it : matches.fields()) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/sds_api.cc:17:16: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::api::v2::core::ConfigSource& sds_config,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::api::v2::core::ConfigSource
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/sds_api.cc:18:16: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& sds_config_name, std::function<void()> destructor_cb)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/secret/sds_api.cc:21:34: warning: parameter 'destructor_cb' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
secret_hash_(0), clean_up_(destructor_cb) {
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/retry_state_impl.cc:202:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Http::Code code = static_cast<Http::Code>(Http::Utility::getResponseStatus(response_headers));
^~~~~~~~~~
auto
c
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/retry_state_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/shadow_writer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/metadatamatchcriteria_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/header_parser.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/header_formatter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/rds_subscription.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router_ratelimit.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/rds_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/compressor/zlib_compressor_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/memory/stats.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tracing/http_tracer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/filesystem_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/inotify/watcher_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/maste/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/header_parser.cc:3:10: warning: inclusion of deprecated C++ header 'ctype.h'; consider using 'cctype' instead [modernize-deprecated-headers]
#include <ctype.h>
^~~~~~~~~
<cctype>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_utility.cc:76:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return absl::optional<Http::Code>();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_utility.cc:85:21: warning: the const qualified variable 'filename' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string filename = body.filename();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router_ratelimit.cc:71:21: warning: use emplace_back instead of push_back [modernize-use-emplace]
action_headers_.push_back(header_matcher);
^~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/compressor/zlib_compressor_impl.cc:93:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
chunk_char_ptr_.reset(new unsigned char[chunk_size_]);
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<unsigned char[]>chunk_size_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:161:71: warning: the parameter 'callback' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void ClusterManagerInitHelper::setInitializedCb(std::function<void()> callback) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:213:14: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ads_mux_.reset(new Config::GrpcMuxImpl(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Config::GrpcMuxImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:223:14: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
ads_mux_.reset(new Config::NullGrpcMuxImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Config::NullGrpcMuxImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:240:42: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
const ClusterInfoMap loaded_clusters = clusters();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1174:32: note: Calling constructor for 'ClusterManagerImpl'
return ClusterManagerPtr{new ClusterManagerImpl(bootstrap, *this, stats, tls, runtime, random,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:187:3: note: Taking false branch
if (cm_config.has_outlier_detection()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:195:3: note: Taking false branch
if (bootstrap.dynamic_resources().deprecated_v1().has_sds_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:212:3: note: Taking false branch
if (bootstrap.dynamic_resources().has_ads_config()) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:240:42: note: This constructor of an object of type 'ClusterManagerImpl' has not returned when the virtual method was called
const ClusterInfoMap loaded_clusters = clusters();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:240:42: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:303:26: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
load_stats_reporter_.reset(
~^~~~~~
= std::make_unique<LoadStatsReporter>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:382:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
updates_by_prio.reset(new PendingUpdatesByPriorityMap());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<PendingUpdatesByPriorityMap>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:388:13: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
updates.reset(new PendingUpdates());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<PendingUpdates>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:458:21: warning: the const qualified variable 'cluster_name' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string cluster_name = cluster.name();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:526:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:555:7: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager =
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:642:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:655:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:669:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:709:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:736:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:747:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& cluster_manager = tls_->getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:801:56: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_local_clusters_[local_cluster_name.value()].reset(new ClusterEntry(
~^~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<ClusterEntry>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:817:43: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_local_clusters_[cluster.first].reset(new ClusterEntry(
~^~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<ClusterEntry>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:860:19: warning: the parameter 'old_host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
HostSharedPtr old_host, ConnPoolsContainer& container) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:894:19: warning: the parameter 'old_host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
HostSharedPtr old_host, TcpConnPoolsContainer& container) {
~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:948:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& config = tls.getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:974:3: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ThreadLocalClusterManagerImpl& config = tls.getTyped<ThreadLocalClusterManagerImpl>();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1017:70: warning: the parameter 'cluster' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
ThreadLocalClusterManagerImpl& parent, ClusterInfoConstSharedPtr cluster,
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1018:5: warning: pass by value and use std::move [modernize-pass-by-value]
const LoadBalancerFactorySharedPtr& lb_factory)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LoadBalancerFactorySharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1029:9: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new SubsetLoadBalancer(cluster->lbType(), priority_set_, parent_.local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<SubsetLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1037:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new LeastRequestLoadBalancer(priority_set_, parent_.local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<LeastRequestLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1044:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new RandomLoadBalancer(priority_set_, parent_.local_priority_set_, cluster->stats(),
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RandomLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1051:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new RoundRobinLoadBalancer(priority_set_, parent_.local_priority_set_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RoundRobinLoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/cluster_manager_impl.cc:1064:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
lb_.reset(new OriginalDstCluster::LoadBalancer(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<OriginalDstCluster::LoadBalancer>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/filesystem_impl.cc:96:20: warning: pass by value and use std::move [modernize-pass-by-value]
FileImpl::FileImpl(const std::string& path, Event::Dispatcher& dispatcher,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/filesystem_impl.cc:111:53: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
Api::SysCallIntResult result = os_sys_calls_.open(path_.c_str(), O_RDWR | O_APPEND | O_CREAT,
^~~~~~~~~~~~~~
path_
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/filesystem_impl.cc:252:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
flush_thread_.reset(new Thread::Thread([this]() -> void { flushThreadFunc(); }));
~^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/filesystem/inotify/watcher_impl.cc:65:7: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
inotify_event* file_event = reinterpret_cast<inotify_event*>(&buffer[index]);
^~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc:54:25: warning: use emplace_back instead of push_back [modernize-use-emplace]
registered_threads_.push_back(dispatcher);
^~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc:82:50: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void InstanceImpl::runOnAllThreads(Event::PostCb cb) {
~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc:94:50: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void InstanceImpl::runOnAllThreads(Event::PostCb cb, Event::PostCb all_threads_complete_cb) {
~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc:94:68: warning: the parameter 'all_threads_complete_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void InstanceImpl::runOnAllThreads(Event::PostCb cb, Event::PostCb all_threads_complete_cb) {
~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc:131:37: warning: parameter 'object' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
thread_local_data_.data_[index] = object;
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/codec.cc:14:10: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
Encoder::Encoder() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/codec.cc:70:24: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
frame_.data_.reset(new Buffer::OwnedImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:87:66: warning: the const qualified parameter 'bind_config' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
const envoy::api::v2::core::BindConfig bind_config) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:180:7: warning: parameter 'address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
address, cluster.sourceAddress(), cluster.transportSocketFactory().createTransportSocket(),
^~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:444:32: warning: parameter 'dns_resolver' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
auto selected_dns_resolver = dns_resolver;
^~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:461:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
new_cluster.reset(new StaticClusterImpl(cluster, runtime, factory_context,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<StaticClusterImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:465:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
new_cluster.reset(new StrictDnsClusterImpl(cluster, runtime, selected_dns_resolver,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<StrictDnsClusterImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:470:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
new_cluster.reset(new LogicalDnsCluster(cluster, runtime, selected_dns_resolver, tls,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<LogicalDnsCluster>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:483:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
new_cluster.reset(new OriginalDstCluster(cluster, runtime, factory_context,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<OriginalDstCluster>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:492:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
new_cluster.reset(new EdsClusterImpl(cluster, runtime, factory_context, std::move(stats_scope),
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<EdsClusterImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:510:51: warning: parameter 'outlier_event_logger' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
*new_cluster, cluster, dispatcher, runtime, outlier_event_logger));
^~~~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:737:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return ResourceManagerImplPtr{new ResourceManagerImpl(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::make_unique<ResourceManagerImpl>(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:753:37: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
priority_state_[priority].first.reset(new HostVector());
~^~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<HostVector>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:767:46: warning: parameter 'address' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
new HostImpl(parent_.info(), hostname, address, lb_endpoint.metadata(),
^~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:1092:5: warning: pass by value and use std::move [modernize-pass-by-value]
Network::DnsResolverSharedPtr dns_resolver,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:1097:63: warning: parameter 'dns_resolver' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
local_info_(factory_context.localInfo()), dns_resolver_(dns_resolver),
^~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:1163:5: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::api::v2::endpoint::LocalityLbEndpoints& locality_lb_endpoint,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::api::v2::endpoint::LocalityLbEndpoints
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/upstream/upstream_impl.cc:1164:5: warning: pass by value and use std::move [modernize-pass-by-value]
const envoy::api::v2::endpoint::LbEndpoint& lb_endpoint)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
envoy::api::v2::endpoint::LbEndpoint
r/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/protobuf/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/thread_local/thread_local_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/buffer/watermark_buffer.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/buffer/buffer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/buffer/zero_copy_input_stream_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/runtime/runtime_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/runtime/uuid_util.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/config_schemas.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/async_client_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/status.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/codec.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_grpc_creds_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/async_client_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/common.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/socket_option_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizasource/common/protobuf/utility.cc:20:10: warning: narrowing conversion from 'double' to 'uint64_t' (aka 'unsigned long') [bugprone-narrowing-conversions]
return max_value * (percent / 100.0);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc:10:59: warning: pass by value and use std::move [modernize-pass-by-value]
ConnPoolImpl::ConnPoolImpl(Event::Dispatcher& dispatcher, Upstream::HostConstSharedPtr host,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc:12:28: warning: pass by value and use std::move [modernize-pass-by-value]
const Network::ConnectionSocket::OptionsSharedPtr& options)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Network::ConnectionSocket::OptionsSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc:13:38: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: dispatcher_(dispatcher), host_(host), priority_(priority), socket_options_(options),
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc:354:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
parent_.conn_connect_ms_.reset(new Stats::Timespan(
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/tcp/conn_pool.cc:374:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
conn_length_.reset(new Stats::Timespan(parent_.host_->cluster().stats().upstream_cx_length_ms_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/rds_impl.cc:60:5: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& manager_identifier, Server::Configuration::FactoryContext& factory_context,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:63:14: warning: the const qualified variable 'retry_priority' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const auto retry_priority = retry_policy.retry_priority();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:164:20: warning: pass by value and use std::move [modernize-pass-by-value]
CookieHashMethod(const std::string& key, const std::string& path,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:164:44: warning: pass by value and use std::move [modernize-pass-by-value]
CookieHashMethod(const std::string& key, const std::string& path,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:329:32: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
metadata_match_criteria_.reset(new MetadataMatchCriteriaImpl(filter_it->second));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<MetadataMatchCriteriaImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:359:21: warning: use emplace_back instead of push_back [modernize-use-emplace]
config_headers_.push_back(header_map);
^~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:363:30: warning: use emplace_back instead of push_back [modernize-use-emplace]
config_query_parameters_.push_back(query_parameter);
^~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:367:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
hash_policy_.reset(new HashPolicyImpl(route.route().hash_policy()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<HashPolicyImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:377:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cors_policy_.reset(new CorsPolicyImpl(route.route().cors()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<CorsPolicyImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:553:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto it : filter_metadata->second.fields()) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:647:57: warning: the const qualified parameter 'runtime_key' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
const RouteEntryImplBase* parent, const std::string runtime_key,
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:666:42: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cluster_metadata_match_criteria_.reset(new MetadataMatchCriteriaImpl(filter_it->second));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<MetadataMatchCriteriaImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:739:36: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
regex_(RegexUtil::parseRegex(route.match().regex().c_str())),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
route.match().regex()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:820:23: warning: use emplace_back instead of push_back [modernize-use-emplace]
virtual_clusters_.push_back(VirtualClusterEntry(virtual_cluster));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:824:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cors_policy_.reset(new CorsPolicyImpl(virtual_host.cors()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<CorsPolicyImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:834:21: warning: the const qualified variable 'pattern' is copy-constructed from a const reference; consider making it a const reference [performance-unnecessary-copy-initialization]
const std::string pattern = virtual_cluster.pattern();
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:973:18: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
route_matcher_.reset(new RouteMatcher(
~^~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<RouteMatcher>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/config_impl.cc:978:28: warning: use emplace_back instead of push_back [modernize-use-emplace]
internal_only_headers_.push_back(Http::LowerCaseString(header));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
source/common/grpc/common.cc:105:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
return absl::optional<Status::GrpcStatus>(static_cast<Status::GrpcStatus>(grpc_status_code));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/filter_manager_impl.cc:17:51: warning: the parameter 'filter' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void FilterManagerImpl::addFilter(FilterSharedPtr filter) {
~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/filter_manager_impl.cc:22:59: warning: the parameter 'filter' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void FilterManagerImpl::addReadFilter(ReadFilterSharedPtr filter) {
~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/utility.cc:52:63: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
bool Utility::urlIsTcpScheme(const std::string& url) { return url.find(TCP_SCHEME) == 0; }
^~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(url, TCP_SCHEME)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/utility.cc:54:64: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
bool Utility::urlIsUnixScheme(const std::string& url) { return url.find(UNIX_SCHEME) == 0; }
^~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(url, UNIX_SCHEME)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/utility.cc:136:31: warning: 'rfind' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find]
auto pos = ip_address.rfind(":");
^~~~
':'
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/utility.cc:186:13: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const struct sockaddr_storage* addr =
^~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/cidr_range.cc:37:12: warning: use '= default' to define a trivial copy constructor [modernize-use-equals-default]
CidrRange::CidrRange(const CidrRange& other) : address_(other.address_), length_(other.length_) {}
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/cidr_range.cc:39:23: warning: use '= default' to define a trivial copy-assignment operator [modernize-use-equals-default]
CidrRange& CidrRange::operator=(const CidrRange& other) {
^ ~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc:63:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const struct sockaddr_in* sin = reinterpret_cast<const struct sockaddr_in*>(&ss);
^~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc:69:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const struct sockaddr_in6* sin6 = reinterpret_cast<const struct sockaddr_in6*>(&ss);
^~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc:84:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const struct sockaddr_un* sun = reinterpret_cast<const struct sockaddr_un*>(&ss);
^~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc:209:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const Ipv4Instance* rhs_casted = dynamic_cast<const Ipv4Instance*>(&rhs);
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc:274:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
const Ipv6Instance* rhs_casted = dynamic_cast<const Ipv6Instance*>(&rhs);
^~~~~~~~~~~~~
auto
n/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/cidr_range.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/resolver_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/filter_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/socket_option_factory.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/raw_buffer_socket.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/address_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/listener_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/connection_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/addr_family_aware_socket_option_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/listen_socket_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/dns_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/tls_certificate_config_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/ssl_socket.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/comsource/common/grpc/async_client_impl.cc:106:28: warning: 'headers' used after it was moved [bugprone-use-after-move]
onTrailers(std::move(headers));
^
source/common/grpc/async_client_impl.cc:101:52: note: move occurred here
: std::move(headers));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:132:80: warning: the parameter 'upstream_host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
const std::string Filter::upstreamZone(Upstream::HostDescriptionConstSharedPtr upstream_host) {
~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:139:73: warning: the parameter 'upstream_host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Upstream::HostDescriptionConstSharedPtr upstream_host,
~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:196:67: warning: parameter 'upstream_host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
chargeUpstreamCode(response_status_code, fake_response_headers, upstream_host, dropped);
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:319:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
upstream_request_.reset(new UpstreamRequest(*this, *conn_pool));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<UpstreamRequest>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:414:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request->body().reset(new Buffer::OwnedImpl(*callbacks_->decodingBuffer()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:784:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
upstream_request_.reset(new UpstreamRequest(*this, *conn_pool));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<UpstreamRequest>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/router/router.cc:892:30: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
buffered_request_body_.reset(
~^~~~~~
= std::make_unique<Buffer::WatermarkBuffer>
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-'; // -0.0, Issue #289
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking true branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:44: note: Calling 'Writer::Double'
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:184:72: note: Calling 'Writer::WriteDouble'
bool Double(double d) { Prefix(kNumberType); return EndValue(WriteDouble(d)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:511:5: note: Taking false branch
if (internal::Double(d).IsNanOrInf()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:532:17: note: Calling 'dtoa'
char* end = internal::dtoa(d, buffer, maxDecimalPlaces_);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:219:5: note: Taking true branch
if (d.IsZero()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:220:9: note: Taking true branch
if (d.Sign())
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:14: note: Null pointer value stored to 'buffer'
*buffer++ = '-'; // -0.0, Issue #289
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:221:23: note: Dereference of null pointer
*buffer++ = '-'; // -0.0, Issue #289
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking true branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:44: note: Calling 'Writer::Double'
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:184:72: note: Calling 'Writer::WriteDouble'
bool Double(double d) { Prefix(kNumberType); return EndValue(WriteDouble(d)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:511:5: note: Taking false branch
if (internal::Double(d).IsNanOrInf()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:532:17: note: Calling 'dtoa'
char* end = internal::dtoa(d, buffer, maxDecimalPlaces_);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:219:5: note: Taking false branch
if (d.IsZero()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:228:9: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:14: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/dtoa.h:229:23: note: Dereference of null pointer
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is >= 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking true branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:47:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is >= 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking true branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:49:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is < 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking false branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:13: note: Assuming 'value' is >= 10
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:9: note: Taking true branch
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:51:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is < 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking true branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:13: note: Assuming 'value' is < 1000
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:46:9: note: Taking false branch
if (value >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:13: note: Assuming 'value' is < 100
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:48:9: note: Taking false branch
if (value >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:13: note: Assuming 'value' is < 10
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:50:9: note: Taking false branch
if (value >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:10: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:52:19: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is >= 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking true branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:66:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is >= 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking true branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:68:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:13: note: Assuming 'value' is >= 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:9: note: Taking true branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:70:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is < 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking true branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:13: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:65:9: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:13: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:67:9: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:13: note: Assuming 'value' is < 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:69:9: note: Taking false branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:10: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:71:19: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is >= 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking false branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:13: note: Assuming 'a' is >= 10
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:9: note: Taking true branch
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:86:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking true branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:44: note: Calling 'Writer::Uint'
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:175:72: note: Calling 'Writer::WriteUint'
bool Uint(unsigned u) { Prefix(kNumberType); return EndValue(WriteUint(u)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:488:23: note: Calling 'u32toa'
const char* end = internal::u32toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:9: note: Assuming 'value' is >= 10000
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:42:5: note: Taking false branch
if (value < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:14: note: Assuming 'value' is >= 100000000
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:54:10: note: Taking false branch
else if (value < 100000000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:13: note: Assuming 'a' is < 10
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:84:9: note: Taking false branch
if (a >= 10) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:90:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking true branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:44: note: Calling 'Writer::Int'
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:174:72: note: Calling 'Writer::WriteInt'
bool Int(int i) { Prefix(kNumberType); return EndValue(WriteInt(i)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:480:23: note: Calling 'i32toa'
const char* end = internal::i32toa(i, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:115:9: note: Assuming 'value' is < 0
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:115:5: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:10: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:116:19: note: Dereference of null pointer
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is >= 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking true branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:142:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is >= 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking true branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:144:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is < 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking false branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:17: note: Assuming 'v' is >= 10
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:13: note: Taking true branch
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:146:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is < 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking true branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:17: note: Assuming 'v' is < 1000
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:141:13: note: Taking false branch
if (v >= 1000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:17: note: Assuming 'v' is < 100
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:143:13: note: Taking false branch
if (v >= 100)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:17: note: Assuming 'v' is < 10
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:145:13: note: Taking false branch
if (v >= 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:147:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is >= 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking true branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:161:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is >= 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking true branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:163:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:27: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:17: note: Assuming 'value' is >= 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:13: note: Taking true branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:18: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:165:27: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is < 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking true branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:13: note: Assuming 'v' is >= 10000
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:137:9: note: Taking false branch
if (v < 10000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:17: note: Assuming 'value' is < 10000000
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:160:13: note: Taking false branch
if (value >= 10000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:17: note: Assuming 'value' is < 1000000
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:162:13: note: Taking false branch
if (value >= 1000000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:17: note: Assuming 'value' is < 100000
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:164:13: note: Taking false branch
if (value >= 100000)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:166:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is >= 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking true branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:197:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d1 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is >= 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking true branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:199:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d1 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is >= 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking true branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:201:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d2 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is >= 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking true branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:203:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d2 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d3];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is >= 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking true branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d3];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:205:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d3];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d3 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is >= 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking true branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d3 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:207:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d3 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d4];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is < 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking false branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:13: note: Assuming 'value' is >= 'kTen9'
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:9: note: Taking true branch
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d4];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:209:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d4];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[d4 + 1];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is < 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking true branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:13: note: Assuming 'value' is < 'kTen15'
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:196:9: note: Taking false branch
if (value >= kTen15)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:13: note: Assuming 'value' is < 'kTen14'
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:198:9: note: Taking false branch
if (value >= kTen14)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:13: note: Assuming 'value' is < 'kTen13'
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:200:9: note: Taking false branch
if (value >= kTen13)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:13: note: Assuming 'value' is < 'kTen12'
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:202:9: note: Taking false branch
if (value >= kTen12)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:13: note: Assuming 'value' is < 'kTen11'
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:204:9: note: Taking false branch
if (value >= kTen11)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:13: note: Assuming 'value' is < 'kTen10'
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:206:9: note: Taking false branch
if (value >= kTen10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:13: note: Assuming 'value' is < 'kTen9'
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:208:9: note: Taking false branch
if (value >= kTen9)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:210:9: note: Taking true branch
if (value >= kTen8)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[d4 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:211:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[d4 + 1];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is < 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking true branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:227:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is < 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking true branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:230:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is >= 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking false branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:18: note: Assuming 'a' is < 1000
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:14: note: Taking true branch
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:14: note: Null pointer value stored to 'buffer'
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:234:23: note: Dereference of null pointer
*buffer++ = static_cast<char>('0' + static_cast<char>(a / 100));
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:23: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = cDigitsLut[i];
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking false branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1803:44: note: Calling 'Writer::Uint64'
else return handler.Uint64(data_.n.u64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:177:72: note: Calling 'Writer::WriteUint64'
bool Uint64(uint64_t u64) { Prefix(kNumberType); return EndValue(WriteUint64(u64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:504:23: note: Calling 'u64toa'
const char* end = internal::u64toa(u, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:9: note: Assuming 'value' is >= 'kTen8'
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:135:5: note: Taking false branch
if (value < kTen8) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:14: note: Assuming 'value' is >= 'kTen16'
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:174:10: note: Taking false branch
else if (value < kTen16) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:13: note: Assuming 'a' is >= 10
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:226:9: note: Taking false branch
if (a < 10)
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:18: note: Assuming 'a' is >= 100
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:228:14: note: Taking false branch
else if (a < 100) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:18: note: Assuming 'a' is >= 1000
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:233:14: note: Taking false branch
else if (a < 1000) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:14: note: Null pointer value stored to 'buffer'
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:243:23: note: Dereference of null pointer
*buffer++ = cDigitsLut[i];
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:19: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
*buffer++ = '-';
^
source/common/json/json_loader.cc:329:3: note: Calling 'GenericValue::Accept'
asRapidJsonDocument().Accept(writer);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1769:9: note: Control jumps to the 'default' case at line 1797
switch(GetType()) {
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1799:13: note: Taking false branch
if (IsDouble()) return handler.Double(data_.n.d);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1800:18: note: Taking false branch
else if (IsInt()) return handler.Int(data_.n.i.i);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1801:18: note: Taking false branch
else if (IsUint()) return handler.Uint(data_.n.u.u);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:18: note: Taking true branch
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/document.h:1802:44: note: Calling 'Writer::Int64'
else if (IsInt64()) return handler.Int64(data_.n.i64);
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:176:72: note: Calling 'Writer::WriteInt64'
bool Int64(int64_t i64) { Prefix(kNumberType); return EndValue(WriteInt64(i64)); }
^
external/com_github_tencent_rapidjson/include/rapidjson/writer.h:496:23: note: Calling 'i64toa'
const char* end = internal::i64toa(i64, buffer);
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:293:9: note: Assuming 'value' is < 0
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:293:5: note: Taking true branch
if (value < 0) {
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:10: note: Null pointer value stored to 'buffer'
*buffer++ = '-';
^
external/com_github_tencent_rapidjson/include/rapidjson/internal/itoa.h:294:19: note: Dereference of null pointer
*buffer++ = '-';
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc:37:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef std::shared_ptr<Field> FieldSharedPtr;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using FieldSharedPtr = std::shared_ptr<Field>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc:55:12: error: use std::make_shared instead [modernize-make-shared,-warnings-as-errors]
return FieldSharedPtr{new Field(value)};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::make_shared<Field>()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc:58:30: warning: the parameter 'field_ptr' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void append(FieldSharedPtr field_ptr) {
~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc:64:33: warning: parameter 'field_ptr' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
value_.object_value_[key] = field_ptr;
^~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/json/json_loader.cc:667:53: warning: the parameter 'ptr' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
bool ObjectHandler::handleValueEvent(FieldSharedPtr ptr) {
~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/utility.cc:44:25: warning: use emplace_back instead of push_back [modernize-use-emplace]
subject_alt_names.push_back(std::string(dns_name));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/listener_impl.cc:25:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
ListenerImpl* listener = static_cast<ListenerImpl*>(arg);
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/dns_impl.cc:124:19: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
callback_(std::move(address_list));
^~~~~~~~~~~~~~~~~~~~~~~~
source/common/ssl/certificate_validation_context_config_impl.cc:33:40: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
certificateRevocationListPath()));
^
source/common/ssl/certificate_validation_context_config_impl.cc:18:35: note: Assuming the condition is false
.value_or(ca_cert_.empty() ? EMPTY_STRING : INLINE_STRING)),
^
source/common/ssl/certificate_validation_context_config_impl.cc:18:35: note: '?' condition is false
source/common/ssl/certificate_validation_context_config_impl.cc:22:25: note: Assuming the condition is false
.value_or(certificate_revocation_list_.empty() ? EMPTY_STRING : INLINE_STRING)),
^
source/common/ssl/certificate_validation_context_config_impl.cc:22:25: note: '?' condition is false
source/common/ssl/certificate_validation_context_config_impl.cc:30:7: note: Assuming the condition is true
if (ca_cert_.empty()) {
^
source/common/ssl/certificate_validation_context_config_impl.cc:30:3: note: Taking true branch
if (ca_cert_.empty()) {
^
source/common/ssl/certificate_validation_context_config_impl.cc:31:9: note: Assuming the condition is true
if (!certificate_revocation_list_.empty()) {
^
source/common/ssl/certificate_validation_context_config_impl.cc:31:5: note: Taking true branch
if (!certificate_revocation_list_.empty()) {
^
source/common/ssl/certificate_validation_context_config_impl.cc:33:40: note: This constructor of an object of type 'CertificateValidationContextConfigImpl' has not returned when the virtual method was called
certificateRevocationListPath()));
^
source/common/ssl/certificate_validation_context_config_impl.cc:33:40: note: Call to virtual function during construction
source/common/network/connection_impl.cc:56:18: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
RELEASE_ASSERT(fd() != -1, "");
^
source/common/network/connection_impl.cc:600:7: note: Calling constructor for 'ConnectionImpl'
: ConnectionImpl(dispatcher, std::make_unique<ClientSocketImpl>(remote_address),
^
source/common/network/connection_impl.cc:56:18: note: This constructor of an object of type 'ConnectionImpl' has not returned when the virtual method was called
RELEASE_ASSERT(fd() != -1, "");
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:22:11: note: expanded from macro 'RELEASE_ASSERT'
if (!(X)) { \
^
source/common/network/connection_impl.cc:56:18: note: Call to virtual function during construction
RELEASE_ASSERT(fd() != -1, "");
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:22:11: note: expanded from macro 'RELEASE_ASSERT'
if (!(X)) { \
^
source/common/network/connection_impl.cc:65:7: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
fd(), [this](uint32_t events) -> void { onFileEvent(events); }, Event::FileTriggerType::Edge,
^
source/common/network/connection_impl.cc:600:7: note: Calling constructor for 'ConnectionImpl'
: ConnectionImpl(dispatcher, std::make_unique<ClientSocketImpl>(remote_address),
^
source/common/network/connection_impl.cc:58:3: note: Taking true branch
if (!connected) {
^
source/common/network/connection_impl.cc:65:7: note: This constructor of an object of type 'ConnectionImpl' has not returned when the virtual method was called
fd(), [this](uint32_t events) -> void { onFileEvent(events); }, Event::FileTriggerType::Edge,
^
source/common/network/connection_impl.cc:65:7: note: Call to virtual function during construction
source/common/network/connection_impl.cc:72:10: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ASSERT(fd() == -1 && delayed_close_timer_ == nullptr,
^
source/common/network/connection_impl.cc:72:10: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:40:86: note: expanded from macro 'ASSERT'
#define ASSERT(...) _ASSERT_SELECTOR(__VA_ARGS__, _ASSERT_VERBOSE, _ASSERT_ORIGINAL)(__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:33:46: note: expanded from macro '_ASSERT_VERBOSE'
#define _ASSERT_VERBOSE(X, Y) RELEASE_ASSERT(X, Y)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:22:11: note: expanded from macro 'RELEASE_ASSERT'
if (!(X)) { \
^
source/common/network/connection_impl.cc:72:10: note: Call to virtual function during destruction
ASSERT(fd() == -1 && delayed_close_timer_ == nullptr,
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:40:86: note: expanded from macro 'ASSERT'
#define ASSERT(...) _ASSERT_SELECTOR(__VA_ARGS__, _ASSERT_VERBOSE, _ASSERT_ORIGINAL)(__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:33:46: note: expanded from macro '_ASSERT_VERBOSE'
#define _ASSERT_VERBOSE(X, Y) RELEASE_ASSERT(X, Y)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:22:11: note: expanded from macro 'RELEASE_ASSERT'
if (!(X)) { \
^
source/common/network/connection_impl.cc:79:3: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
source/common/network/connection_impl.cc:79:3: note: Call to virtual function during destruction
source/common/network/connection_impl.cc:95:7: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
if (fd() == -1) {
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Call to virtual function during destruction
if (fd() == -1) {
^
source/common/network/connection_impl.cc:100:3: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ENVOY_CONN_LOG(debug, "closing data_to_write={} type={}", *this, data_to_write, enumToInt(type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:55: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:100:3: note: Taking true branch
ENVOY_CONN_LOG(debug, "closing data_to_write={} type={}", *this, data_to_write, enumToInt(type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:3: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:307:49: note: expanded from macro 'ENVOY_LOG_TO_LOGGER'
#define ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, ...) ENVOY_LOG_COMP_AND_LOG(LOGGER, LEVEL, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:294:5: note: expanded from macro 'ENVOY_LOG_COMP_AND_LOG'
if (ENVOY_LOG_COMP_LEVEL(LOGGER, LEVEL)) { \
^
source/common/network/connection_impl.cc:100:3: note: Call to virtual function during destruction
ENVOY_CONN_LOG(debug, "closing data_to_write={} type={}", *this, data_to_write, enumToInt(type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:55: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:307:89: note: expanded from macro 'ENVOY_LOG_TO_LOGGER'
#define ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, ...) ENVOY_LOG_COMP_AND_LOG(LOGGER, LEVEL, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:295:31: note: expanded from macro 'ENVOY_LOG_COMP_AND_LOG'
LOGGER.LEVEL(LOG_PREFIX __VA_ARGS__); \
^
source/common/network/connection_impl.cc:162:7: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
if (fd() == -1) {
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:101:7: note: Assuming 'data_to_write' is not equal to 0
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:101:7: note: Left side of '||' is false
source/common/network/connection_impl.cc:101:66: note: Left side of '||' is true
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:103:5: note: Taking true branch
if (data_to_write > 0) {
^
source/common/network/connection_impl.cc:109:5: note: Calling 'ConnectionImpl::closeSocket'
closeSocket(ConnectionEvent::LocalClose);
^
source/common/network/connection_impl.cc:172:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:172:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:177:3: note: Taking false branch
if (delayed_close_timer_) {
^
source/common/network/connection_impl.cc:193:3: note: Calling 'ConnectionImpl::raiseEvent'
raiseEvent(close_type);
^
source/common/network/connection_impl.cc:335:7: note: Calling 'ConnectionImpl::state'
if (state() == State::Open && event == ConnectionEvent::Connected &&
^
source/common/network/connection_impl.cc:162:7: note: Call to virtual function during destruction
if (fd() == -1) {
^
source/common/network/connection_impl.cc:172:7: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
if (fd() == -1) {
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:101:7: note: Assuming 'data_to_write' is equal to 0
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:101:26: note: Left side of '||' is true
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:103:5: note: Taking false branch
if (data_to_write > 0) {
^
source/common/network/connection_impl.cc:109:5: note: Calling 'ConnectionImpl::closeSocket'
closeSocket(ConnectionEvent::LocalClose);
^
source/common/network/connection_impl.cc:172:7: note: Call to virtual function during destruction
if (fd() == -1) {
^
source/common/network/connection_impl.cc:182:3: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ENVOY_CONN_LOG(debug, "closing socket: {}", *this, static_cast<uint32_t>(close_type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:55: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:101:7: note: Assuming 'data_to_write' is equal to 0
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:101:26: note: Left side of '||' is true
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:103:5: note: Taking false branch
if (data_to_write > 0) {
^
source/common/network/connection_impl.cc:109:5: note: Calling 'ConnectionImpl::closeSocket'
closeSocket(ConnectionEvent::LocalClose);
^
source/common/network/connection_impl.cc:172:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:172:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:177:3: note: Taking false branch
if (delayed_close_timer_) {
^
source/common/network/connection_impl.cc:182:3: note: Taking true branch
ENVOY_CONN_LOG(debug, "closing socket: {}", *this, static_cast<uint32_t>(close_type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:3: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:307:49: note: expanded from macro 'ENVOY_LOG_TO_LOGGER'
#define ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, ...) ENVOY_LOG_COMP_AND_LOG(LOGGER, LEVEL, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:294:5: note: expanded from macro 'ENVOY_LOG_COMP_AND_LOG'
if (ENVOY_LOG_COMP_LEVEL(LOGGER, LEVEL)) { \
^
source/common/network/connection_impl.cc:182:3: note: Call to virtual function during destruction
ENVOY_CONN_LOG(debug, "closing socket: {}", *this, static_cast<uint32_t>(close_type));
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:338:3: note: expanded from macro 'ENVOY_CONN_LOG'
ENVOY_CONN_LOG_TO_LOGGER(ENVOY_LOGGER(), LEVEL, FORMAT, CONNECTION, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:335:55: note: expanded from macro 'ENVOY_CONN_LOG_TO_LOGGER'
ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, "[C{}] " FORMAT, (CONNECTION).id(), ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:307:89: note: expanded from macro 'ENVOY_LOG_TO_LOGGER'
#define ENVOY_LOG_TO_LOGGER(LOGGER, LEVEL, ...) ENVOY_LOG_COMP_AND_LOG(LOGGER, LEVEL, ##__VA_ARGS__)
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/minimal_logger_lib/common/common/logger.h:295:31: note: expanded from macro 'ENVOY_LOG_COMP_AND_LOG'
LOGGER.LEVEL(LOG_PREFIX __VA_ARGS__); \
^
source/common/network/connection_impl.cc:193:3: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
raiseEvent(close_type);
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:101:7: note: Assuming 'data_to_write' is equal to 0
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:101:26: note: Left side of '||' is true
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:103:5: note: Taking false branch
if (data_to_write > 0) {
^
source/common/network/connection_impl.cc:109:5: note: Calling 'ConnectionImpl::closeSocket'
closeSocket(ConnectionEvent::LocalClose);
^
source/common/network/connection_impl.cc:172:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:172:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:177:3: note: Taking false branch
if (delayed_close_timer_) {
^
source/common/network/connection_impl.cc:193:3: note: Call to virtual function during destruction
raiseEvent(close_type);
^
source/common/network/connection_impl.cc:335:7: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
if (state() == State::Open && event == ConnectionEvent::Connected &&
^
source/common/network/connection_impl.cc:79:3: note: This destructor of an object of type '~ConnectionImpl' has not returned when the virtual method was called
close(ConnectionCloseType::NoFlush);
^
source/common/network/connection_impl.cc:79:3: note: Calling 'ConnectionImpl::close'
source/common/network/connection_impl.cc:95:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:95:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:101:7: note: Assuming 'data_to_write' is not equal to 0
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:101:7: note: Left side of '||' is false
source/common/network/connection_impl.cc:101:66: note: Left side of '||' is true
if (data_to_write == 0 || type == ConnectionCloseType::NoFlush ||
^
source/common/network/connection_impl.cc:103:5: note: Taking true branch
if (data_to_write > 0) {
^
source/common/network/connection_impl.cc:109:5: note: Calling 'ConnectionImpl::closeSocket'
closeSocket(ConnectionEvent::LocalClose);
^
source/common/network/connection_impl.cc:172:7: note: Assuming the condition is false
if (fd() == -1) {
^
source/common/network/connection_impl.cc:172:3: note: Taking false branch
if (fd() == -1) {
^
source/common/network/connection_impl.cc:177:3: note: Taking false branch
if (delayed_close_timer_) {
^
source/common/network/connection_impl.cc:193:3: note: Calling 'ConnectionImpl::raiseEvent'
raiseEvent(close_type);
^
source/common/network/connection_impl.cc:335:7: note: Call to virtual function during destruction
if (state() == State::Open && event == ConnectionEvent::Connected &&
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/network/connection_impl.cc:559:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
connection_stats_.reset(new ConnectionStats(stats));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<ConnectionStats>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/stats_matcher_impl.cc:22:17: warning: use emplace_back instead of push_back [modernize-use-emplace]
matchers_.push_back(Matchers::StringMatcher(stats_matcher));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/stats_matcher_impl.cc:29:17: warning: use emplace_back instead of push_back [modernize-use-emplace]
matchers_.push_back(Matchers::StringMatcher(stats_matcher));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/api/os_sys_calls_impl.cc:3:10: warning: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers]
#include <errno.h>
^~~~~~~~~
<cerrno>
mon/ssl/context_config_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/certificate_validation_context_config_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/singleton/manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/histogram_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/symbol_table_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_producer_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/stats_matcher_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/raw_stat_data.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/source_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_extractor_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/isolated_store_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/heap_stat_data.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/api/api_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/api/os_sys_calls_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codes.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/gith/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/isolated_store_impl.cc:3:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
^~~~~~~~~~
<cstring>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:171:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto hash : config.certificateValidationContext()->verifyCertificateSpkiList()) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:210:7: warning: the value returned by this function should be used [bugprone-unused-return-value]
cert.release();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:210:7: note: cast the expression to void to silence this warning
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:300:3: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
ContextImpl* impl = reinterpret_cast<ContextImpl*>(arg);
^~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:589:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
ContextImpl* context_impl = static_cast<ContextImpl*>(
^~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/context_impl.cc:591:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
ServerContextImpl* server_context_impl = dynamic_cast<ServerContextImpl*>(context_impl);
^~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/raw_stat_data.cc:3:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
^~~~~~~~~~
<cstring>
source/common/stats/histogram_impl.cc:14:27: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
: computed_quantiles_(supportedQuantiles().size(), 0.0) {
^
source/common/stats/histogram_impl.cc:14:27: note: This constructor of an object of type 'HistogramStatisticsImpl' has not returned when the virtual method was called
source/common/stats/histogram_impl.cc:14:27: note: Call to virtual function during construction
source/common/stats/histogram_impl.cc:15:39: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
hist_approx_quantile(histogram_ptr, supportedQuantiles().data(), supportedQuantiles().size(),
^
source/common/stats/histogram_impl.cc:15:39: note: This constructor of an object of type 'HistogramStatisticsImpl' has not returned when the virtual method was called
source/common/stats/histogram_impl.cc:15:39: note: Call to virtual function during construction
source/common/stats/histogram_impl.cc:15:68: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
hist_approx_quantile(histogram_ptr, supportedQuantiles().data(), supportedQuantiles().size(),
^
source/common/stats/histogram_impl.cc:15:68: note: This constructor of an object of type 'HistogramStatisticsImpl' has not returned when the virtual method was called
source/common/stats/histogram_impl.cc:15:68: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc:70:46: warning: pass by value and use std::move [modernize-pass-by-value]
Stats::ScopeSharedPtr scope,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc:73:60: warning: parameter 'scope' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
initial_metadata_(config.initial_metadata()), scope_(scope) {
^~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc:347:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto it : grpc_metadata) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc:376:5: warning: the value returned by this function should be used [bugprone-unused-return-value]
LinkedObject<GoogleAsyncStreamImpl>::removeFromList(parent_.active_streams_).release();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/grpc/google_async_client_impl.cc:376:5: note: cast the expression to void to silence this warning
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_producer_impl.cc:66:79: warning: the parameter 'f' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
const std::string& stat_name, std::function<void(const TagExtractorPtr&)> f) const {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/heap_stat_data.cc:11:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
HeapStatDataAllocator::HeapStatDataAllocator() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_extractor_impl.cc:3:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
^~~~~~~~~~
<cstring>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_extractor_impl.cc:26:36: warning: pass by value and use std::move [modernize-pass-by-value]
TagExtractorImpl::TagExtractorImpl(const std::string& name, const std::string& regex,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/tag_extractor_impl.cc:27:36: warning: pass by value and use std::move [modernize-pass-by-value]
const std::string& substr)
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/ssl_socket.cc:38:39: warning: the parameter 'ctx' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
SslSocket::SslSocket(ContextSharedPtr ctx, InitialState state)
~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/ssl/ssl_socket.cc:405:48: warning: pass by value and use std::move [modernize-pass-by-value]
const std::vector<std::string>& server_names)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::vector<std::string>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/utility.cc:258:80: warning: the parameter 'encode_headers' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
bool is_grpc, std::function<void(HeaderMapPtr&& headers, bool end_stream)> encode_headers,
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/utility.cc:259:66: warning: the parameter 'encode_data' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void(Buffer::Instance& data, bool end_stream)> encode_data, const bool& is_reset,
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/utility.cc:396:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto p : params) {
~~~~ ^
const &
ub/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/metadata_encoder.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/metadata_decoder.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/message_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/date_provider_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/user_agent.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/websocket/ws_handler_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/rest_api_fetcher.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/user_agent.cc:48:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
stats_.reset(new UserAgentStats{ALL_USER_AGENTS_STATS(POOL_COUNTER_PREFIX(scope, prefix_))});
~^~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<UserAgentStats>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:15:26: warning: pass by value and use std::move [modernize-pass-by-value]
Upstream::HostDescriptionConstSharedPtr host,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:17:62: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: type_(type), connection_(std::move(connection)), host_(host),
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:38:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
CodecClient::~CodecClient() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:137:74: warning: the parameter 'host' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Upstream::HostDescriptionConstSharedPtr host,
~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:142:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
codec_.reset(new Http1::ClientConnectionImpl(*connection_, *this));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Http1::ClientConnectionImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/codec_client.cc:146:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
codec_.reset(new Http2::ClientConnectionImpl(*connection_, *this, host->cluster().statsScope(),
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Http2::ClientConnectionImpl>
source/common/stats/thread_local_store.cc:27:68: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
: stats_options_(stats_options), alloc_(alloc), default_scope_(createScope("")),
^
source/common/stats/thread_local_store.cc:27:68: note: This constructor of an object of type 'ThreadLocalStoreImpl' has not returned when the virtual method was called
source/common/stats/thread_local_store.cc:27:68: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:130:54: warning: the parameter 'merge_complete_cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void ThreadLocalStoreImpl::mergeInternal(PostMergeCb merge_complete_cb) {
~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:218:75: warning: 'tag_extracted_name' used after it was moved [bugprone-use-after-move]
stat = make_stat(parent_.heap_allocator_, truncated_name, std::move(tag_extracted_name),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:215:9: note: move occurred here
make_stat(parent_.alloc_, truncated_name, std::move(tag_extracted_name), std::move(tags));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:219:34: warning: 'tags' used after it was moved [bugprone-use-after-move]
std::move(tags));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:215:9: note: move occurred here
make_stat(parent_.alloc_, truncated_name, std::move(tag_extracted_name), std::move(tags));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:371:52: warning: pass by value and use std::move [modernize-pass-by-value]
ThreadLocalHistogramImpl::ThreadLocalHistogramImpl(const std::string& name,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/stats/thread_local_store.cc:397:42: warning: pass by value and use std::move [modernize-pass-by-value]
ParentHistogramImpl::ParentHistogramImpl(const std::string& name, Store& parent,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:34:34: warning: pass by value and use std::move [modernize-pass-by-value]
AsyncClientImpl::AsyncClientImpl(Upstream::ClusterInfoConstSharedPtr cluster,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:40:16: warning: parameter 'cluster' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: cluster_(cluster),
^~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:54:3: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
AsyncRequestImpl* async_request =
^~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:87:20: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
buffered_body_.reset(new Buffer::OwnedImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:201:13: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
response_.reset(new ResponseMessageImpl(std::move(headers)));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<ResponseMessageImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/async_client_impl.cc:210:23: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
response_->body().reset(new Buffer::OwnedImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Buffer::OwnedImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger_delegates.cc:16:20: warning: parameter 'log_sink' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: SinkDelegate(log_sink), log_file_(log_manager.createAccessLog(log_path)) {}
^~~~~~~~~
std::move()
source/common/common/backoff_strategy.cc:18:36: warning: Division by zero [clang-analyzer-core.DivideZero]
return std::min(random_.random() % base_backoff, max_interval_);
^
source/common/common/backoff_strategy.cc:14:3: note: 'base_backoff' initialized here
const uint64_t base_backoff = multiplier * base_interval_;
^
source/common/common/backoff_strategy.cc:15:7: note: Assuming the condition is true
if (base_backoff <= max_interval_) {
^
source/common/common/backoff_strategy.cc:15:3: note: Taking true branch
if (base_backoff <= max_interval_) {
^
source/common/common/backoff_strategy.cc:18:36: note: Division by zero
return std::min(random_.random() % base_backoff, max_interval_);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:17:59: warning: pass by value and use std::move [modernize-pass-by-value]
ConnPoolImpl::ConnPoolImpl(Event::Dispatcher& dispatcher, Upstream::HostConstSharedPtr host,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:19:28: warning: pass by value and use std::move [modernize-pass-by-value]
const Network::ConnectionSocket::OptionsSharedPtr& options)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Network::ConnectionSocket::OptionsSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:20:38: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: dispatcher_(dispatcher), host_(host), priority_(priority), socket_options_(options) {}
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:89:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
primary_client_.reset(new ActiveClient(*this));
~^~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<ActiveClient>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:222:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
parent_.conn_connect_ms_.reset(new Stats::Timespan(
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/conn_pool.cc:238:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
conn_length_.reset(new Stats::Timespan(parent_.host_->cluster().stats().upstream_cx_length_ms_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:301:10: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
static ToLowerTable* table = new ToLowerTable();
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:449:23: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
current_header_map_.reset(new HeaderMapImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<HeaderMapImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:462:44: warning: pass by value and use std::move [modernize-pass-by-value]
Http1Settings settings)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:463:88: warning: parameter 'settings' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: ConnectionImpl(connection, HTTP_REQUEST), callbacks_(callbacks), codec_settings_(settings) {}
^~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:597:21: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
active_request_.reset(new ActiveRequest(*this));
~^~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<ActiveRequest>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/codec_impl.cc:691:20: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
request_encoder_.reset(new RequestStreamEncoderImpl(*this));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<RequestStreamEncoderImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc:79:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
std::vector<nghttp2_nv>* final_headers = static_cast<std::vector<nghttp2_nv>*>(context);
^~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc:127:23: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
pending_trailers_.reset(new HeaderMapImpl(trailers));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<HeaderMapImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc:655:67: warning: use nullptr [modernize-use-nullptr]
int rc = nghttp2_submit_settings(session_, NGHTTP2_FLAG_NONE, 0, 0);
^~
nullptr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc:802:22: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
stream->headers_.reset(new HeaderMapImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<HeaderMapImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http2/codec_impl.cc:835:22: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
stream->headers_.reset(new HeaderMapImpl());
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<HeaderMapImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/rest_api_fetcher.cc:29:62: warning: pass by value and use std::move [modernize-pass-by-value]
RestApiFetcher::RestApiFetcher(Upstream::ClusterManager& cm, const std::string& remote_cluster_name,
^~~~~~~~~~~~~~~~~~
std::string
/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/backoff_strategy.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/matchers.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger_delegates.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/hex.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/to_lower_table.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/thread.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/perf_annotation.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/base64.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/token_bucket_impl.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/version.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/tools/v1_to_bootstrap.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/tools/bootstrap2pb.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/fuzz/fuzz_runner.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/fuzz/main.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/printers.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/printers.cc:14:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
std::ostream* os = static_cast<std::ostream*>(context);
^~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/websocket/ws_handler_impl.cc:51:24: warning: parameter 'config' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: TcpProxy::Filter(config, cluster_manager, time_system), request_headers_(request_headers),
^~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/thread.cc:17:16: warning: pass by value and use std::move [modernize-pass-by-value]
Thread::Thread(std::function<void()> thread_routine) : thread_routine_(thread_routine) {
^ ~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/thread.cc:17:72: warning: parameter 'thread_routine' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
Thread::Thread(std::function<void()> thread_routine) : thread_routine_(thread_routine) {
^~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:22:59: warning: pass by value and use std::move [modernize-pass-by-value]
ConnPoolImpl::ConnPoolImpl(Event::Dispatcher& dispatcher, Upstream::HostConstSharedPtr host,
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:24:28: warning: pass by value and use std::move [modernize-pass-by-value]
const Network::ConnectionSocket::OptionsSharedPtr& options)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Network::ConnectionSocket::OptionsSharedPtr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:25:38: warning: parameter 'host' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: dispatcher_(dispatcher), host_(host), priority_(priority), socket_options_(options),
^~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:61:26: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
client.stream_wrapper_.reset(new StreamWrapper(response_decoder, client));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<StreamWrapper>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:315:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
parent_.conn_connect_ms_.reset(new Stats::Timespan(
~^~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/http1/conn_pool.cc:328:16: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
conn_length_.reset(new Stats::Timespan(parent_.host_->cluster().stats().upstream_cx_length_ms_,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Stats::Timespan>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/perf_annotation.cc:33:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
PerfAnnotationContext::PerfAnnotationContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/perf_annotation.cc:149:10: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
static PerfAnnotationContext* context = new PerfAnnotationContext();
^~~~~~~~~~~~~~~~~~~~~~
auto
tools/v1_to_bootstrap.cc:19:5: warning: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape]
int main(int argc, char** argv) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/matchers.cc:82:26: warning: pass by value and use std::move [modernize-pass-by-value]
ListMatcher::ListMatcher(const envoy::type::matcher::ListMatcher& matcher) : matcher_(matcher) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~
envoy::type::matcher::ListMatcher std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger.cc:29:49: warning: the parameter 'log_sink' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
SinkDelegate::SinkDelegate(DelegatingLogSinkPtr log_sink)
~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger.cc:39:86: warning: parameter 'log_sink' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
StderrSinkDelegate::StderrSinkDelegate(DelegatingLogSinkPtr log_sink) : SinkDelegate(log_sink) {}
^~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/logger.cc:70:55: warning: pass by value and use std::move [modernize-pass-by-value]
Context::Context(spdlog::level::level_enum log_level, const std::string& log_format,
^~~~~~~~~~~~~~~~~~
std::string
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/utility.cc:34:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef ConstSingleton<SpecifierConstantValues> SpecifierConstants;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using SpecifierConstants = ConstSingleton<SpecifierConstantValues>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/common/utility.cc:519:20: warning: narrowing conversion from 'double' to 'uint32_t' (aka 'unsigned int') [bugprone-narrowing-conversions]
uint32_t limit = sqrt(x);
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/test_time.cc:7:30: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
DangerousDeprecatedTestTime::DangerousDeprecatedTestTime() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/logging.cc:25:28: warning: parameter 'log_sink' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: Logger::SinkDelegate(log_sink) {}
^~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/logging.cc:26:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
LogRecordingSink::~LogRecordingSink() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/logging.cc:30:13: warning: use emplace_back instead of push_back [modernize-use-emplace]
messages_.push_back(std::string(msg));
^~~~~~~~~~~~~~~~~~~~~~~~~~~
emplace_back(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/tls_utility.cc:34:25: warning: use nullptr [modernize-use-nullptr]
const uint8_t* data = NULL;
^~~~~
nullptr
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:23:80: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Alarm(SimulatedTimeSystem& time_system, Libevent::BasePtr& libevent, TimerCb cb)
~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:27:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
virtual ~Alarm();
~~~~~~~~^ ~
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:54:25: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void runAlarm(TimerCb cb) {
~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:97:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
disableTimer();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:96:7: note: Assuming the condition is true
if (armed_) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:96:3: note: Taking true branch
if (armed_) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:97:5: note: This destructor of an object of type '~Alarm' has not returned when the virtual method was called
disableTimer();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:97:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:131:3: error: found ASSERT() with side effect [bugprone-assert-side-effect,-warnings-as-errors]
ASSERT(++instance_count <= 1);
^
bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/assert_lib/common/common/assert.h:40:68: note: expanded from macro 'ASSERT'
#define ASSERT(...) _ASSERT_SELECTOR(__VA_ARGS__, _ASSERT_VERBOSE, _ASSERT_ORIGINAL)(__VA_ARGS__)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc:221:7: warning: use auto when declaring iterators [modernize-use-auto]
AlarmSet::iterator pos = alarms_.begin();
^~~~~~~~~~~~~~~~~~
auto
/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/logging.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/test_time.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/utility_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/network_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/simulated_time_system_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/tls_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/config_load_check/config_load_check.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/schema_validator/schema_validator.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/schema_validator/validator.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router_check.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/json/tool_config_schemas.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config_test/example_configs_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config_test/config_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ratelimit/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:187:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto it : path_map) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:193:43: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
const std::regex loopback_address_regex("\\{\\{ ip_loopback_address \\}\\}");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(\{\{ ip_loopback_address \}\})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:196:48: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
const std::regex ntop_loopback_address_regex("\\{\\{ ntop_ip_loopback_address \\}\\}");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(\{\{ ntop_ip_loopback_address \}\})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:201:38: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
const std::regex any_address_regex("\\{\\{ ip_any_address \\}\\}");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(\{\{ ip_any_address \}\})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:206:40: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
const std::regex lookup_family_regex("\\{\\{ dns_lookup_family \\}\\}");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(\{\{ dns_lookup_family \}\})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:247:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto it : param_map) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/environment.cc:253:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto it : port_map) {
~~~~ ^
const &
source/common/http/header_map_impl.cc:53:15: warning: move constructors should be marked noexcept [performance-noexcept-move-constructor]
HeaderString::HeaderString(HeaderString&& move_value) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:286:28: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
current->entries_[c].reset(new StaticLookupEntry());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<StaticLookupEntry>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:377:5: warning: use auto when declaring iterators [modernize-use-auto]
std::list<HeaderEntryImpl>::iterator i = headers_.insert(std::move(key), std::move(value));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:406:10: warning: 'new_value' used after it was moved [bugprone-use-after-move]
ASSERT(new_value.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:405:3: note: move occurred here
insertByKey(std::move(ref_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:414:10: warning: 'new_value' used after it was moved [bugprone-use-after-move]
ASSERT(new_value.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:413:3: note: move occurred here
insertByKey(std::move(ref_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:430:10: warning: 'new_key' used after it was moved [bugprone-use-after-move]
ASSERT(new_key.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:429:3: note: move occurred here
insertByKey(std::move(new_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:431:10: warning: 'new_value' used after it was moved [bugprone-use-after-move]
ASSERT(new_value.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:429:3: note: move occurred here
insertByKey(std::move(new_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:445:10: warning: 'new_key' used after it was moved [bugprone-use-after-move]
ASSERT(new_key.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:444:3: note: move occurred here
insertByKey(std::move(new_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:446:10: warning: 'new_value' used after it was moved [bugprone-use-after-move]
ASSERT(new_value.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:444:3: note: move occurred here
insertByKey(std::move(new_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:462:10: warning: 'new_value' used after it was moved [bugprone-use-after-move]
ASSERT(new_value.empty());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:461:3: note: move occurred here
insertByKey(std::move(ref_key), std::move(new_value));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:575:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<HeaderEntryImpl>::iterator i = headers_.insert(key);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/header_map_impl.cc:589:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<HeaderEntryImpl>::iterator i = headers_.insert(key, std::move(value));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config/utility.cc:144:13: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (auto config_modifier : config_modifiers_) {
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config/utility.cc:457:59: warning: the parameter 'function' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void ConfigHelper::addConfigModifier(HttpModifierFunction function) {
~~~~~~~~~~~~~~~~~~~~ ^
const &
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/ratelimit/mocks.cc:7:28: note: Calling implicit destructor for 'FunctionMocker<void (Envoy::RateLimit::RequestCallbacks &, const std::__cxx11::basic_string<char> &, const std::vector<Envoy::RateLimit::Descriptor, std::allocator<Envoy::RateLimit::Descriptor> > &, Envoy::Tracing::Span &)>'
MockClient::~MockClient() {}
^
test/mocks/ratelimit/mocks.cc:7:28: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ratelimit/mocks.cc:6:13: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockClient::MockClient() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ratelimit/mocks.cc:7:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClient::~MockClient() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/test_common/utility.cc:356:46: note: Calling implicit destructor for 'FunctionMocker<void (Envoy::Stats::RawStatData &)>'
MockedTestAllocator::~MockedTestAllocator() {}
^
test/test_common/utility.cc:356:46: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/utility.cc:292:42: warning: initializer for base class 'Envoy::Http::HeaderMapImpl' is redundant [readability-redundant-member-init]
TestHeaderMapImpl::TestHeaderMapImpl() : HeaderMapImpl() {}
^~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/utility.cc:296:7: warning: initializer for base class 'Envoy::Http::HeaderMapImpl' is redundant [readability-redundant-member-init]
: HeaderMapImpl() {
^~~~~~~~~~~~~~~~~
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/test_common/utility.cc:356:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockedTestAllocator::~MockedTestAllocator() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:454:34: warning: the parameter 'filter' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
StreamDecoderFilterSharedPtr filter, bool dual_filter) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:461:34: warning: the parameter 'filter' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
StreamEncoderFilterSharedPtr filter, bool dual_filter) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:743:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamDecoderFilterPtr>::iterator continue_data_entry = decoder_filters_.end();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:972:45: warning: the parameter 'modify_headers' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void(HeaderMap& headers)> modify_headers, bool is_head_request) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1002:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamEncoderFilterPtr>::iterator entry = commonEncodePrefix(filter, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1032:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamEncoderFilterPtr>::iterator entry = commonEncodePrefix(filter, end_stream);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1033:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamEncoderFilterPtr>::iterator continue_data_entry = encoder_filters_.end();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1188:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamEncoderFilterPtr>::iterator entry = commonEncodePrefix(filter, end_stream);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1240:3: warning: use auto when declaring iterators [modernize-use-auto]
std::list<ActiveStreamEncoderFilterPtr>::iterator entry = commonEncodePrefix(filter, true);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/source/common/http/conn_manager_impl.cc:1520:17: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
auto buffer = Buffer::WatermarkBufferPtr{
^~~~~~~~~~~~~~~~~~~~~~~~~~~
std::make_unique<Buffer::WatermarkBuffer>(
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/access_log/mocks.cc:23:32: note: Calling implicit destructor for 'FunctionMocker<void (const Envoy::Http::HeaderMap *, const Envoy::Http::HeaderMap *, const Envoy::Http::HeaderMap *, const Envoy::StreamInfo::StreamInfo &)>'
MockInstance::~MockInstance() {}
^
test/mocks/access_log/mocks.cc:23:32: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc:13:13: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFilter::MockFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc:14:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilter::~MockFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc:20:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAccessLogManager::~MockAccessLogManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc:22:15: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockInstance::MockInstance() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc:23:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockInstance::~MockInstance() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stream_info/mocks.cc:75:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamInfo::~MockStreamInfo() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/config/mocks.cc:43:48: note: Calling implicit destructor for 'FunctionMocker<std::__cxx11::basic_string<char> (const google::protobuf::Any &)>'
MockGrpcMuxCallbacks::~MockGrpcMuxCallbacks() {}
^
test/mocks/config/mocks.cc:43:48: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/config/mocks.cc:10:19: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockGrpcMuxWatch::MockGrpcMuxWatch() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/config/mocks.cc:13:14: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockGrpcMux::MockGrpcMux() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/config/mocks.cc:14:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockGrpcMux::~MockGrpcMux() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/config/mocks.cc:43:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockGrpcMuxCallbacks::~MockGrpcMuxCallbacks() {}
^ ~~
= default;
external/com_github_eile_tclap/include/tclap/Arg.h:482:53: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
"Argument flag can only be one character long", toString() ) );
^
test/tools/schema_validator/validator.cc:23:18: note: Calling constructor for 'CmdLine'
TCLAP::CmdLine cmd("schema_validator_tool", ' ', "none", false);
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:342:2: note: Calling 'CmdLine::_constructor'
_constructor();
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:364:2: note: Taking false branch
if ( _helpAndVersion )
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:384:27: note: Calling constructor for 'SwitchArg'
SwitchArg* ignore = new SwitchArg(Arg::flagStartString(),
^
external/com_github_eile_tclap/include/tclap/SwitchArg.h:140:3: note: Calling constructor for 'Arg'
: Arg(flag, name, desc, false, false, v),
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:7: note: Assuming the condition is true
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:2: note: Taking true branch
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:482:53: note: This constructor of an object of type 'Arg' has not returned when the virtual method was called
"Argument flag can only be one character long", toString() ) );
^
external/com_github_eile_tclap/include/tclap/Arg.h:482:53: note: Call to virtual function during construction
external/com_github_eile_tclap/include/tclap/Arg.h:491:8: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
toString() ) );
^
test/tools/schema_validator/validator.cc:23:18: note: Calling constructor for 'CmdLine'
TCLAP::CmdLine cmd("schema_validator_tool", ' ', "none", false);
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:342:2: note: Calling 'CmdLine::_constructor'
_constructor();
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:364:2: note: Taking false branch
if ( _helpAndVersion )
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:384:27: note: Calling constructor for 'SwitchArg'
SwitchArg* ignore = new SwitchArg(Arg::flagStartString(),
^
external/com_github_eile_tclap/include/tclap/SwitchArg.h:140:3: note: Calling constructor for 'Arg'
: Arg(flag, name, desc, false, false, v),
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:7: note: Assuming the condition is false
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:2: note: Taking false branch
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:484:7: note: Left side of '&&' is true
if ( _name != ignoreNameString() &&
^
external/com_github_eile_tclap/include/tclap/Arg.h:485:38: note: Left side of '||' is true
( _flag == Arg::flagStartString() ||
^
external/com_github_eile_tclap/include/tclap/Arg.h:484:2: note: Taking true branch
if ( _name != ignoreNameString() &&
^
external/com_github_eile_tclap/include/tclap/Arg.h:491:8: note: This constructor of an object of type 'Arg' has not returned when the virtual method was called
toString() ) );
^
external/com_github_eile_tclap/include/tclap/Arg.h:491:8: note: Call to virtual function during construction
external/com_github_eile_tclap/include/tclap/Arg.h:499:8: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
toString() ) );
^
test/tools/schema_validator/validator.cc:23:18: note: Calling constructor for 'CmdLine'
TCLAP::CmdLine cmd("schema_validator_tool", ' ', "none", false);
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:342:2: note: Calling 'CmdLine::_constructor'
_constructor();
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:364:2: note: Taking false branch
if ( _helpAndVersion )
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:384:27: note: Calling constructor for 'SwitchArg'
SwitchArg* ignore = new SwitchArg(Arg::flagStartString(),
^
external/com_github_eile_tclap/include/tclap/SwitchArg.h:140:3: note: Calling constructor for 'Arg'
: Arg(flag, name, desc, false, false, v),
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:7: note: Assuming the condition is false
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:480:2: note: Taking false branch
if ( _flag.length() > 1 )
^
external/com_github_eile_tclap/include/tclap/Arg.h:484:35: note: Left side of '&&' is false
if ( _name != ignoreNameString() &&
^
external/com_github_eile_tclap/include/tclap/Arg.h:484:2: note: Taking false branch
if ( _name != ignoreNameString() &&
^
external/com_github_eile_tclap/include/tclap/Arg.h:493:88: note: Left side of '||' is true
if ( ( _name.substr( 0, Arg::flagStartString().length() ) == Arg::flagStartString() ) ||
^
external/com_github_eile_tclap/include/tclap/Arg.h:493:2: note: Taking true branch
if ( ( _name.substr( 0, Arg::flagStartString().length() ) == Arg::flagStartString() ) ||
^
external/com_github_eile_tclap/include/tclap/Arg.h:499:8: note: This constructor of an object of type 'Arg' has not returned when the virtual method was called
toString() ) );
^
external/com_github_eile_tclap/include/tclap/Arg.h:499:8: note: Call to virtual function during construction
external/com_github_eile_tclap/include/tclap/CmdLine.h:388:2: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
add( ignore );
^
test/tools/schema_validator/validator.cc:23:18: note: Calling constructor for 'CmdLine'
TCLAP::CmdLine cmd("schema_validator_tool", ' ', "none", false);
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:342:2: note: This constructor of an object of type 'CmdLine' has not returned when the virtual method was called
_constructor();
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:342:2: note: Calling 'CmdLine::_constructor'
external/com_github_eile_tclap/include/tclap/CmdLine.h:364:2: note: Taking false branch
if ( _helpAndVersion )
^
external/com_github_eile_tclap/include/tclap/CmdLine.h:388:2: note: Call to virtual function during construction
add( ignore );
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/secret/mocks.cc:28:46: note: Calling implicit destructor for 'FunctionMocker<void ()>'
MockSecretCallbacks::~MockSecretCallbacks() {}
^
test/mocks/secret/mocks.cc:28:46: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/secret/mocks.cc:24:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSecretManager::~MockSecretManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/secret/mocks.cc:26:22: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockSecretCallbacks::MockSecretCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/secret/mocks.cc:28:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSecretCallbacks::~MockSecretCallbacks() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/filesystem/mocks.cc:12:30: note: Calling implicit destructor for 'FunctionMocker<void (const std::__cxx11::basic_string<char> &, unsigned int, std::function<void (unsigned int)>)>'
MockWatcher::~MockWatcher() {}
^
test/mocks/filesystem/mocks.cc:12:30: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/filesystem/mocks.cc:8:11: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFile::MockFile() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/filesystem/mocks.cc:9:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFile::~MockFile() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/filesystem/mocks.cc:11:14: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockWatcher::MockWatcher() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/filesystem/mocks.cc:12:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockWatcher::~MockWatcher() {}
^ ~~
= default;
/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/config/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/cluster_info.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stream_info/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/access_log/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/secret/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/filesystem/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/thread_local/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc
clang-tidy-7 -header-filter=^/homexternal/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/upstream/cluster_info.cc:63:38: note: Calling '~NiceMock'
MockClusterInfo::~MockClusterInfo() {}
^
external/com_google_googletest/googlemock/include/gmock/gmock-generated-nice-strict.h:187:3: note: Calling '~MockLoadBalancerSubsetInfo'
}
^
test/mocks/upstream/cluster_info.cc:23:60: note: Calling implicit destructor for 'FunctionMocker<bool ()>'
MockLoadBalancerSubsetInfo::~MockLoadBalancerSubsetInfo() {}
^
test/mocks/upstream/cluster_info.cc:23:60: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/cluster_info.cc:23:29: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockLoadBalancerSubsetInfo::~MockLoadBalancerSubsetInfo() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/cluster_info.cc:29:33: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockIdleTimeEnabledClusterInfo::~MockIdleTimeEnabledClusterInfo() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/cluster_info.cc:63:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClusterInfo::~MockClusterInfo() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:16:59: warning: the const qualified parameter 'check_config' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
ToolConfig ToolConfig::create(const Json::ObjectSharedPtr check_config) {
^
&
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:129:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:138:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:148:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:156:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:168:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:180:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/tools/router_check/router.cc:196:15: warning: redundant string initialization [readability-redundant-string-init]
std::string actual = "";
^~~~~~~~~~~~
actual
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/upstream/host.cc:51:24: note: Calling '~NiceMock'
MockHost::~MockHost() {}
^
external/com_google_googletest/googlemock/include/gmock/gmock-generated-nice-strict.h:187:3: note: Calling '~MockDetectorHostMonitor'
}
^
test/mocks/upstream/host.cc:15:54: note: Calling implicit destructor for 'FunctionMocker<void (double)>'
MockDetectorHostMonitor::~MockDetectorHostMonitor() {}
^
test/mocks/upstream/host.cc:15:54: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:14:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockDetectorHostMonitor::MockDetectorHostMonitor() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:15:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDetectorHostMonitor::~MockDetectorHostMonitor() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:17:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockEventLogger::MockEventLogger() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:18:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockEventLogger::~MockEventLogger() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:26:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDetector::~MockDetector() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:30:29: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockHealthCheckHostMonitor::MockHealthCheckHostMonitor() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:31:29: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHealthCheckHostMonitor::~MockHealthCheckHostMonitor() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:43:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHostDescription::~MockHostDescription() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/host.cc:51:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHost::~MockHost() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/common.cc:11:38: note: Calling implicit destructor for 'FunctionMocker<bool (unsigned long)>'
MockTokenBucket::~MockTokenBucket() {}
^
test/mocks/common.cc:11:38: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:4:15: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
ReadyWatcher::ReadyWatcher() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:5:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
ReadyWatcher::~ReadyWatcher() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:7:17: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockTimeSystem::MockTimeSystem() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:8:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTimeSystem::~MockTimeSystem() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:10:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockTokenBucket::MockTokenBucket() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/common.cc:11:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTokenBucket::~MockTokenBucket() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/tracing/mocks.cc:25:28: note: Calling implicit destructor for 'FunctionMocker<Envoy::Tracing::Span *(const Envoy::Tracing::Config &, Envoy::Http::HeaderMap &, const std::__cxx11::basic_string<char> &, std::chrono::time_point<std::chrono::_V2::system_clock, std::chrono::duration<long, std::ratio<1, 1000000000> > >, Envoy::Tracing::Decision)>'
MockDriver::~MockDriver() {}
^
test/mocks/tracing/mocks.cc:25:28: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:12:11: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockSpan::MockSpan() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:13:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSpan::~MockSpan() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:19:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConfig::~MockConfig() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:21:17: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockHttpTracer::MockHttpTracer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:22:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHttpTracer::~MockHttpTracer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:24:13: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockDriver::MockDriver() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tracing/mocks.cc:25:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDriver::~MockDriver() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/event/mocks.cc:48:34: note: Calling implicit destructor for 'FunctionMocker<void (unsigned int)>'
MockFileEvent::~MockFileEvent() {}
^
test/mocks/event/mocks.cc:48:34: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:24:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDispatcher::~MockDispatcher() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:26:12: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockTimer::MockTimer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:37:12: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTimer::~MockTimer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:45:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSignalEvent::~MockSignalEvent() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:47:16: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFileEvent::MockFileEvent() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/event/mocks.cc:48:16: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFileEvent::~MockFileEvent() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/runtime/mocks.cc:27:42: note: Calling implicit destructor for 'FunctionMocker<const std::unordered_map<std::__cxx11::basic_string<char>, Envoy::Runtime::Snapshot::Entry, std::hash<std::__cxx11::string>, std::equal_to<std::__cxx11::basic_string<char> >, std::allocator<std::pair<const std::__cxx11::basic_string<char>, Envoy::Runtime::Snapshot::Entry> > > &()>'
MockOverrideLayer::~MockOverrideLayer() {}
^
test/mocks/runtime/mocks.cc:27:42: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc:15:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRandomGenerator::~MockRandomGenerator() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc:19:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSnapshot::~MockSnapshot() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc:23:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockLoader::~MockLoader() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc:25:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockOverrideLayer::MockOverrideLayer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/runtime/mocks.cc:27:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockOverrideLayer::~MockOverrideLayer() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/thread_local/mocks.cc:18:52: note: Calling implicit destructor for 'FunctionMocker<Envoy::Event::Dispatcher &()>'
MockInstance::~MockInstance() { shutdownThread_(); }
^
test/mocks/thread_local/mocks.cc:18:52: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config_test/config_test.cc:44:14: warning: pass by value and use std::move [modernize-pass-by-value]
ConfigTest(const OptionsImpl& options) : options_(options) {
^~~~~~~~~~~~~~~~~~ ~~~~~~~~
OptionsImpl std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/config_test/config_test.cc:56:30: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
cluster_manager_factory_.reset(new Upstream::ValidationClusterManagerFactory(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Upstream::ValidationClusterManagerFactory>
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/buffer/mocks.cc:26:42: note: Calling implicit destructor for 'FunctionMocker<Envoy::Buffer::Instance *(std::function<void ()>, std::function<void ()>)>'
MockBufferFactory::~MockBufferFactory() {}
^
test/mocks/buffer/mocks.cc:26:42: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:10:31: warning: parameter 'below_low' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: Buffer::WatermarkBuffer(below_low, above_high) {}
^~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:10:42: warning: parameter 'above_high' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: Buffer::WatermarkBuffer(below_low, above_high) {}
^~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:18:72: warning: the parameter #1 is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
MockBufferBase<Buffer::OwnedImpl>::MockBufferBase(std::function<void()>, std::function<void()>)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:18:95: warning: the parameter #2 is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
MockBufferBase<Buffer::OwnedImpl>::MockBufferBase(std::function<void()>, std::function<void()>)
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:25:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockBufferFactory::MockBufferFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/buffer/mocks.cc:26:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockBufferFactory::~MockBufferFactory() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/grpc/mocks.cc:16:52: note: Calling implicit destructor for 'FunctionMocker<std::unique_ptr<Envoy::Grpc::AsyncClientFactory, std::default_delete<Envoy::Grpc::AsyncClientFactory> > (const envoy::api::v2::core::GrpcService &, Envoy::Stats::Scope &, bool)>'
MockAsyncClientManager::~MockAsyncClientManager() {}
^
test/mocks/grpc/mocks.cc:16:52: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:6:19: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncRequest::MockAsyncRequest() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:7:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncRequest::~MockAsyncRequest() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:9:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncStream::MockAsyncStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:10:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncStream::~MockAsyncStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:12:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncClientFactory::MockAsyncClientFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:13:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClientFactory::~MockAsyncClientFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:15:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncClientManager::MockAsyncClientManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/grpc/mocks.cc:16:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClientManager::~MockAsyncClientManager() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/tcp/mocks.cc:33:32: note: Calling implicit destructor for 'FunctionMocker<void (Envoy::Network::MockClientConnection &)>'
MockInstance::~MockInstance() {}
^
test/mocks/tcp/mocks.cc:33:32: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:15:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockCancellable::MockCancellable() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:16:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockCancellable::~MockCancellable() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:18:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockUpstreamCallbacks::MockUpstreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:19:24: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockUpstreamCallbacks::~MockUpstreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:21:21: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockConnectionData::MockConnectionData() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/tcp/mocks.cc:33:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockInstance::~MockInstance() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/local_info/mocks.cc:26:34: note: Calling implicit destructor for 'FunctionMocker<envoy::api::v2::core::Node &()>'
MockLocalInfo::~MockLocalInfo() {}
^
test/mocks/local_info/mocks.cc:26:34: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/local_info/mocks.cc:26:16: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockLocalInfo::~MockLocalInfo() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/ssl/mocks.cc:13:42: note: Calling implicit destructor for 'FunctionMocker<std::unique_ptr<envoy::admin::v2alpha::CertificateDetails, std::default_delete<envoy::admin::v2alpha::CertificateDetails> > ()>'
MockClientContext::~MockClientContext() {}
^
test/mocks/ssl/mocks.cc:13:42: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:6:21: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockContextManager::MockContextManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:7:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockContextManager::~MockContextManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:9:17: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockConnection::MockConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:10:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnection::~MockConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:12:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockClientContext::MockClientContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc:13:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClientContext::~MockClientContext() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/init/mocks.cc:30:30: note: Calling implicit destructor for 'FunctionMocker<void (Envoy::Init::Target &)>'
MockManager::~MockManager() {}
^
test/mocks/init/mocks.cc:30:30: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/init/mocks.cc:22:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTarget::~MockTarget() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/init/mocks.cc:30:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockManager::~MockManager() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/api/mocks.cc:21:36: note: Calling implicit destructor for 'FunctionMocker<Envoy::Api::SysCallResult<int> (int, int, int)>'
MockOsSysCalls::~MockOsSysCalls() {}
^
test/mocks/api/mocks.cc:21:36: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/api/mocks.cc:17:10: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockApi::~MockApi() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/api/mocks.cc:21:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockOsSysCalls::~MockOsSysCalls() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/tcp_dump.cc:3:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
e/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/ssl/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/api/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/local_info/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/init/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/stats_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/echo_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http2_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xfcc_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http2_upstream_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/tcp_dump.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_protocol_integration.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/idle_timeout_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/eexternal/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/router/mocks.cc:102:68: note: Calling implicit destructor for 'FunctionMocker<std::unique_ptr<Envoy::Router::RouteConfigProvider, std::default_delete<Envoy::Router::RouteConfigProvider> > (const envoy::api::v2::RouteConfiguration &, Envoy::Server::Configuration::FactoryContext &)>'
MockRouteConfigProviderManager::~MockRouteConfigProviderManager() {}
^
test/mocks/router/mocks.cc:102:68: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:18:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockDirectResponseEntry::MockDirectResponseEntry() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:19:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDirectResponseEntry::~MockDirectResponseEntry() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:21:17: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockRetryState::MockRetryState() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:28:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRetryState::~MockRetryState() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:34:27: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRateLimitPolicyEntry::~MockRateLimitPolicyEntry() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:41:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRateLimitPolicy::~MockRateLimitPolicy() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:43:19: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockShadowWriter::MockShadowWriter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:44:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockShadowWriter::~MockShadowWriter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:51:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockVirtualHost::~MockVirtualHost() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:53:17: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockHashPolicy::MockHashPolicy() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:54:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHashPolicy::~MockHashPolicy() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:56:28: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockMetadataMatchCriteria::MockMetadataMatchCriteria() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:57:28: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockMetadataMatchCriteria::~MockMetadataMatchCriteria() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:64:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockPathMatchCriterion::~MockPathMatchCriterion() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:80:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRouteEntry::~MockRouteEntry() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:88:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConfig::~MockConfig() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:93:16: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDecorator::~MockDecorator() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:99:12: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRoute::~MockRoute() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:101:33: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockRouteConfigProviderManager::MockRouteConfigProviderManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/router/mocks.cc:102:33: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRouteConfigProviderManager::~MockRouteConfigProviderManager() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/upstream/mocks.cc:142:52: note: Calling implicit destructor for 'FunctionMocker<void (std::shared_ptr<const Envoy::Upstream::HostDescription>)>'
MockRetryHostPredicate::~MockRetryHostPredicate() {}
^
test/mocks/upstream/mocks.cc:142:52: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:37:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHostSet::~MockHostSet() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:49:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockPrioritySet::~MockPrioritySet() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:69:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRetryPriority::~MockRetryPriority() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:82:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockCluster::~MockCluster() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:84:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockLoadBalancerContext::MockLoadBalancerContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:86:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockLoadBalancerContext::~MockLoadBalancerContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:90:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockLoadBalancer::~MockLoadBalancer() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:98:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockThreadLocalCluster::~MockThreadLocalCluster() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:117:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClusterManager::~MockClusterManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:125:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHealthChecker::~MockHealthChecker() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:131:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockCdsApi::~MockCdsApi() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:133:29: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockClusterUpdateCallbacks::MockClusterUpdateCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:135:29: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClusterUpdateCallbacks::~MockClusterUpdateCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:137:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockClusterInfoFactory::MockClusterInfoFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:139:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClusterInfoFactory::~MockClusterInfoFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:141:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockRetryHostPredicate::MockRetryHostPredicate() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/upstream/mocks.cc:142:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockRetryHostPredicate::~MockRetryHostPredicate() {}
^ ~~
= default;
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/stats/mocks.cc:85:52: note: Calling implicit destructor for 'FunctionMocker<void (const Envoy::Stats::Histogram &, unsigned long)>'
MockIsolatedStatsStore::~MockIsolatedStatsStore() {}
^
test/mocks/stats/mocks.cc:85:52: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:23:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockCounter::~MockCounter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:31:12: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockGauge::~MockGauge() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:43:16: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHistogram::~MockHistogram() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:58:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockParentHistogram::~MockParentHistogram() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:66:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSource::~MockSource() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:68:11: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockSink::MockSink() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:69:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSink::~MockSink() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:82:12: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStore::~MockStore() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:84:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockIsolatedStatsStore::MockIsolatedStatsStore() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/stats/mocks.cc:85:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockIsolatedStatsStore::~MockIsolatedStatsStore() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/stats_integration_test.cc:107:30: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
tag_specifier->set_regex("^(?:|listener(?=\\.).*?\\.)http\\.((.*?)\\.)");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(^(?:|listener(?=\.).*?\.)http\.((.*?)\.))"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http2_integration_test.cc:471:3: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = fake_upstream_connections_.begin(); it != fake_upstream_connections_.end(); ++it) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & fake_upstream_connection : fake_upstream_connections_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http2_integration_test.cc:491:48: warning: the parameter 'headers' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
int request_bytes, Http::TestHeaderMapImpl headers,
~~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http2_integration_test.cc:492:52: warning: the parameter 'cb' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void(IntegrationStreamDecoder&)> cb) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/websocket_integration_test.cc:359:30: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
if (!old_style_websockets_)
^
{
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/tcp_proxy_integration_test.cc:366:20: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
context_manager_.reset(new Ssl::ContextManagerImpl(runtime_, timeSystem()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Ssl::ContextManagerImpl>
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/server/mocks.cc:199:38: note: Calling implicit destructor for 'FunctionMocker<testing::NiceMock<Envoy::Http::MockStreamDecoderFilterCallbacks> &()>'
MockAdminStream::~MockAdminStream() {}
^
test/mocks/server/mocks.cc:199:38: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:21:26: warning: pass by value and use std::move [modernize-pass-by-value]
MockOptions::MockOptions(const std::string& config_path) : config_path_(config_path) {
^~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~
std::string std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:37:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockOptions::~MockOptions() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:47:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConfigTracker::~MockConfigTracker() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:52:12: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAdmin::~MockAdmin() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:57:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDrainManager::~MockDrainManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:59:15: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockWatchDog::MockWatchDog() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:60:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockWatchDog::~MockWatchDog() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:65:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockGuardDog::~MockGuardDog() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:72:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHotRestart::~MockHotRestart() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:77:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockOverloadManager::~MockOverloadManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:92:31: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerComponentFactory::~MockListenerComponentFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:94:22: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerManager::MockListenerManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:95:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerManager::~MockListenerManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:97:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockWorkerFactory::MockWorkerFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:98:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockWorkerFactory::~MockWorkerFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:115:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockWorker::~MockWorker() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:118:74: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
: secret_manager_(new Secret::SecretManagerImpl()), cluster_manager_(timeSystem()),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:118:74: note: This constructor of an object of type 'MockInstance' has not returned when the virtual method was called
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:118:74: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:119:45: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
ssl_context_manager_(runtime_loader_, timeSystem()),
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:119:45: note: This constructor of an object of type 'MockInstance' has not returned when the virtual method was called
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:119:45: note: Call to virtual function during construction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:144:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockInstance::~MockInstance() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:156:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockMain::~MockMain() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:177:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFactoryContext::~MockFactoryContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:182:36: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTransportSocketFactoryContext::~MockTransportSocketFactoryContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:184:29: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerFactoryContext::MockListenerFactoryContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:185:29: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerFactoryContext::~MockListenerFactoryContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:196:34: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockHealthCheckerFactoryContext::~MockHealthCheckerFactoryContext() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:198:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAdminStream::MockAdminStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/server/mocks.cc:199:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAdminStream::~MockAdminStream() {}
^ ~~
= default;
xecroot/envoy/test/integration/tcp_proxy_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/websocket_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/sds_dynamic_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/eds_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/h1_capture_fuzz_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/uds_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/header_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/proxy_proto_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/legacy_json_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/autonomous_upstream.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/fake_upstream.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/server.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ssl_utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/utility.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ratelimit_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xds_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/overload_integration_test.c/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:81:46: warning: parameter 'host_description' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
: CodecClientProd(type, std::move(conn), host_description, dispatcher), dispatcher_(dispatcher),
^~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:204:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return IntegrationCodecClientPtr{new IntegrationCodecClient(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::make_unique<IntegrationCodecClient>(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:300:3: warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]
return upstream_with_request;
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:243:7: note: Assuming 'request_body_size' is 0
if (request_body_size) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:243:3: note: Taking false branch
if (request_body_size) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:248:3: note: Calling 'HttpIntegrationTest::waitForNextUpstreamRequest'
waitForNextUpstreamRequest();
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:304:3: note: Calling 'HttpIntegrationTest::waitForNextUpstreamRequest'
waitForNextUpstreamRequest(std::vector<uint64_t>({upstream_index}));
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:278:3: note: 'upstream_with_request' declared without an initial value
uint64_t upstream_with_request;
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:280:3: note: Taking false branch
if (!fake_upstream_connection_) {
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:300:3: note: Undefined or garbage value returned to caller
return upstream_with_request;
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:1048:26: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
Buffer::OwnedImpl data("{\"TableName\":\"locations\"}");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"({"TableName":"locations"})"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:1426:15: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
ASSERT_TRUE(upstream_headers.get() != nullptr);
^~~~~~~~~~~~~~~~~~~~~~
upstream_headers
external/com_google_googletest/googletest/include/gtest/gtest.h:1914:23: note: expanded from macro 'ASSERT_TRUE'
GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
^
external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:1282:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
::testing::AssertionResult(expression)) \
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:1451:15: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
ASSERT_TRUE(upstream_headers.get() != nullptr);
^~~~~~~~~~~~~~~~~~~~~~
upstream_headers
external/com_google_googletest/googletest/include/gtest/gtest.h:1914:23: note: expanded from macro 'ASSERT_TRUE'
GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
^
external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:1282:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
::testing::AssertionResult(expression)) \
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:1468:15: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
ASSERT_TRUE(upstream_headers.get() != nullptr);
^~~~~~~~~~~~~~~~~~~~~~
upstream_headers
external/com_google_googletest/googletest/include/gtest/gtest.h:1914:23: note: expanded from macro 'ASSERT_TRUE'
GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
^
external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:1282:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
::testing::AssertionResult(expression)) \
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/http_integration.cc:1547:15: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
ASSERT_TRUE(upstream_headers.get() != nullptr);
^~~~~~~~~~~~~~~~~~~~~~
upstream_headers
external/com_google_googletest/googletest/include/gtest/gtest.h:1914:23: note: expanded from macro 'ASSERT_TRUE'
GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
^
external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h:1282:34: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
::testing::AssertionResult(expression)) \
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/pause_filter.cc:66:25: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Http::FilterFactoryCb createFilter(const std::string&, Server::Configuration::FactoryContext&) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/sds_dynamic_integration_test.cc:289:5: warning: qualified name 'HttpIntegrationTest::initialize' refers to a member overridden in subclass; did you mean 'Envoy::Ssl::SdsDynamicDownstreamIntegrationTest'? [bugprone-parent-virtual-call]
HttpIntegrationTest::initialize();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Envoy::Ssl::SdsDynamicDownstreamIntegrationTest::
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/fake_upstream.cc:208:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
codec_.reset(new Http::Http1::ServerConnectionImpl(shared_connection_.connection(), *this,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Http::Http1::ServerConnectionImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/fake_upstream.cc:213:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
codec_.reset(new Http::Http2::ServerConnectionImpl(shared_connection_.connection(), *this,
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Http::Http2::ServerConnectionImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/fake_upstream.cc:372:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_.reset(new Thread::Thread([this]() -> void { threadRoutine(); }));
~^~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/fake_upstream.cc:451:5: warning: use range-based for loop instead [modernize-loop-convert]
for (auto it = upstreams.begin(); it != upstreams.end(); ++it) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(auto & it : upstreams)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/random_pause_filter.cc:52:25: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Http::FilterFactoryCb createFilter(const std::string&, Server::Configuration::FactoryContext&) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/random_pause_filter.cc:55:11: error: redundant get() call on smart pointer [readability-redundant-smartptr-get,-warnings-as-errors]
if (rng_.get() == nullptr) {
^~~~~~~~~~
rng_
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/http/mocks.cc:166:32: note: Calling implicit destructor for 'FunctionMocker<Envoy::Http::ConnectionPool::Cancellable *(Envoy::Http::StreamDecoder &, Envoy::Http::ConnectionPool::Callbacks &)>'
MockInstance::~MockInstance() {}
^
test/mocks/http/mocks.cc:166:32: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:22:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockConnectionCallbacks::MockConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:23:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnectionCallbacks::~MockConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:25:32: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockServerConnectionCallbacks::MockServerConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:26:32: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockServerConnectionCallbacks::~MockServerConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:28:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockStreamDecoder::MockStreamDecoder() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:29:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamDecoder::~MockStreamDecoder() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:31:22: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockStreamCallbacks::MockStreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:32:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamCallbacks::~MockStreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:50:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStream::~MockStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:56:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamEncoder::~MockStreamEncoder() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:62:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockServerConnection::~MockServerConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:64:23: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockClientConnection::MockClientConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:65:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClientConnection::~MockClientConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:67:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFilterChainFactory::MockFilterChainFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:68:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilterChainFactory::~MockFilterChainFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:97:35: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamDecoderFilterCallbacks::~MockStreamDecoderFilterCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:106:35: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamEncoderFilterCallbacks::~MockStreamEncoderFilterCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:114:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamDecoderFilter::~MockStreamDecoderFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:122:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamEncoderFilter::~MockStreamEncoderFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:135:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockStreamFilter::~MockStreamFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:140:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClient::~MockAsyncClient() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:142:27: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncClientCallbacks::MockAsyncClientCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:143:27: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClientCallbacks::~MockAsyncClientCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:145:33: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncClientStreamCallbacks::MockAsyncClientStreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:146:33: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClientStreamCallbacks::~MockAsyncClientStreamCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:151:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockAsyncClientStream::MockAsyncClientStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:152:24: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAsyncClientStream::~MockAsyncClientStream() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:154:34: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFilterChainFactoryCallbacks::MockFilterChainFactoryCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:155:34: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilterChainFactoryCallbacks::~MockFilterChainFactoryCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:162:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockCancellable::MockCancellable() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:163:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockCancellable::~MockCancellable() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:165:15: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockInstance::MockInstance() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/http/mocks.cc:166:15: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockInstance::~MockInstance() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/add_trailers_filter.cc:15:26: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Http::FilterDataStatus decodeData(Buffer::Instance&, bool end_stream) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/add_trailers_filter.cc:23:26: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Http::FilterDataStatus encodeData(Buffer::Instance&, bool end_stream) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/add_trailers_filter.cc:37:25: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
Http::FilterFactoryCb createFilter(const std::string&, Server::Configuration::FactoryContext&) {
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/utility.cc:112:8: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
api_.reset(new Api::Impl(std::chrono::milliseconds(10000)));
~^~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Api::Impl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/utility.cc:120:83: warning: parameter 'data_callback' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
client_->addReadFilter(Network::ReadFilterSharedPtr{new ForwardingFilter(*this, data_callback)});
^~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/utility.cc:125:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
RawConnectionDriver::~RawConnectionDriver() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/utility.cc:138:38: warning: use absl::StartsWith instead of find() == 0 [abseil-string-find-startswith]
if ((!data_to_wait_for_.empty() && data_.find(data_to_wait_for_) == 0) ||
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
absl::StartsWith(data_, data_to_wait_for_)
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration.cc:286:5: warning: 'push_back' is called inside a loop; consider pre-allocating the vector capacity before the loop [performance-inefficient-vector-operation]
named_ports.push_back(static_resources.listeners(i).name());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration.cc:306:10: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
return IntegrationTcpClientPtr{new IntegrationTcpClient(*dispatcher_, *mock_buffer_factory_, port,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::make_unique<IntegrationTcpClient>(
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/server.cc:52:26: warning: parameter 'pre_worker_start_test_steps' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
server->start(version, pre_worker_start_test_steps, deterministic);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
std::move()
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/server.cc:57:57: warning: the parameter 'pre_worker_start_test_steps' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::function<void()> pre_worker_start_test_steps,
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/server.cc:61:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
thread_.reset(new Thread::Thread(
~^~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Thread::Thread>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/server.cc:148:11: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
server_.reset(new Server::InstanceImpl(
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<Server::InstanceImpl>
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: warning: Call to virtual function during destruction [clang-analyzer-optin.cplusplus.VirtualCall]
ClearDefaultActionsLocked();
^
test/mocks/network/mocks.cc:227:64: note: Calling '~NiceMock'
MockTransportSocketCallbacks::~MockTransportSocketCallbacks() {}
^
external/com_google_googletest/googlemock/include/gmock/gmock-generated-nice-strict.h:187:3: note: Calling '~MockConnection'
}
^
test/mocks/network/mocks.cc:105:36: note: Calling implicit destructor for 'FunctionMocker<std::chrono::duration<long, std::ratio<1, 1000> > ()>'
MockConnection::~MockConnection() {}
^
test/mocks/network/mocks.cc:105:36: note: Calling '~FunctionMockerBase'
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: This destructor of an object of type '~FunctionMockerBase' has not returned when the virtual method was called
ClearDefaultActionsLocked();
^
external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1485:5: note: Call to virtual function during destruction
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:33:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerConfig::~MockListenerConfig() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:35:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockConnectionCallbacks::MockConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:36:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnectionCallbacks::~MockConnectionCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:105:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnection::~MockConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:113:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockClientConnection::~MockClientConnection() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:115:21: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockActiveDnsQuery::MockActiveDnsQuery() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:116:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockActiveDnsQuery::~MockActiveDnsQuery() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:122:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDnsResolver::~MockDnsResolver() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:128:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockAddressResolver::~MockAddressResolver() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:136:26: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockReadFilterCallbacks::~MockReadFilterCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:145:17: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockReadFilter::~MockReadFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:147:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockWriteFilter::MockWriteFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:148:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockWriteFilter::~MockWriteFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:156:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilter::~MockFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:158:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerCallbacks::MockListenerCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:159:24: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerCallbacks::~MockListenerCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:161:20: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockDrainDecision::MockDrainDecision() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:162:20: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockDrainDecision::~MockDrainDecision() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:164:21: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerFilter::MockListenerFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:165:21: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerFilter::~MockListenerFilter() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:167:30: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerFilterCallbacks::MockListenerFilterCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:168:30: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerFilterCallbacks::~MockListenerFilterCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:170:28: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListenerFilterManager::MockListenerFilterManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:171:28: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenerFilterManager::~MockListenerFilterManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:173:18: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFilterChain::MockFilterChain() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:174:18: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilterChain::~MockFilterChain() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:176:25: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockFilterChainManager::MockFilterChainManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:177:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilterChainManager::~MockFilterChainManager() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:182:25: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockFilterChainFactory::~MockFilterChainFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:190:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockListenSocket::~MockListenSocket() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:196:19: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockSocketOption::~MockSocketOption() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:202:23: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnectionSocket::~MockConnectionSocket() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:204:15: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockListener::MockListener() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:207:24: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockConnectionHandler::MockConnectionHandler() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:208:24: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockConnectionHandler::~MockConnectionHandler() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:210:9: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockIp::MockIp() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:211:9: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockIp::~MockIp() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:213:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockResolvedAddress::~MockResolvedAddress() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:219:22: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTransportSocket::~MockTransportSocket() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:221:29: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
MockTransportSocketFactory::MockTransportSocketFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:222:29: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTransportSocketFactory::~MockTransportSocketFactory() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/mocks/network/mocks.cc:227:31: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
MockTransportSocketCallbacks::~MockTransportSocketCallbacks() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/header_integration_test.cc:272:23: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"%UPSTREAM_METADATA([\"test.namespace\", \"key\"])%", append);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(%UPSTREAM_METADATA(["test.namespace", "key"])%)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/header_integration_test.cc:278:25: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"vhost:%UPSTREAM_METADATA([\"test.namespace\", \"key\"])%", append);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(vhost:%UPSTREAM_METADATA(["test.namespace", "key"])%)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/header_integration_test.cc:282:27: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"route:%UPSTREAM_METADATA([\"test.namespace\", \"key\"])%", append);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(route:%UPSTREAM_METADATA(["test.namespace", "key"])%)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/header_integration_test.cc:289:33: warning: escaped string literal can be written as a raw string literal [modernize-raw-string-literal]
"weighted:%UPSTREAM_METADATA([\"test.namespace\", \"key\"])%",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"(weighted:%UPSTREAM_METADATA(["test.namespace", "key"])%)"
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xfcc_integration_test.cc:127:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
runtime_.reset(new NiceMock<Runtime::MockLoader>());
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
= std::make_unique<NiceMock<Runtime::MockLoader>>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xfcc_integration_test.cc:128:20: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
context_manager_.reset(new Ssl::ContextManagerImpl(*runtime_, timeSystem()));
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
= std::make_unique<Ssl::ContextManagerImpl>
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xfcc_integration_test.cc:134:76: warning: the parameter 'previous_xfcc' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
void XfccIntegrationTest::testRequestAndResponseWithXfccHeader(std::string previous_xfcc,
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/xfcc_integration_test.cc:135:76: warning: the parameter 'expected_xfcc' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
std::string expected_xfcc) {
~~~ ^
const &
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration_admin_test.cc:348:30: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
for (Json::ObjectSharedPtr obj_ptr : json->getObjectArray("configs")) {
~~~~ ^
const &
c
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ads_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/pause_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/random_pause_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/filters/add_trailers_filter.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration_admin_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/hds_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/load_stats_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ssl_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/h1_capture_direct_response_fuzz_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/tcp_conn_pool_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/sds_static_integration_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/h1_fuzz.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/server/server_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/server/options_impl_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/server/lds_api_test.cc
clang-tidy-7 -header-filter=^/home/lizan/github/lizan/envoy/master/.* -p=/home/lizan/github/lizan/envoy/master /home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/server/configuration_impl_test.cc
clang-tidy-7 -header-filter=^/home/lizan/githu/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ratelimit_integration_test.cc:24:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~RatelimitGrpcClientIntegrationParamTest() {}
^
override
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ratelimit_integration_test.cc:24:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~RatelimitGrpcClientIntegrationParamTest() {}
^ ~~
= default;
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ratelimit_integration_test.cc:225:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
IntegrationStreamDecoder* response = static_cast<IntegrationStreamDecoder*>(context);
^~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ratelimit_integration_test.cc:263:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
IntegrationStreamDecoder* response = static_cast<IntegrationStreamDecoder*>(context);
^~~~~~~~~~~~~~~~~~~~~~~~~
auto
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/server/options_impl_test.cc:31:7: warning: 'push_back' is called inside a loop; consider pre-allocating the vector capacity before the loop [performance-inefficient-vector-operation]
argv.push_back(s.c_str());
^
/home/lizan/.cache/bazel/_bazel_lizan/3a89de24641607fe25c5d5d5ad68d05f/execroot/envoy/test/integration/ssl_integration_test.cc:34:12: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
runtime_.reset(new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment