Created
February 10, 2012 02:32
-
-
Save lucasdavila/1785732 to your computer and use it in GitHub Desktop.
Código limpo para ler
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# sem linhas em branco, código não tão junto | |
if current_user.has_role('admin') | |
cases = cases.of_product(product) | |
elif current_user.has_role('employee') | |
cases = cases.of_product_accessible_by_employee(product, current_user) | |
elif current_user.has_role('customer') | |
cases = cases.of_product_accessible_by_customer(product, current_user) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# sem linhas em branco, tudo muito junto | |
if current_user.role? :admin | |
@cases = @cases.of_product @product | |
elsif current_user.role? :employee | |
@cases = @cases.of_product_accessible_by_employee @product, current_user | |
elsif current_user.role? :customer | |
@cases = @cases.of_product_accessible_by_customer @product, current_user | |
end | |
# com linhas em branco, muitas linhas | |
if current_user.role? :admin | |
@cases = @cases.of_product @product | |
elsif current_user.role? :employee | |
@cases = @cases.of_product_accessible_by_employee @product, current_user | |
elsif current_user.role? :customer | |
@cases = @cases.of_product_accessible_by_customer @product, current_user | |
end |
@lucasdavila eu faria exatamente como tu fez, a única diferença seria os parenteses, que geralmente eu coloco
if current_user.role?(:admin)
@cases = @cases.of_product(@product)
elsif current_user.role?(:employee)
@cases = @cases.of_product_accessible_by_employee(@product, current_user)
elsif current_user.role?(:customer)
@cases = @cases.of_product_accessible_by_customer(@product, current_user)
end
outra solução é partir para o case
case current_user.role
when :admin
@cases = @cases.of_product(@product)
when :employee
@cases = @cases.of_product_accessible_by_employee(@product, current_user)
when :customer
@cases = @cases.of_product_accessible_by_customer(@product, current_user)
end
ou
@cases = case current_user.role
when :admin
@cases.of_product(@product)
when :employee
@cases.of_product_accessible_by_employee(@product, current_user)
when :customer
@cases.of_product_accessible_by_customer(@product, current_user)
end
que nesse caso eu acho bem mais legível
@rafaelss deixarei como antes, até que pense uma maneira melhor.
if current_user.role? :admin
@cases = @cases.of_product @product
elsif current_user.role? :employee
@cases = @cases.of_product_accessible_by_employee @product, current_user
elsif current_user.role? :customer
@cases = @cases.of_product_accessible_by_customer @product, current_user
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@kurko baseado na tua sugestão, eu poderia fazer assim:
Ainda assim, lá dentro da classe do User (no metodo .role ) precisaria ver quais os papeis do usuário, ai para não usar if lá, a sugestão do @tarsis com polimorfismo se aplica :)
rss de uma insatisfação aprendi algumas coisas xD