- Why change is necessary (fix, update, new feature)?
- What functional part of the code is being changed?
- How does the change exactly work (what will change and how)?
- Related NuttX Issue reference if applicable.
- Related NuttX Apps Issue / Pull Request reference if applicable.
- Is new feature added? Is existing feature changed?
- Impact on user (will user need to adapt to change)? NO / YES (please describe if yes).
- Impact on build (will build process change)? NO / YES (please descibe if yes).
- Impact on hardware (will arch(s) / board(s) / driver(s) change)? NO / YES (please describe if yes).
- Impact on documentation (is update required / provided)? NO / YES (please describe if yes).
- Impact on security (any sort of implications)? NO / YES (please describe if yes).
- Impact on compatibility (backward/forward/interoperability)? NO / YES (please describe if yes).
- Anything else to consider?
I confirm that changes are verified on local setup and works as intended:
- Build Host(s): OS (Linux,BSD,macOS,Windows,..), CPU(Intel,AMD,ARM), compiler(GCC,CLANG,version), etc.
- Target(s): arch(sim,RISC-V,ARM,..), board:config, etc.
Testing logs before change:
your testing logs here
Testing logs after change:
your testing logs here
No need to spend time thinking about the choice of devminor maybe. See apache/nuttx-apps#2579 for more details.
- boards/arm64/qemu/qemu-armv8a/configs/sotest/defconfig
- boards/sim/sim/sim/configs/sotest/defconfig
- boards/sim/sim/sim/configs/sotest32/defconfig
$ make distclean
$ ./tools/configure.sh -l sim:sotest
$ make savedefconfig
$ diff defconfig boards/sim/sim/sim/configs/sotest/defconfig
$ echo $?
0
$ make distclean
$ ./tools/configure.sh -l sim:sotest32
$ make savedefconfig
$ diff defconfig boards/sim/sim/sim/configs/sotest32/defconfig
$ echo $?
0
The PR appears to simplify the configuration process related to 'devminor' selection, as elaborated in the linked PR #2579. It specifically modifies default configurations for sotest across different architectures and boards.
- New feature/Existing feature change: It's likely an optimization or simplification of an existing configuration process rather than a new feature addition.
- User impact: No, users shouldn't need to adapt to this change as it's internal to configuration files.
- Build impact: No, the build process itself should remain unchanged.
- Hardware impact: No, no changes are indicated for architectures, boards, or drivers.
- Documentation: Potentially YES. If the
devminorselection was previously documented for users, an update might be needed to reflect the simplification. - Security: No security implications are apparent from the provided information.
- Compatibility: No backward/forward compatibility issues are expected as it's a configuration change.
- Build Hosts: Unspecified. It would be beneficial to list the OS and compiler used for verification.
- Targets: Simulated architectures (
sim) and potentiallyqemu-armv8a. The exact configurations (sotest,sotest32) are mentioned. - Testing logs: The provided logs demonstrate that the saved default configurations match the expected ones after the change, indicating successful configuration.
The PR seems to meet the NuttX requirements, primarily focusing on configuration simplification. However, the following points need attention:
- Build Host details: Specify the OS and compiler used for testing.
- Documentation: If any user-facing documentation exists around
devminorconfiguration, it might require an update. - Clarity on the change: While the linked PR might provide details, a concise explanation in this PR's description about the exact change and its benefits would be helpful for reviewers.
Recommendation:
The PR is likely suitable for submission, pending the clarifications mentioned above.