Skip to content

Instantly share code, notes, and snippets.

@lvreynoso

lvreynoso/uyen_final_project_feedback.md

Created December 17, 2019 03:56
Show Gist options
  • Save lvreynoso/f1dd28d1f8cf2eeeda0deedbfda3e296 to your computer and use it in GitHub Desktop.
Save lvreynoso/f1dd28d1f8cf2eeeda0deedbfda3e296 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
uyen_final_project_feedback.md

Hi Uyen! I've graded your final project and have some feedback for you:

  • good job implementing your Dictogram and Listogram classes and passing all unit tests! had to fix some import statements.
  • good job with your sampling methods in both classes
  • good job implementing a >2nd order Markov chain; code is concise and clear
  • I'm sorry you weren't able to deploy your app to heroku! I was able to deploy your app locally with a few tweaks; I think you just need to generate a new requirements.txt to get it working on heroku.
  • try and add comments that give an overall description of the algorithm you are using or the specific implementation of the data structure; the why and how.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment