Last active
August 29, 2015 14:09
-
-
Save mahadazad/a8c03f564fb60644a8cf to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<?php | |
/** | |
* Compares two strings. | |
* | |
* This method implements a constant-time algorithm to compare strings. | |
* Regardless of the used implementation, it will leak length information. | |
* | |
* @param string $knownString The string of known length to compare against | |
* @param string $userInput The string that the user can control | |
* | |
* @return bool true if the two strings are the same, false otherwise | |
*/ | |
public static function equals($knownString, $userInput) | |
{ | |
$knownString = (string) $knownString; | |
$userInput = (string) $userInput; | |
if (function_exists('hash_equals')) { | |
return hash_equals($knownString, $userInput); | |
} | |
$knownLen = strlen($knownString); | |
$userLen = strlen($userInput); | |
// Extend the known string to avoid uninitialized string offsets | |
$knownString .= $userInput; | |
// Set the result to the difference between the lengths | |
$result = $knownLen - $userLen; | |
// Note that we ALWAYS iterate over the user-supplied length | |
// This is to mitigate leaking length information | |
for ($i = 0; $i < $userLen; $i++) { | |
$result |= (ord($knownString[$i]) ^ ord($userInput[$i])); | |
} | |
// They are only identical strings if $result is exactly 0... | |
return 0 === $result; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment