Skip to content

Instantly share code, notes, and snippets.

View maorfr's full-sized avatar

Maor Friedman maorfr

View GitHub Profile
graph LR
A --> B
B --> A
C --> D
E --> G
hello --> ciao
G --> A
## Culture
### What is your code review thought process?
*Goal*: understand if the candidate is thoughtful and considerate when doing code reviews. Hint: answer should be more than "check the style".
*Follow-ups*:
- Can you tell us a time where you advocated for not merging a patch?
- What do you like to see in commit messages? Why?
package utils
import (
"sync"
)
// BoundedWaitGroup implements a sized WaitGroup
type BoundedWaitGroup struct {
wg sync.WaitGroup
ch chan struct{}
#!/opt/gitlab/embedded/bin/python3
import sys, json, urllib.request, urllib.parse
try:
data = json.load(sys.stdin)
except ValueError:
sys.exit()
if 'object_kind' not in data or 'object_attributes' not in data or data['object_kind'] != 'merge_request':