Has many collection_singular_ids bug

has_many_bug.rb

begin
  require "bundler/inline"
rescue LoadError => e
  $stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler"
  raise e
end

gemfile(true) do
  source "https://rubygems.org"
  # Activate the gem you are reporting the issue against.
  gem "activerecord", "5.1.2"
  gem "sqlite3"
end

require "active_record"
require "minitest/autorun"
require "logger"

# Ensure backward compatibility with Minitest 4
Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)

# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
ActiveRecord::Base.logger = Logger.new(STDOUT)

ActiveRecord::Schema.define do
  create_table :posts, force: true do |t|
  end

  create_table :comments, force: true do |t|
    t.integer :post_id
  end
end

class Post < ActiveRecord::Base
  has_many :comments
end

class Comment < ActiveRecord::Base
  belongs_to :post
end

class BugTest < Minitest::Test
  def test_on_empty_collection
    post = Post.create!
    assert_equal 0, post.comment_ids.count # call to #comment_ids will cache ids inside @association_ids in CollectionAssociation#ids_reader method
    post.comments << Comment.create!
    assert_equal 1, post.comment_ids.count
  end

  def test_on_non_empty_collection
    post = Post.create!
    post.comments << Comment.create!

    assert_equal 1, post.comment_ids.count  # call to #comment_ids will cache ids inside @association_ids in CollectionAssociation#ids_reader method

    post.comments << Comment.create!
    assert_equal 2, post.comment_ids.count
  end
end