Skip to content

Instantly share code, notes, and snippets.

@matthew-dailey
Last active November 30, 2016 15:33
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save matthew-dailey/4e1ab0aac580151dcfd7fbe6beab84dc to your computer and use it in GitHub Desktop.
Save matthew-dailey/4e1ab0aac580151dcfd7fbe6beab84dc to your computer and use it in GitHub Desktop.
Shows using a thread-unsafe Function in a Spark Closure
public JavaDStream<Long> createLongStream(JavaDStream<Object> inputDStream) {
return inputDStream.map(new ThreadUnsafeMapper());
}
private static class ThreadUnsafeMapper implements Function<Object, Long> {
private static final long serialVersionUID = 1L;
private long count = 0;
// definitely not a thread-safe function
@Override
public Long call(Object ignored) throws Exception {
return ++count;
}
}
/*
MIT License
Copyright (c) 2016 Matt Dailey
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
*/
@maasg
Copy link

maasg commented Oct 5, 2016

You certainly need to avoid stateful functions. They don't make sense in a distributed system as closures are serialized and sent to executors to be used. And at each executor, they may be used in parallel (for the number of CPUs assigned to the task at that executor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment