Skip to content

Instantly share code, notes, and snippets.

@matthewharwood
Last active September 9, 2020 14:45
Show Gist options
  • Save matthewharwood/1d400d65ca724d1db242678dc9547281 to your computer and use it in GitHub Desktop.
Save matthewharwood/1d400d65ca724d1db242678dc9547281 to your computer and use it in GitHub Desktop.
Dad's first code review
<!DOCTYPE html>
<!-- this is how you leave comments in .html files -->
<html>
<head>
<title>Hello World</title>
</head> <!-- You missed the closing </head> tag. The browser is smart enough to fix this for you but don't forget. -->
<body>
<h1> wow my head will explode</h1>
<hr/>
<p> This is my first html code that I have ever done. <br/> I hope you like it</p>
<p>I am completely fucking crazy hehehe</p>
<img src="bloddy shades.jpg"height="640"width="480" /> <!-- Try to avoid image paths with spaces -->
</body>
</html>
<!--
1. Use lowercase for file extensions e.g. .html and not .HTML
1a. Favor hyphons or underscores between file names over spaces e.g. hello-world.html vs hello world.html
1b. Use lowercase for file names e.g. hello-world.html vs HELLO-WORLD.html
2. Don't forget a <!DOCTYPE html>. This goes at the first line of your HTML file.
3. Remember that story about embedded vs linked images in powerpoint? The classic: "The Images are on my G:/ drive at home!"
This is the same case with your <img src="bloody shades.jpg" /> that is a path to your file system and therefore I don't have access.
There are a few ways to handle this that you'll learn later but just pointing that out.
3a. Favor hyphons, underscores between file names for image sources e.g. bloddy-shades.jpg
4. Use indent properly when writing code. Later this will be handled automatically for you but it will make good practice for now.
-->
@matthewharwood
Copy link
Author

matthewharwood commented Sep 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment