Skip to content

Instantly share code, notes, and snippets.

@matthewmccullough
Last active September 10, 2021 12:12
Show Gist options
  • Star 2 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save matthewmccullough/7084715 to your computer and use it in GitHub Desktop.
Save matthewmccullough/7084715 to your computer and use it in GitHub Desktop.
Git and GitHub Anti-patterns

Git and GitHub Anti-Patterns

An idea prompted by Jeremy Deane via a Tweet

Committing

  • Lack of precision
  • No care about atomicity
  • Poor commit messages

History

Rebasing

  • Rebased away contributor history (see Government repo where Ben Balter chastises the owner)
  • Incompetently changing history, causing more conflicts
  • No sense of crafting a "story"

Timing

  • Committing once per day or only a few times per week
  • Pushing infrequently and getting massive conflicts that are frustrating to resolve
  • Pushing many laptop-sequestered changes right before integration time
  • Pushing before flight takeoff

CI

  • Too many commits to isolate the change
  • Commits to master instead of feature branches
  • Manual setup of branch builds required

CD

  • Delivered broken build to production
  • No percentage delivery (canary) causing distant rollbacks
  • Multiple branch delivery ruins isolation of problem branch and partial branch delivery

Rollbacks

  • Roll forward
  • Roll backwards
  • Soft reset

Content

  • Size of files
  • Binaries
  • Assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment