Created
January 18, 2024 03:07
-
-
Save matthiasgoergens/1d91a050acb45cf59a4a9784cd11da51 to your computer and use it in GitHub Desktop.
OlaVM warnings
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~/m/p/o/olavm (main)$ git rev-parse HEAD && cargo clean && cargo check | |
d9fc2ff0a465f31dfd90f93dd3e02053818fe0d6 | |
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` | |
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest | |
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest | |
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions | |
Removed 2782 files, 1.7GiB total | |
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` | |
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest | |
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest | |
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions | |
Compiling proc-macro2 v1.0.70 | |
Compiling unicode-ident v1.0.12 | |
Compiling libc v0.2.150 | |
Compiling autocfg v1.1.0 | |
Checking cfg-if v1.0.0 | |
Compiling serde v1.0.193 | |
Compiling version_check v0.9.4 | |
Checking scopeguard v1.2.0 | |
Checking bytes v1.5.0 | |
Checking memchr v2.6.4 | |
Checking once_cell v1.18.0 | |
Checking ppv-lite86 v0.2.17 | |
Compiling typenum v1.17.0 | |
Checking pin-project-lite v0.2.13 | |
Compiling syn v1.0.109 | |
Compiling futures-core v0.3.29 | |
Checking static_assertions v1.1.0 | |
Compiling crunchy v0.2.2 | |
Checking itoa v1.0.9 | |
Compiling parking_lot_core v0.9.9 | |
Checking log v0.4.20 | |
Checking byteorder v1.5.0 | |
Checking smallvec v1.11.2 | |
Compiling thiserror v1.0.50 | |
Checking futures-sink v0.3.29 | |
Compiling pkg-config v0.3.27 | |
Compiling vcpkg v0.2.15 | |
Compiling futures-task v0.3.29 | |
Compiling crossbeam-utils v0.8.16 | |
Compiling futures-channel v0.3.29 | |
Compiling futures-util v0.3.29 | |
Checking hex v0.4.3 | |
Compiling tiny-keccak v2.0.2 | |
Checking bitflags v2.4.1 | |
Checking futures-io v0.3.29 | |
Checking rustc-hex v2.1.0 | |
Compiling lock_api v0.4.11 | |
Compiling num-traits v0.2.17 | |
Compiling slab v0.4.9 | |
Compiling memoffset v0.9.0 | |
Compiling crossbeam-epoch v0.9.15 | |
Checking zerocopy v0.7.26 | |
Checking pin-utils v0.1.0 | |
Compiling num-integer v0.1.45 | |
Checking subtle v2.5.0 | |
Checking fnv v1.0.7 | |
Compiling rayon-core v1.12.0 | |
Compiling ahash v0.8.6 | |
Compiling generic-array v0.14.7 | |
Checking either v1.9.0 | |
Compiling glob v0.3.1 | |
Checking aho-corasick v1.1.2 | |
Compiling openssl v0.10.60 | |
Checking ryu v1.0.15 | |
Compiling prettyplease v0.2.15 | |
Checking foreign-types-shared v0.1.1 | |
Checking regex-syntax v0.8.2 | |
Compiling serde_json v1.0.108 | |
Checking tinyvec_macros v0.1.1 | |
Checking tracing-core v0.1.32 | |
Compiling num-bigint v0.4.4 | |
Compiling minimal-lexical v0.2.1 | |
Compiling native-tls v0.2.11 | |
Compiling httparse v1.8.0 | |
Checking rlp v0.5.2 | |
Compiling libloading v0.7.4 | |
Compiling num-iter v0.1.43 | |
Compiling num-rational v0.4.1 | |
Checking uint v0.9.5 | |
Checking unicode-bidi v0.3.13 | |
Compiling bindgen v0.65.1 | |
Checking equivalent v1.0.1 | |
Checking half v1.8.2 | |
Checking getrandom v0.2.11 | |
Compiling jobserver v0.1.27 | |
Checking mio v0.8.9 | |
Checking socket2 v0.5.5 | |
Checking num_cpus v1.16.0 | |
Compiling quote v1.0.33 | |
Checking signal-hook-registry v1.4.1 | |
Checking http v0.2.11 | |
Checking foreign-types v0.3.2 | |
Checking tinyvec v1.6.0 | |
Compiling clang-sys v1.6.1 | |
Compiling nom v7.1.3 | |
Checking percent-encoding v2.3.1 | |
Checking cpufeatures v0.2.11 | |
Checking openssl-probe v0.1.5 | |
Checking itertools v0.10.5 | |
Checking impl-rlp v0.3.0 | |
Checking tracing v0.1.40 | |
Compiling rustc-hash v1.1.0 | |
Compiling anyhow v1.0.75 | |
Compiling lazy_static v1.4.0 | |
Checking rand_core v0.6.4 | |
Compiling bitflags v1.3.2 | |
Compiling rustix v0.38.25 | |
Checking try-lock v0.2.4 | |
Compiling lazycell v1.3.0 | |
Compiling cc v1.0.83 | |
Checking crypto-common v0.1.6 | |
Checking block-buffer v0.10.4 | |
Checking regex-automata v0.4.3 | |
Compiling syn v2.0.39 | |
Checking httpdate v1.0.3 | |
Checking unicode-normalization v0.1.22 | |
Checking termcolor v1.4.0 | |
Compiling peeking_take_while v0.1.2 | |
Checking crossbeam-deque v0.8.3 | |
Checking form_urlencoded v1.2.1 | |
Compiling shlex v1.2.0 | |
Checking socket2 v0.4.10 | |
Checking fixed-hash v0.7.0 | |
Checking tower-service v0.3.2 | |
Compiling cexpr v0.6.0 | |
Checking linux-raw-sys v0.4.11 | |
Checking rand_chacha v0.3.1 | |
Compiling toml_datetime v0.6.5 | |
Compiling winnow v0.5.19 | |
Checking want v0.3.1 | |
Checking http-body v0.4.5 | |
Checking arrayvec v0.7.4 | |
Checking block-buffer v0.9.0 | |
Checking digest v0.9.0 | |
Checking opaque-debug v0.3.0 | |
Checking mime v0.3.17 | |
Checking keccak v0.1.4 | |
Checking digest v0.10.7 | |
Checking constant_time_eq v0.3.0 | |
Checking arrayref v0.3.7 | |
Checking base64 v0.21.5 | |
Compiling openssl-sys v0.9.96 | |
Checking regex v1.10.2 | |
Compiling secp256k1-sys v0.8.1 | |
Compiling blake3 v1.5.0 | |
Checking idna v0.5.0 | |
Checking headers-core v0.2.0 | |
Checking primitive-types v0.10.1 | |
Checking encoding_rs v0.8.33 | |
Compiling serde_derive v1.0.193 | |
Checking rand v0.8.5 | |
Compiling thiserror-impl v1.0.50 | |
Compiling futures-macro v0.3.29 | |
Compiling tokio-macros v2.2.0 | |
Compiling openssl-macros v0.1.1 | |
Compiling pin-project-internal v1.1.3 | |
Checking base64 v0.13.1 | |
Checking humantime v2.1.0 | |
Checking ipnet v2.9.0 | |
Compiling unroll v0.1.5 | |
Compiling convert_case v0.4.0 | |
Compiling enum-iterator-derive v1.2.1 | |
Checking idna v0.4.0 | |
Checking atty v0.2.14 | |
Checking sha-1 v0.9.8 | |
Compiling indexmap v1.9.3 | |
Checking futures-timer v3.0.2 | |
Compiling bitcoin-internals v0.2.0 | |
Checking fastrand v2.0.1 | |
Checking sha3 v0.10.8 | |
Checking sha1 v0.10.6 | |
Checking blake2 v0.10.6 | |
Compiling secp256k1-sys v0.9.2 | |
Checking os_str_bytes v6.6.1 | |
Checking ciborium-io v0.2.1 | |
Checking keccak-hash v0.8.0 | |
Checking url v2.5.0 | |
Checking hashbrown v0.12.3 | |
Checking plotters-backend v0.3.5 | |
Checking rayon v1.8.0 | |
Checking fixed-hash v0.8.0 | |
Checking num-complex v0.4.4 | |
Checking hex-conservative v0.1.1 | |
Checking same-file v1.0.6 | |
Checking quick-error v1.2.3 | |
Checking cast v0.3.0 | |
Checking enum-iterator v1.4.1 | |
Checking textwrap v0.16.0 | |
Checking clap_lex v0.2.4 | |
Checking ciborium-ll v0.2.1 | |
Checking strsim v0.10.0 | |
Compiling derive_more v0.99.17 | |
Compiling ucd-trie v0.1.6 | |
Compiling node_derive v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/macro/node_derive) | |
Checking headers v0.3.9 | |
Checking oorandom v11.1.3 | |
Checking pin-project v1.1.3 | |
Checking plotters-svg v0.3.5 | |
Checking anes v0.1.6 | |
Compiling heck v0.4.1 | |
Checking walkdir v2.4.0 | |
Checking bitcoin_hashes v0.13.0 | |
Checking criterion-plot v0.5.0 | |
Checking is-terminal v0.4.9 | |
Checking tempfile v3.8.1 | |
Checking humantime v1.3.0 | |
Checking env_logger v0.9.3 | |
Checking sha2 v0.10.8 | |
Checking ripemd v0.1.3 | |
Checking maybe_rayon v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/plonky2/maybe_rayon) | |
Compiling rlp-derive v0.1.0 | |
Compiling hex-literal v0.3.4 | |
Checking plonky2_util v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/plonky2/util) | |
Compiling pest v2.7.5 | |
Checking plotters v0.3.5 | |
Checking futures-executor v0.3.29 | |
Checking clap v3.2.25 | |
Compiling enum-as-inner v0.5.1 | |
Checking num v0.4.1 | |
Checking env_logger v0.10.1 | |
Checking env_logger v0.6.2 | |
Checking futures v0.3.29 | |
Compiling pest_meta v2.7.5 | |
Checking secp256k1 v0.27.0 | |
Checking soketto v0.7.1 | |
Compiling librocksdb-sys v0.11.0+8.1.1 | |
Checking secp256k1 v0.28.1 | |
Compiling pest_generator v2.7.5 | |
Checking hashbrown v0.14.3 | |
Checking impl-serde v0.4.0 | |
Checking plonky2_field v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/plonky2/field) | |
Checking serde_cbor v0.11.2 | |
Checking serde_urlencoded v0.7.1 | |
Checking bincode v1.3.3 | |
Checking ciborium v0.2.1 | |
Compiling pest_derive v2.7.5 | |
Checking indexmap v2.1.0 | |
Checking primitive-types v0.12.2 | |
Checking ethbloom v0.13.0 | |
Checking parking_lot v0.12.1 | |
Checking jsonrpc-core v18.0.0 | |
Checking tinytemplate v1.2.1 | |
Checking criterion v0.4.0 | |
Checking ethereum-types v0.14.1 | |
Checking keccak-hash v0.10.0 | |
Checking tokio v1.34.0 | |
Checking plonky2 v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/plonky2/plonky2) | |
Checking ethabi v18.0.0 | |
Checking eth_trie_utils v0.6.0 | |
Compiling toml_edit v0.19.15 | |
Compiling proc-macro-crate v1.3.1 | |
warning: unused imports: `LookupTableGate`, `LookupTable` | |
--> plonky2/plonky2/src/gadgets/lookup.rs:4:49 | |
| | |
4 | BitwiseLookupTable, BitwiseLookupTableGate, LookupTable, LookupTableGate, | |
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: unused import: `ROUNDS` | |
--> plonky2/plonky2/src/gates/poseidon2.rs:10:41 | |
| | |
10 | use crate::hash::poseidon2::{Poseidon2, ROUNDS, ROUND_F_BEGIN, ROUND_F_END, ROUND_P, WIDTH}; | |
| ^^^^^^ | |
warning: unused import: `std::time::Instant` | |
--> plonky2/plonky2/src/gates/gate_testing.rs:1:5 | |
| | |
1 | use std::time::Instant; | |
| ^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `Extendable` | |
--> plonky2/plonky2/src/hash/blake3.rs:14:32 | |
| | |
14 | use plonky2_field::extension::{Extendable, FieldExtension}; | |
| ^^^^^^^^^^ | |
warning: unused import: `std::borrow::BorrowMut` | |
--> plonky2/plonky2/src/hash/utils.rs:1:5 | |
| | |
1 | use std::borrow::BorrowMut; | |
| ^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `zip_eq` | |
--> plonky2/plonky2/src/iop/witness.rs:3:17 | |
| | |
3 | use itertools::{zip_eq, Itertools}; | |
| ^^^^^^ | |
warning: unused import: `alloc::sync::Arc` | |
--> plonky2/plonky2/src/plonk/circuit_builder.rs:1:5 | |
| | |
1 | use alloc::sync::Arc; | |
| ^^^^^^^^^^^^^^^^ | |
warning: unused imports: `LookupGate`, `Lookup` | |
--> plonky2/plonky2/src/plonk/circuit_builder.rs:24:62 | |
| | |
24 | use crate::gates::lookup::{BitwiseLookup, BitwiseLookupGate, Lookup, LookupGate}; | |
| ^^^^^^ ^^^^^^^^^^ | |
warning: unused import: `LookupTable` | |
--> plonky2/plonky2/src/plonk/circuit_builder.rs:25:54 | |
| | |
25 | use crate::gates::lookup_table::{BitwiseLookupTable, LookupTable}; | |
| ^^^^^^^^^^^ | |
warning: unused import: `Lookup` | |
--> plonky2/plonky2/src/plonk/circuit_data.rs:18:43 | |
| | |
18 | use crate::gates::lookup::{BitwiseLookup, Lookup}; | |
| ^^^^^^ | |
warning: unused import: `LookupGate` | |
--> plonky2/plonky2/src/plonk/prover.rs:18:47 | |
| | |
18 | use crate::gates::lookup::{BitwiseLookupGate, LookupGate}; | |
| ^^^^^^^^^^ | |
warning: unused import: `LookupTableGate` | |
--> plonky2/plonky2/src/plonk/prover.rs:19:58 | |
| | |
19 | use crate::gates::lookup_table::{BitwiseLookupTableGate, LookupTableGate}; | |
| ^^^^^^^^^^^^^^^ | |
warning: unused import: `LookupGate` | |
--> plonky2/plonky2/src/plonk/vanishing_poly.rs:14:47 | |
| | |
14 | use crate::gates::lookup::{BitwiseLookupGate, LookupGate}; | |
| ^^^^^^^^^^ | |
warning: unused import: `LookupTableGate` | |
--> plonky2/plonky2/src/plonk/vanishing_poly.rs:15:58 | |
| | |
15 | use crate::gates::lookup_table::{BitwiseLookupTableGate, LookupTableGate}; | |
| ^^^^^^^^^^^^^^^ | |
Compiling num_enum_derive v0.5.11 | |
Checking tokio-util v0.7.10 | |
Checking tokio-native-tls v0.3.1 | |
Checking tokio-stream v0.1.14 | |
Checking web3-async-native-tls v0.4.0 | |
Checking h2 v0.3.22 | |
Checking num_enum v0.5.11 | |
Checking hyper v0.14.27 | |
Checking hyper-tls v0.5.0 | |
Checking reqwest v0.11.22 | |
Checking web3 v0.19.0 | |
warning: unused import: `Field` | |
--> plonky2/plonky2/src/hash/blake3.rs:15:28 | |
| | |
15 | use plonky2_field::types::{Field, PrimeField64}; | |
| ^^^^^ | |
warning: `plonky2` (lib) generated 15 warnings (run `cargo fix --lib -p plonky2` to apply 14 suggestions) | |
Checking rocksdb v0.21.0 | |
Checking core v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/core) | |
warning: unused import: `PoseidonRow` | |
--> core/src/merkle_tree/patch.rs:5:38 | |
| | |
5 | use crate::trace::trace::{HashTrace, PoseidonRow}; | |
| ^^^^^^^^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: unused import: `crate::trace::trace::PoseidonRow` | |
--> core/src/merkle_tree/tree.rs:8:5 | |
| | |
8 | use crate::trace::trace::PoseidonRow; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `TreeValue` | |
--> core/src/merkle_tree/tree.rs:12:66 | |
| | |
12 | LevelIndex, NodeEntry, TreeKey, TreeMetadata, TreeOperation, TreeValue, ZkHash, | |
| ^^^^^^^^^ | |
warning: unused import: `u8_arr_to_tree_key` | |
--> core/src/state/state_storage.rs:3:53 | |
| | |
3 | use crate::types::merkle_tree::{tree_key_to_u8_arr, u8_arr_to_tree_key, TreeValue}; | |
| ^^^^^^^^^^^^^^^^^^ | |
warning: variable does not need to be mutable | |
--> core/src/state/state_storage.rs:67:13 | |
| | |
67 | let mut res = self.db.get_cf(cf, code_hash); | |
| ----^^^ | |
| | | |
| help: remove this `mut` | |
| | |
= note: `#[warn(unused_mut)]` on by default | |
warning: associated function `all` is never used | |
--> core/src/storage/db.rs:61:8 | |
| | |
60 | impl StateKeeperColumnFamily { | |
| ---------------------------- associated function in this implementation | |
61 | fn all() -> &'static [Self] { | |
| ^^^ | |
| | |
= note: `#[warn(dead_code)]` on by default | |
warning: `core` (lib) generated 6 warnings (run `cargo fix --lib -p core` to apply 5 suggestions) | |
Checking interpreter v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/interpreter) | |
Checking assembler v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/assembler) | |
warning: unused import: `info` | |
--> interpreter/src/interpreter/executor.rs:21:18 | |
| | |
21 | use log::{debug, info}; | |
| ^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: variants `ParseIntError` and `ParseOpcodeError` are never constructed | |
--> assembler/src/error.rs:4:5 | |
| | |
2 | pub enum AssemblerError { | |
| -------------- variants in this enum | |
3 | /// parse string to integer fail | |
4 | ParseIntError, | |
| ^^^^^^^^^^^^^ | |
5 | /// parse integer to opcode fail | |
6 | ParseOpcodeError, | |
| ^^^^^^^^^^^^^^^^ | |
| | |
= note: `AssemblerError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis | |
= note: `#[warn(dead_code)]` on by default | |
warning: call to `.clone()` on a reference in this situation does nothing | |
--> assembler/src/relocate.rs:34:62 | |
| | |
34 | let row_res = AsmRow::from_str(processed_line.clone()); | |
| ^^^^^^^^ help: remove this redundant call | |
| | |
= note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed | |
= note: `#[warn(noop_method_call)]` on by default | |
warning: `assembler` (lib) generated 2 warnings (run `cargo fix --lib -p assembler` to apply 1 suggestion) | |
warning: `interpreter` (lib) generated 1 warning (run `cargo fix --lib -p interpreter` to apply 1 suggestion) | |
Checking executor v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/executor) | |
warning: unused import: `info` | |
--> executor/src/lib.rs:35:18 | |
| | |
35 | use log::{debug, info}; | |
| ^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: unused import: `u8_arr_to_tree_key` | |
--> executor/src/ecdsa.rs:1:52 | |
| | |
1 | use core::types::merkle_tree::{tree_key_to_u8_arr, u8_arr_to_tree_key}; | |
| ^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `TreeKey` | |
--> executor/src/ecdsa.rs:2:32 | |
| | |
2 | use core::types::merkle_tree::{TreeKey, TreeValue}; | |
| ^^^^^^^ | |
warning: unused imports: `BigUint`, `Num` | |
--> executor/src/ecdsa.rs:4:11 | |
| | |
4 | use num::{BigUint, Num}; | |
| ^^^^^^^ ^^^ | |
warning: use of deprecated associated function `secp256k1::Message::from_slice`: use from_digest_slice instead | |
--> executor/src/ecdsa.rs:36:18 | |
| | |
36 | Message::from_slice(&msg_arr).map_err(|e| ProcessorError::MessageInvalid(e.to_string()))?; | |
| ^^^^^^^^^^ | |
| | |
= note: `#[warn(deprecated)]` on by default | |
warning: variable does not need to be mutable | |
--> executor/src/load_tx.rs:73:5 | |
| | |
73 | mut calldata: Vec<GoldilocksField>, | |
| ----^^^^^^^^ | |
| | | |
| help: remove this `mut` | |
| | |
= note: `#[warn(unused_mut)]` on by default | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1819:21 | |
| | |
1819 | let mut data = GoldilocksField::ZERO; | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
= note: `#[warn(unused_assignments)]` on by default | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1820:48 | |
| | |
1820 | memory_op!(self, msg_mem_addr + i, data, Opcode::MSTORE); | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1828:21 | |
| | |
1828 | let mut data = GoldilocksField::ZERO; | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1829:45 | |
| | |
1829 | memory_op!(self, pk_x_addr + i, data, Opcode::MSTORE); | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1837:21 | |
| | |
1837 | let mut data = GoldilocksField::ZERO; | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1838:45 | |
| | |
1838 | memory_op!(self, pk_y_addr + i, data, Opcode::MSTORE); | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1846:21 | |
| | |
1846 | let mut data = GoldilocksField::ZERO; | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1847:46 | |
| | |
1847 | memory_op!(self, sig_r_addr + i, data, Opcode::MSTORE); | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1855:21 | |
| | |
1855 | let mut data = GoldilocksField::ZERO; | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: value assigned to `data` is never read | |
--> executor/src/lib.rs:1856:46 | |
| | |
1856 | memory_op!(self, sig_s_addr + i, data, Opcode::MSTORE); | |
| ^^^^ | |
| | |
= help: maybe it is overwritten before being read? | |
warning: `executor` (lib) generated 16 warnings (run `cargo fix --lib -p executor` to apply 5 suggestions) | |
Checking circuits v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/circuits) | |
Checking zk-vm v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/zk-vm) | |
warning: unused import: `OlaProphet` | |
--> zk-vm/src/lib.rs:8:56 | |
| | |
8 | use ola_core::program::binary_program::{BinaryProgram, OlaProphet}; | |
| ^^^^^^^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: unused import: `ola_core::crypto::hash::Hasher` | |
--> zk-vm/src/lib.rs:26:5 | |
| | |
26 | use ola_core::crypto::hash::Hasher; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `ola_core::types::storage::field_arr_to_u8_arr` | |
--> zk-vm/src/lib.rs:28:5 | |
| | |
28 | use ola_core::types::storage::field_arr_to_u8_arr; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `BTreeMap` | |
--> zk-vm/src/lib.rs:29:24 | |
| | |
29 | use std::collections::{BTreeMap, HashMap}; | |
| ^^^^^^^^ | |
warning: unused import: `Write` | |
--> zk-vm/src/lib.rs:31:26 | |
| | |
31 | use std::io::{BufReader, Write}; | |
| ^^^^^ | |
warning: unused import: `std::ops::Not` | |
--> zk-vm/src/lib.rs:32:5 | |
| | |
32 | use std::ops::Not; | |
| ^^^^^^^^^^^^^ | |
warning: unused import: `core::types::Field` | |
--> circuits/src/builtins/poseidon/poseidon_chunk_stark.rs:289:9 | |
| | |
289 | use core::types::Field; | |
| ^^^^^^^^^^^^^^^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: unused import: `core::types::Field` | |
--> circuits/src/builtins/poseidon/poseidon_stark.rs:184:9 | |
| | |
184 | use core::types::Field; | |
| ^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `std::ops::Range` | |
--> circuits/src/cpu/cpu_stark.rs:18:5 | |
| | |
18 | std::ops::Range, | |
| ^^^^^^^^^^^^^^^ | |
warning: unused imports: `Field`, `GoldilocksField`, `merkle_tree::decode_addr` | |
--> circuits/src/generation/ctl_test/chunk_poseidon.rs:1:19 | |
| | |
1 | use core::types::{merkle_tree::decode_addr, Field, GoldilocksField}; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^^^ | |
warning: unused imports: `builtins::poseidon::columns::*`, `poseidon::generate_poseidon_trace`, `poseidon_chunk::generate_poseidon_chunk_trace`, `prog::generate_prog_chunk_trace`, `program::columns::*` | |
--> circuits/src/generation/ctl_test/chunk_poseidon.rs:4:5 | |
| | |
4 | builtins::poseidon::columns::*, | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
5 | generation::{ | |
6 | poseidon::generate_poseidon_trace, poseidon_chunk::generate_poseidon_chunk_trace, | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
7 | prog::generate_prog_chunk_trace, | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
8 | }, | |
9 | program::columns::*, | |
| ^^^^^^^^^^^^^^^^^^^ | |
warning: unused imports: `get_exec_trace`, `get_rows_vec_from_trace`, `print_title_data` | |
--> circuits/src/generation/ctl_test/chunk_poseidon.rs:12:32 | |
| | |
12 | use super::debug_trace_print::{get_exec_trace, get_rows_vec_from_trace, print_title_data}; | |
| ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ | |
warning: unused imports: `Field`, `GoldilocksField`, `merkle_tree::decode_addr` | |
--> circuits/src/generation/ctl_test/cpu_program.rs:1:19 | |
| | |
1 | use core::types::{merkle_tree::decode_addr, Field, GoldilocksField}; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^^^ | |
warning: unused imports: `cpu::columns::*`, `cpu::generate_cpu_trace`, `prog::generate_prog_trace`, `program::columns::*` | |
--> circuits/src/generation/ctl_test/cpu_program.rs:4:5 | |
| | |
4 | cpu::columns::*, | |
| ^^^^^^^^^^^^^^^ | |
5 | generation::{cpu::generate_cpu_trace, prog::generate_prog_trace}, | |
| ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ | |
6 | program::columns::*, | |
| ^^^^^^^^^^^^^^^^^^^ | |
warning: unused imports: `get_exec_trace`, `get_rows_vec_from_trace`, `print_title_data` | |
--> circuits/src/generation/ctl_test/cpu_program.rs:9:32 | |
| | |
9 | use super::debug_trace_print::{get_exec_trace, get_rows_vec_from_trace, print_title_data}; | |
| ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ | |
warning: unused imports: `get_exec_trace`, `get_rows_vec_from_trace`, `print_title_data` | |
--> circuits/src/generation/ctl_test/cpu_tape.rs:10:32 | |
| | |
10 | use super::debug_trace_print::{get_exec_trace, get_rows_vec_from_trace, print_title_data}; | |
| ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ | |
warning: unused import: `itertools::Itertools` | |
--> circuits/src/generation/ctl_test/poseidon_chunk_mem.rs:1:5 | |
| | |
1 | use itertools::Itertools; | |
| ^^^^^^^^^^^^^^^^^^^^ | |
warning: unused imports: `Field`, `GoldilocksField`, `merkle_tree::decode_addr` | |
--> circuits/src/generation/ctl_test/prog_chunk_program.rs:1:19 | |
| | |
1 | use core::types::{merkle_tree::decode_addr, Field, GoldilocksField}; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^^^^^^^ | |
warning: unused imports: `generate_prog_chunk_trace`, `generate_prog_trace`, `program::columns::*` | |
--> circuits/src/generation/ctl_test/prog_chunk_program.rs:4:24 | |
| | |
4 | generation::prog::{generate_prog_chunk_trace, generate_prog_trace}, | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ | |
5 | program::columns::*, | |
| ^^^^^^^^^^^^^^^^^^^ | |
warning: unused imports: `get_exec_trace`, `get_rows_vec_from_trace`, `print_title_data` | |
--> circuits/src/generation/ctl_test/prog_chunk_program.rs:8:32 | |
| | |
8 | use super::debug_trace_print::{get_exec_trace, get_rows_vec_from_trace, print_title_data}; | |
| ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ | |
warning: unused import: `maybe_rayon::MaybeParIter` | |
--> circuits/src/stark/lookup.rs:4:5 | |
| | |
4 | use maybe_rayon::MaybeParIter; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused imports: `Arc`, `Mutex` | |
--> circuits/src/stark/prover.rs:4:17 | |
| | |
4 | use std::sync::{Arc, Mutex}; | |
| ^^^ ^^^^^ | |
warning: unused import: `std::time::Instant` | |
--> circuits/src/stark/prover.rs:5:5 | |
| | |
5 | use std::time::Instant; | |
| ^^^^^^^^^^^^^^^^^^ | |
warning: unused import: `crate::builtins::rangecheck::rangecheck_stark::RangeCheckStark` | |
--> circuits/src/stark/prover.rs:30:5 | |
| | |
30 | use crate::builtins::rangecheck::rangecheck_stark::RangeCheckStark; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: `zk-vm` (lib) generated 6 warnings (run `cargo fix --lib -p zk-vm` to apply 6 suggestions) | |
warning: unused import: `maybe_rayon::ParallelIterator` | |
--> circuits/src/stark/lookup.rs:13:5 | |
| | |
13 | use maybe_rayon::ParallelIterator; | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused variable: `init_value_heap_ptr` | |
--> circuits/src/memory/memory_stark.rs:117:13 | |
| | |
117 | let init_value_heap_ptr = P::Scalar::from_canonical_u64(INIT_VALUE_HEAP_PTR); | |
| ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_init_value_heap_ptr` | |
| | |
= note: `#[warn(unused_variables)]` on by default | |
warning: function `get_bitwise_col_name_map` is never used | |
--> circuits/src/builtins/bitwise/columns.rs:79:15 | |
| | |
79 | pub(crate) fn get_bitwise_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: `#[warn(dead_code)]` on by default | |
warning: function `get_cmp_col_name_map` is never used | |
--> circuits/src/builtins/cmp/columns.rs:24:15 | |
| | |
24 | pub(crate) fn get_cmp_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^ | |
warning: function `get_storage_access_col_name_map` is never used | |
--> circuits/src/builtins/storage/columns.rs:35:15 | |
| | |
35 | pub(crate) fn get_storage_access_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: function `eval_ext_circuit` is never used | |
--> circuits/src/cpu/call.rs:29:15 | |
| | |
29 | pub(crate) fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `eval_ext_circuit` is never used | |
--> circuits/src/cpu/mload.rs:34:15 | |
| | |
34 | pub(crate) fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `eval_ext_circuit` is never used | |
--> circuits/src/cpu/mov.rs:18:15 | |
| | |
18 | pub(crate) fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `eval_ext_circuit` is never used | |
--> circuits/src/cpu/mstore.rs:35:15 | |
| | |
35 | pub(crate) fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `eval_ext_circuit` is never used | |
--> circuits/src/cpu/ret.rs:29:15 | |
| | |
29 | pub(crate) fn eval_ext_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `print_title_data` is never used | |
--> circuits/src/generation/ctl_test/debug_trace_print.rs:310:8 | |
| | |
310 | pub fn print_title_data( | |
| ^^^^^^^^^^^^^^^^ | |
warning: function `get_memory_col_name_map` is never used | |
--> circuits/src/memory/columns.rs:47:15 | |
| | |
47 | pub(crate) fn get_memory_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: function `get_prog_col_name_map` is never used | |
--> circuits/src/program/columns.rs:18:15 | |
| | |
18 | pub(crate) fn get_prog_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^^ | |
warning: function `get_prog_chunk_col_name_map` is never used | |
--> circuits/src/program/columns.rs:63:15 | |
| | |
63 | pub(crate) fn get_prog_chunk_col_name_map() -> BTreeMap<usize, String> { | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: method `combine_base_circuit` is never used | |
--> circuits/src/stark/permutation.rs:84:19 | |
| | |
73 | impl GrandProductChallenge<Target> { | |
| ---------------------------------- method in this implementation | |
... | |
84 | pub(crate) fn combine_base_circuit<F: RichField + Extendable<D>, const D: usize>( | |
| ^^^^^^^^^^^^^^^^^^^^ | |
warning: function `get_storagehash_extra_looking_products` is never used | |
--> circuits/src/stark/verifier.rs:208:15 | |
| | |
208 | pub(crate) fn get_storagehash_extra_looking_products<F, const D: usize>( | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:87:9 | |
| | |
87 | cpu_tx.send(trace_to_poly_values(cpu_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
= note: `#[warn(unused_must_use)]` on by default | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
87 | let _ = cpu_tx.send(trace_to_poly_values(cpu_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:94:9 | |
| | |
94 | memory_tx.send(trace_to_poly_values(memory_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
94 | let _ = memory_tx.send(trace_to_poly_values(memory_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:102:9 | |
| | |
102 | bitwise_tx.send((trace_to_poly_values(bitwise_rows), bitwise_beta)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
102 | let _ = bitwise_tx.send((trace_to_poly_values(bitwise_rows), bitwise_beta)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:109:9 | |
| | |
109 | cmp_tx.send(trace_to_poly_values(cmp_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
109 | let _ = cmp_tx.send(trace_to_poly_values(cmp_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:116:9 | |
| | |
116 | rc_tx.send(trace_to_poly_values(rc_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
116 | let _ = rc_tx.send(trace_to_poly_values(rc_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:123:9 | |
| | |
123 | poseidon_tx.send(trace_to_poly_values(poseidon_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
123 | let _ = poseidon_tx.send(trace_to_poly_values(poseidon_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:132:9 | |
| | |
132 | poseidon_chunk_tx.send(trace_to_poly_values(poseidon_chunk_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
132 | let _ = poseidon_chunk_tx.send(trace_to_poly_values(poseidon_chunk_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:143:9 | |
| | |
143 | storage_tx.send(trace_to_poly_values(storage_access_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
143 | let _ = storage_tx.send(trace_to_poly_values(storage_access_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:150:9 | |
| | |
150 | tape_tx.send(trace_to_poly_values(tape_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
150 | let _ = tape_tx.send(trace_to_poly_values(tape_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:157:9 | |
| | |
157 | sccall_tx.send(trace_to_poly_values(sccall_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
157 | let _ = sccall_tx.send(trace_to_poly_values(sccall_rows)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:171:9 | |
| | |
171 | program_tx.send((trace_to_poly_values(program_rows), program_beta)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
171 | let _ = program_tx.send((trace_to_poly_values(program_rows), program_beta)); | |
| +++++++ | |
warning: unused `Result` that must be used | |
--> circuits/src/generation/mod.rs:177:9 | |
| | |
177 | prog_chunk_tx.send(trace_to_poly_values(prog_chunk_rows)); | |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |
| | |
= note: this `Result` may be an `Err` variant, which should be handled | |
help: use `let _ = ...` to ignore the resulting value | |
| | |
177 | let _ = prog_chunk_tx.send(trace_to_poly_values(prog_chunk_rows)); | |
| +++++++ | |
warning: `circuits` (lib) generated 46 warnings (run `cargo fix --lib -p circuits` to apply 19 suggestions) | |
Checking client v0.1.0 (/home/matthias/mozak/prog/olavm/olavm/client) | |
warning: unused import: `BTreeMap` | |
--> client/src/main.rs:23:24 | |
| | |
23 | use std::collections::{BTreeMap, HashMap}; | |
| ^^^^^^^^ | |
| | |
= note: `#[warn(unused_imports)]` on by default | |
warning: variable does not need to be mutable | |
--> client/src/main.rs:98:17 | |
| | |
98 | let mut calldata: Vec<_> = reader | |
| ----^^^^^^^^ | |
| | | |
| help: remove this `mut` | |
| | |
= note: `#[warn(unused_mut)]` on by default | |
warning: `client` (bin "ola") generated 2 warnings (run `cargo fix --bin "ola"` to apply 2 suggestions) | |
Finished dev [unoptimized + debuginfo] target(s) in 11.38s | |
~/m/p/o/olavm (main)$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment