Skip to content

Instantly share code, notes, and snippets.

View mattias-p's full-sized avatar
💭
Let there be status

Mattias Päivärinta mattias-p

💭
Let there be status
View GitHub Profile
@mattias-p
mattias-p / CodeReview.md
Last active October 24, 2018 13:47
Checklist for code reviews

Code review

  • Development process: [A checklist for checklists]
  • Document status: Draft
  • Last updated: 2018-10-24

Reviewing

Reliability

Approach

Should the CLI and the Backend (and possibly other applications using the Engine) have a common idea of which profile file is represented by a profile name?

  • Yes. It's helpful for different applications to agree on the meaning of different profile names.

    In this case, the resolution of profile names into profile files should be performed in the Engine. The resolution must be performed without any additional configuration details.

(It is technically possible to let each application provide the Engine with configuration details programmatically,