Skip to content

Instantly share code, notes, and snippets.

@maxsbelt

maxsbelt/PR_TEMPLATE.md

Last active March 10, 2021 12:14
Show Gist options
  • Save maxsbelt/ce2c2bc5aaad1156d390dd24f2fac7a9 to your computer and use it in GitHub Desktop.
Save maxsbelt/ce2c2bc5aaad1156d390dd24f2fac7a9 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
PR_TEMPLATE.md

PR Checklist

  • I've read and followed the Pull Request Checklist
  • I added JIRA ticket ID to my PR title (e.g. [ADAPP-0000]) and linked it into the description
  • My code nicely falls back if we get bad or unexpected data (preventing PANICs)
  • If UI related, I've included screenshots or screencapture of the change.
  • If added/changed translations, I've added [LEXI] tag in PR title and linked translation keys in the description
  • If there are any related PRs to other repos, I've added links on those PRs in corresponded section
  • I have added tests that prove my fix is effective or that my feature works (if needed)
  • I added unique datatest-id for Pedo/Regression (if needed)
  • Self-tested/self QA'd this pull request

Description

Please add a brief description.

How to test

Screenshot / gif walkthrough

Before After
Picture/GIF before Picture/GIF After

Lexi

Related PR(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment