Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save mbroadst/37b81a0370fef807da163b8c1a49b447 to your computer and use it in GitHub Desktop.
Save mbroadst/37b81a0370fef807da163b8c1a49b447 to your computer and use it in GitHub Desktop.
From 859f52eb1ca37c937ed30af0ac6a1fd98fb64618 Mon Sep 17 00:00:00 2001
From: Matt Broadstone <mbroadst@gmail.com>
Date: Mon, 11 Apr 2016 12:08:58 -0400
Subject: [PATCH 5/5] use separate toolsets for v8 while cross compiling
---
mk/support/pkg/v8.sh | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/mk/support/pkg/v8.sh b/mk/support/pkg/v8.sh
index c3dab8c..4105acf 100644
--- a/mk/support/pkg/v8.sh
+++ b/mk/support/pkg/v8.sh
@@ -48,7 +48,7 @@ pkg_install () {
configure_gypflags=
if [[ "$CROSS_COMPILING" = 1 ]]; then
- configure_gypflags=" -Dv8_use_snapshot='false'"
+ configure_gypflags=" -Dwant_separate_host_toolset=1"
fi
pkg_make $arch.$mode CXX="$CXX" LINK="$CXX" LINK.target="$CXX" GYPFLAGS="-Dwerror= $configure_gypflags $arch_gypflags" V=1
@@ -62,8 +62,13 @@ pkg_install () {
pkg_link-flags () {
# These are the necessary libraries recommended by the docs:
# https://developers.google.com/v8/get_started#hello
- for lib in libv8_{base,libbase,snapshot,libplatform}; do
- echo "$install_dir/lib/$lib.a"
+ libs=(base libbase snapshot libplatform)
+ if [[ "$CROSS_COMPILING" = 1 ]]; then
+ libs=(base libbase nosnapshot libplatform)
+ fi
+
+ for lib in ${libs[@]}; do
+ echo "$install_dir/lib/libv8_$lib.a"
done
for lib in libicu{i18n,uc,data}; do
echo "$install_dir/lib/$lib.a"
--
2.3.8 (Apple Git-58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment