Last active
November 19, 2023 14:13
-
-
Save mcsee/23a8649a28ec56db1d0874c1a32b4fc7 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<? | |
final class SocialNetwork { | |
function postStatus(string $newStatus) { | |
$this->assertUserIsLogged(); | |
// ... | |
} | |
function uploadProfilePicture(Picture $newPicture) { | |
$this->assertUserIsLogged(); | |
// ... | |
} | |
function sendMessage(User $recipient, Message $messageSend) { | |
$this->assertUserIsLogged(); | |
// ... | |
} | |
function assertUserIsLogged() { | |
if (!$this->user->isLogged()) { | |
throw new Exception('User is not logged'); | |
// This is just a simplification to show the code smell | |
// Operations should be defined as objects with preconditions | |
// etc. | |
} | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment