Skip to content

Instantly share code, notes, and snippets.

@mfitton

mfitton/necessary_changes.md

Created August 3, 2020 17:06
Show Gist options
  • Save mfitton/418cf5dddaebf906c57f117dcb684257 to your computer and use it in GitHub Desktop.
Save mfitton/418cf5dddaebf906c57f117dcb684257 to your computer and use it in GitHub Desktop.
Download ZIP
Changes we'll still need to make to the new API to enable the existing dashboard UI
Raw
necessary_changes.md

Things we need to add to API

Machine View

We’re missing the cpu_percent calculation for the CPU.tsx feature

We need to add errorCounts for each worker. It looks like currently we only give the count of errors for the whole node and not for each worker.

Same for logCounts

In addition to pulling in the new GPU monitoring code, we will also need to supply the full resource slots rather than a mapping from type of resource to quantity as we do now.

We are missing the rayletInfo field that provided some debugging information on a per-node basis.

Logical View

This needs more help. We basically need to capture all the information that currently exists about actors from the existing rayletStats endpoint in order to be able to run our logical view off the Ant API. I’m going to be switching around things like the naming conventions to camel case, but we will need to add some kind of new /actors endpoint to the new dashboard at some point. I think it might make sense for me to do that once this PR you posted is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment