Skip to content

Instantly share code, notes, and snippets.

@michaelcarter

michaelcarter/gist:42e31149a7debc4390be

Created March 24, 2015 08:45
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save michaelcarter/42e31149a7debc4390be to your computer and use it in GitHub Desktop.
Save michaelcarter/42e31149a7debc4390be to your computer and use it in GitHub Desktop.
Download ZIP
Holiday Extras Pull Request Template
Raw
gistfile1.md

What does this PR do?

What unit or integration tests does this PR have?

What selenium tests does this PR have?

How should a developer review this?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

What gif best describes how you feel about this work?

Quality checklist (for PR author to complete BEFORE code review):

  • I've checked there is appropriate unit test coverage.
  • I've checked there is appropriate selenium test coverage.
  • I've included regression tests for any bug fixes.
  • I've updated documentation with any changes to procedures.
  • I've tested this on mobile Android, Safari, Chrome for any visual changes.
  • I've tested this on desktop IE9/10/11, Firefox, Chrome for any visual changes.
  • I've checked any significant visual changes with a member of the UX/UI pod.
  • I've checked this work against the requirements of the Jira.
  • I've added and updated translations for all supported languages
  • I've informed those who need to know of any unforeseen impact of this work (database migrations, deployment procedure changes).
  • I am ready for this to be code reviewed, merged and tested.
  • I've thought about writing a blog post about this

IP or Developer Review:

  • I agree with the assumptions made in the quality checklist.
  • I’ve witnessed the work behaving as expected.
  • I’ve run all the tests locally and they pass.
  • +1 from me!

Software Engineer or Developer review:

  • I agree with the assumptions made in the quality checklist.
  • I’ve witnessed the work behaving as expected.
  • I’ve run all the tests locally and they pass.
  • I’ve checked for appropriate test coverage.
  • I’ve checked for coding anti-patterns.
  • I've checked this work against the requirements of the Jira.
  • +1 from me!

Software Engineer or project guru review:

  • I agree with the assumptions made in the quality checklist.
  • I’ve witnessed the work behaving as expected.
  • I’ve run all the tests locally and they pass.
  • I’ve checked for appropriate test coverage.
  • I’ve checked for coding anti-patterns.
  • I don’t believe this work introduces unnecessary technical debt.
  • +1 from me!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment