gistfile1.irclog

<nickvergessen> i guess just not requiring it atm
<nickvergessen> is the better solution
<nickvergessen> https://github.com/phpbb/phpbb/pull/2683
<MichaelC> a version of phpbb is a depdency of the extension
<MichaelC> i know about the pr, that's how i found out about it. ;)
<MichaelC> oh alternative?
<MichaelC> hm
<nickvergessen> but we dont want to have vendor/phpbb/phpbb in the ext :/
<MichaelC> we don't have to
<MichaelC> https://github.com/composer/installers/blob/master/src/Composer/Installers/PhpBBInstaller.php
<nickvergessen> well I think the alt is better atm
<nickvergessen> just nto require it
<nickvergessen> until we set it up
<nickvergessen> we can still require it then
<MichaelC> hm... I think the problem you'll have with that is extension authors using events added in say 3.1.2
<MichaelC> it won't be detailed anywhere that 3.2.1 is the minimum requirement
<nickvergessen> well its the same problem atm
<nickvergessen> you can still install it
<MichaelC> At least it is shown on the details page at the moment and in the composer.json?
<MichaelC> It just won't block install
<nickvergessen> well thats why I made the "move to extra"
<nickvergessen> in first place
<MichaelC> yeah
<nickvergessen> so we still display it
<MichaelC> I'd say move to extra OR rename composer.json
<nickvergessen> i dont get the rename composer.json
<MichaelC> personally i think i'd prefer the latter
<nickvergessen> this breaks everything
<nickvergessen> and it will break again, when we want to move forward
<MichaelC> i guess RC is a bit late to do that
<MichaelC> so move to extra I guess
<MichaelC> It is a step backwards but i guess i can see why you want to do it. :/
<MichaelC> Doesn't change the fact we should be adding phpbb/phpbb to packagist for 3.1 gold though
<nickvergessen> i want scrutinizer and stuff
<nickvergessen> :P
<MichaelC> i'll slap nils about that at some point
<nickvergessen> yeah
<MichaelC> nickvergessen: scrutinizer doesn't need composer.json?
<nickvergessen> please post in the PR then
<nickvergessen> if composer.json is there it tries to run it
<MichaelC> ah right
<nickvergessen> and it cant resolve phpbb/phpbb