Skip to content

Instantly share code, notes, and snippets.

@michaeldv
Created February 8, 2012 06:08
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save michaeldv/1765929 to your computer and use it in GitHub Desktop.
Save michaeldv/1765929 to your computer and use it in GitHub Desktop.
# Original
Dir.glob("./commands/*.rb").each do |command|
$commands << command.split("/").last.split('.rb').first
end
# Refactored
Dir.glob("./commands/*.rb").each do |command|
$commands << File.basename(command, '.*')
end
# Orignal
cache = {}
vars.each do |var|
cache[var] = ENV[var]
end
# Refactored
cache = Hash[vars.map { |var| [ var, ENV[var] ] }]
# Original
email = {}
email['example_email_1'] = {}
email['example_email_1']['recipient'] = "postmaster@noname.com"
# Refactored
email = {
'example_email_1' => {
'recipient' => "postmaster@noname.com"
}
}
# Original
content = ""
response.each { |part| content += part }
# Refactored
content = response.join # or response.compact.join
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment