Liang Zheng microyahoo

## rook_pr8426_followup.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              2 stars
            
          
                yuvalif
                / rook_pr8426_followup.md
            
            
              Last active
              January 5, 2023 00:50
            
          
    Goal

This is list TODOs for the bucket notification PR in Rook.
Based on these comments:

rook/rook#8426 (comment)
rook/rook#8426 (review)

Priority 1

Refactoring and Unit Tests


code reuse with reused function (and unit test for above reused function)
use the regular S3 agent for notification provisioning (topic will still need the special SNS client)


## struct_custom_unmarshal.go
package main

import (
	"encoding/json"
	"fmt"
	"log"
	"time"
)

type MyStruct struct {
	package main

	import (
	"encoding/json"
	"fmt"
	"log"
	"time"
	)

	type MyStruct struct {