Skip to content

Instantly share code, notes, and snippets.

@mikedolan03

mikedolan03/portfoliofeedback.md

Last active August 15, 2018 20:55
Show Gist options
  • Save mikedolan03/58df565d746675364086e31fdb1827ed to your computer and use it in GitHub Desktop.
Save mikedolan03/58df565d746675364086e31fdb1827ed to your computer and use it in GitHub Desktop.
Download ZIP
portfolio feedback
Raw
portfoliofeedback.md

Reviewers: Jenny, Brian, Thinkful Slack

Brian

Bugs -

  • app pictures were off center on mobile

Style

  • increase spacing between sections

Content

-likes the content, thought it was good to be a little original

Jenny

Content-

  • spelling effors and comma issues in bio
  • rework bio a little, change phrasing, word choice

UI

  • sun icon looks like a cog for settings - change to something else to make it a little more understandable

Style

  • add colors to some of the text
  • add some space between top buttons

Thinkful

  • add lines and space between projects to seperate them
  • design too simple
  • light / dark mode is cool
  • font could be 'crispier' on dark mode
  • centered font everywhere looks weird.

Changes

-fixed editing mistakes -change sun to a light bulb -added new styles to project screenshots to fix centering issues -adjusted spacing throughout -rewrote some of the text

  • justified most fonts
  • added spacing and a horizontal line between projects
  • modified font so that on dark mode the font is thinner in blocks of text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment