Skip to content

Instantly share code, notes, and snippets.

@mirie
Forked from crittermike/pr_template.md
Last active August 15, 2016 19:17
Show Gist options
  • Save mirie/9d3957601d701320fe35fd4f92bd47c7 to your computer and use it in GitHub Desktop.
Save mirie/9d3957601d701320fe35fd4f92bd47c7 to your computer and use it in GitHub Desktop.
Pull request template

Erase this section when you submit a PR. This is your checklist:

Definition of Done:

  • DID YOU RUN GRUNT VALIDATE?!?!?!
  • Has this passed the Definition of Done/Completeness -- tech approach signoff, screenshot signoff, etc.
  • Has any required automated testing been written/updated?
  • Has the documentation been added/updated?
  • Is there appropriate logging included?
  • Does this add new modules/themes? If so:
    • Has the make file been updated?
    • Has moduleList been updated?
    • Has the install profile's info.yml file been updated?
    • Have you run a test build locally to confirm your new modules/themes get downloaded and enabled properly?
  • Does this add new configuration? If so:
    • Has all the required configuration been added?
    • Have you run a test build locally to confirm that the configuration gets installed correctly?
  • Does this add new Composer dependencies? If so:
    • Has composer.json been updated?
    • Has composer.lock been updated?
  • Have you run a test build locally to confirm that Composer downloads the necessary dependencies successfully?
  • Will this feature require a new piece of infrastructure be implemented? If so:
    • Have you already worked this out with the infrastructure team?
    • Have any infrastructure changes already been built and are ready for the change implemented here?

Addresses Tickets:

URL to ticket:

Overview of work in this PR:

Make file additions or New Custom Module Additions

Database Updates to be Run

Additions/Updates/Deletions of fields, data structures, etc:

Other Configuration Changes

Services/Plugins/Forms

JS Changes

CSS Changes

Other Miscellaneous Changes

Screenshots (if appropriate)

How should this be manually tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment