Created
September 3, 2010 06:09
-
-
Save mitchellh/563487 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From adf9b164eddbfd631d33260671013047eec7a852 Mon Sep 17 00:00:00 2001 | |
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com> | |
Date: Thu, 2 Sep 2010 23:07:54 -0700 | |
Subject: [PATCH] `rake install` properly reports error only when install fails | |
--- | |
lib/bundler/gem_helper.rb | 2 +- | |
1 files changed, 1 insertions(+), 1 deletions(-) | |
diff --git a/lib/bundler/gem_helper.rb b/lib/bundler/gem_helper.rb | |
index 73774ff..00a641c 100644 | |
--- a/lib/bundler/gem_helper.rb | |
+++ b/lib/bundler/gem_helper.rb | |
@@ -52,7 +52,7 @@ module Bundler | |
def install_gem | |
built_gem_path = build_gem | |
out, err, code = sh_with_code("gem install #{built_gem_path}") | |
- raise err if err[/ERROR/] | |
+ raise err if !out[/Successfully/] | |
Bundler.ui.confirm "#{name} (#{version}) installed" | |
end | |
-- | |
1.7.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment