Created
January 12, 2017 03:01
-
-
Save mpchadwick/ab6a6986afcdbde0edb207fa87ef3ea4 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Break large features up into multiple commits | |
- Don't submit a massive PR | |
- Link to PRs where code has previously been reviewed | |
- Write good commit messages | |
- Make sure the site isn't broken in any of your commits | |
- Avoid reformatting | |
- Write a good comment when submitting your PR | |
- Include screenshots for significant front end changes | |
- Don't Involve Multiple Reviewers | |
- Don't Submit Net New Code After Changes Have Been Requested On A Reviewed PR | |
- Don't copy / paste a block, model (etc) rewrite and change it in the same commit (Magento specific) | |
- Include the module version number in your commit message when installing a module (Magento specific) | |
- Don't copy / paste a template and change it in the same commit (Magento specific) | |
- Don't install an extension and customize it in the same PR (Magento specific) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment