Is this a good page object using playwright and typescript?

loginPage.ts

export class LoginPage {
  readonly page: Page;
  readonly userNameTextbox: Locator
  readonly passwordTextbox: Locator
  readonly loginBtn: Locator

  // Clarity over duplication removal
  // Don't start with the abstraction
  constructor(page: Page) {
    this.page = page;
    this.userNameLocator = { name: 'Username' };
    // this.userNameTextbox = page.getByRole('textbox', { name: 'Username' })
    this.passwordTextbox = page.getByRole('textbox', { name: 'Password' })
    this.loginBtn = page.getByRole('button', { name: 'Log In' })
  }

  async setUsername(txt: string): Promise<void> {
    await page.getByRole('textbox', this.userNameLocator).click()
    await this.userNameTextbox.type(txt)
  }

  // prefer not to do this as it allows a low-level interaction in the tests
  async inputPasswordTextbox(txt: string): Promise<void> {
    await this.passwordTextbox.click()
    await this.passwordTextbox.type(txt)
  }
  
  // don't mix with API
  async login(username: string, password: string): Promise<void> {
    await page.getByRole('textbox', this.userNameLocator).click()
    await this.userNameTextbox.type(username)
    await this.passwordTextbox.click()
    await this.passwordTextbox.type(password)
  }
  
  async loginSuccessfully(username: string, password: string): Promise<void> {
    await login(username, password);
    // can now throw a custom exception
  }
}