Flawed automated playwright tests

playwright.spec.ts

  test('Dashboard page should not have any WCAG A violations', async ({ page }) => {
    const authentication = new Authentication(page);
    const loginPage = new LoginPage(page);
    const dashboardPage = new DashboardPage(page);
    await loginPage.login(user)
    // Wait until the logo is visible - default 30000
    await dashboardPage.waitForLogo()

    await page.getByRole('button', { name: 'Log In' }).click();
    await authentication.loginWith2FA(user)

    await expect(loginPage.isErrorPresent()).toBeTruthy();
    await expect(loginPage.invalidUsernameIcon.toBeVisible()).toBeTruthy();
    
//    await expect(page.locator('#invalid-username-icon')).toBeVisible()
//    await expect(page.locator('#invalid-password-icon')).toBeVisible()
    
    // better approach
    await expect(dashboardPage.toBeLoaded());

    // bad approach
    // await page.waitForSelector(dashboardPage.logoTxt, {timeout: 30000});
    expect(await dashboardPage.getViolationsWithTags(tags)).toEqual([]);
  });

  test('Login with valid data', async ({page}) => {
    const loginPage = new LoginPage(page);
    const authentication = new Authentication(page);
    const dashboardPage = new DashboardPage(page);

    await loginPage.login(user)
    await authentication.loginWith2FA(user)

    expect(dashboardPage.isLogoVisible()).toBeTruthy();
  });