Skip to content

Instantly share code, notes, and snippets.

@naps62
Last active November 6, 2016 14:44
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save naps62/c21755b81b52dc2b7ce273c350b5a508 to your computer and use it in GitHub Desktop.
Save naps62/c21755b81b52dc2b7ce273c350b5a508 to your computer and use it in GitHub Desktop.
Feedback from my current experience with the new Github Reviews feature

Overall, I like the path where this is headed, but I have some big concerns with the current functionality. here's a quick list:

There's no easy & quick way for me to tell what's left for me to review

See the screenshot below, taken a couple of days ago:

Pull Requests

This is a list of open PRs on a client project. Some were already reviewed by me, other's weren't. For the ones I haven't reviewed, the green check mark also shows up, because our CI was green. There was no way for me to tell which ones I still haven't reviewed without opening each one individually.

Possible solutions for this would be to have an additional icon for the review approval (i.e. having two check marks, or a different icon), or just being able to filter by projects that are not yet reviewed and/or failed review.

I often forget to submit a review

I'm too used to just leaving comments. Now I have to submit the entire review after writing them, which I often forget to do, leaving those comments hanging and the other person not being notified.

It would helpful to be reminded of this. For example, adding comments could trigger a detection of Unsaved Changes, so that if I later try to close the tab, the browser would remind me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment