Skip to content

Instantly share code, notes, and snippets.

@nati
Created February 8, 2016 17:49
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nati/b269bbd0258c8a41415c to your computer and use it in GitHub Desktop.
Save nati/b269bbd0258c8a41415c to your computer and use it in GitHub Desktop.
nueno-mbp:contrail-go-api[list_mock]$ go get -u github.com/golang/lint/golint
nueno-mbp:contrail-go-api[list_mock]$ golint
client.go:36:6: exported type Authenticator should have comment or be unexported
client.go:40:6: exported type NopAuthenticator should have comment or be unexported
client.go:43:1: exported method NopAuthenticator.AddAuthentication should have comment or be unexported
client.go:48:6: type ApiClient should be APIClient
client.go:58:32: don't use underscores in Go names; interface method parameter parent_id should be parentID
client.go:60:38: don't use underscores in Go names; interface method parameter parent_id should be parentID
client.go:63:1: comment on exported type Client should be of the form "Client ..." (with optional leading article)
client.go:71:1: comment on exported type ListResult should be of the form "ListResult ..." (with optional leading article)
client.go:73:2: don't use underscores in Go names; struct field Fq_name should be FqName
client.go:75:2: struct field Uuid should be UUID
client.go:82:1: comment on exported function NewClient should be of the form "NewClient ..."
client.go:95:1: exported method Client.GetServer should have comment or be unexported
client.go:99:1: exported method Client.SetAuthenticator should have comment or be unexported
client.go:119:1: receiver name c should be consistent with previous receiver name client for Client
client.go:133:1: receiver name c should be consistent with previous receiver name client for Client
client.go:147:1: receiver name c should be consistent with previous receiver name client for Client
client.go:159:1: receiver name c should be consistent with previous receiver name client for Client
client.go:174:1: receiver name c should be consistent with previous receiver name client for Client
client.go:178:2: var objJson should be objJSON
client.go:183:6: var rawJson should be rawJSON
client.go:218:1: receiver name c should be consistent with previous receiver name client for Client
client.go:246:12: should omit type reflect.Type from declaration of var xtype; it will be inferred from the right-hand side
client.go:257:1: comment on exported method Client.ReadListResult should be of the form "ReadListResult ..."
client.go:258:1: receiver name c should be consistent with previous receiver name client for Client
client.go:263:1: comment on exported method Client.ReadReference should be of the form "ReadReference ..."
client.go:264:1: receiver name c should be consistent with previous receiver name client for Client
client.go:276:1: receiver name c should be consistent with previous receiver name client for Client
client.go:277:2: var objJson should be objJSON
client.go:281:6: var rawJson should be rawJSON
client.go:314:1: exported method Client.DeleteByUuid should have comment or be unexported
client.go:314:1: receiver name c should be consistent with previous receiver name client for Client
client.go:314:18: method DeleteByUuid should be DeleteByUUID
client.go:335:1: receiver name c should be consistent with previous receiver name client for Client
client.go:353:1: comment on exported method Client.FindByUuid should be of the form "FindByUuid ..."
client.go:354:1: receiver name c should be consistent with previous receiver name client for Client
client.go:354:18: method FindByUuid should be FindByUUID
client.go:360:1: exported method Client.UuidByName should have comment or be unexported
client.go:360:1: receiver name c should be consistent with previous receiver name client for Client
client.go:360:18: method UuidByName should be UUIDByName
client.go:364:3: don't use underscores in Go names; struct field Fq_name should be FqName
client.go:388:3: struct field Uuid should be UUID
client.go:398:1: exported method Client.FQNameByUuid should have comment or be unexported
client.go:398:1: receiver name c should be consistent with previous receiver name client for Client
client.go:398:18: method FQNameByUuid should be FQNameByUUID
client.go:400:3: struct field Uuid should be UUID
client.go:426:3: don't use underscores in Go names; struct field Fq_name should be FqName
client.go:432:1: comment on exported method Client.FindByName should be of the form "FindByName ..."
client.go:434:1: receiver name c should be consistent with previous receiver name client for Client
client.go:444:1: comment on exported method Client.ListByParent should be of the form "ListByParent ..."
client.go:445:1: receiver name c should be consistent with previous receiver name client for Client
client.go:446:19: don't use underscores in Go names; method parameter parent_id should be parentID
client.go:487:1: exported method Client.List should have comment or be unexported
client.go:487:1: receiver name c should be consistent with previous receiver name client for Client
client.go:491:1: exported method Client.ListDetailByParent should have comment or be unexported
client.go:491:1: receiver name c should be consistent with previous receiver name client for Client
client.go:492:19: don't use underscores in Go names; method parameter parent_id should be parentID
client.go:539:12: should omit type reflect.Type from declaration of var xtype; it will be inferred from the right-hand side
client.go:566:1: exported method Client.ListDetail should have comment or be unexported
client.go:566:1: receiver name c should be consistent with previous receiver name client for Client
client.go:571:1: comment on exported method Client.GetField should be of the form "GetField ..."
client.go:572:1: receiver name c should be consistent with previous receiver name client for Client
client.go:599:1: comment on exported method Client.UpdateReference should be of the form "UpdateReference ..."
client.go:600:1: receiver name c should be consistent with previous receiver name client for Client
client.go:623:1: exported function RegisterTypeMap should have comment or be unexported
keystone.go:15:6: exported type KeystoneClient should have comment or be unexported
keystone.go:16:2: don't use underscores in Go names; struct field os_auth_url should be osAuthURL
keystone.go:17:2: don't use underscores in Go names; struct field os_tenant_name should be osTenantName
keystone.go:18:2: don't use underscores in Go names; struct field os_username should be osUsername
keystone.go:19:2: don't use underscores in Go names; struct field os_password should be osPassword
keystone.go:20:2: don't use underscores in Go names; struct field os_token should be osToken
keystone.go:25:1: comment on exported type KeystoneToken should be of the form "KeystoneToken ..." (with optional leading article)
keystone.go:27:2: struct field Id should be ID
keystone.go:30:3: struct field Id should be ID
keystone.go:35:2: don't use underscores in Go names; struct field Issued_At should be IssuedAt
keystone.go:38:1: exported function NewKeystoneClient should have comment or be unexported
keystone.go:38:24: don't use underscores in Go names; func parameter auth_url should be authURL
keystone.go:38:34: don't use underscores in Go names; func parameter tenant_name should be tenantName
keystone.go:49:1: comment on exported method KeystoneClient.Authenticate should be of the form "Authenticate ..."
keystone.go:55:5: struct field Id should be ID
keystone.go:74:5: struct field Id should be ID
keystone.go:134:1: comment on exported method KeystoneClient.AddAuthentication should be of the form "AddAuthentication ..."
object.go:16:1: comment on exported type IObject should be of the form "IObject ..." (with optional leading article)
object.go:38:2: don't use underscores in Go names; struct field fq_name should be fqName
object.go:42:2: don't use underscores in Go names; struct field parent_href should be parentHref
object.go:43:2: don't use underscores in Go names; struct field parent_type should be parentType
object.go:44:2: don't use underscores in Go names; struct field parent_uuid should be parentUUID
object.go:52:1: comment on exported method ObjectBase.VSetName should be of the form "VSetName ..."
object.go:74:1: exported method ObjectBase.VSetParent should have comment or be unexported
object.go:81:1: comment on exported method ObjectBase.GetName should be of the form "GetName ..."
object.go:86:1: comment on exported method ObjectBase.GetUuid should be of the form "GetUuid ..."
object.go:87:24: method GetUuid should be GetUUID
object.go:91:1: comment on exported method ObjectBase.SetUuid should be of the form "SetUuid ..."
object.go:92:24: method SetUuid should be SetUUID
object.go:99:1: comment on exported method ObjectBase.GetHref should be of the form "GetHref ..."
object.go:104:1: comment on exported method ObjectBase.SetFQName should be of the form "SetFQName ..."
object.go:111:1: exported method ObjectBase.GetFQName should have comment or be unexported
object.go:115:1: exported method ObjectBase.GetParentType should have comment or be unexported
object.go:119:1: exported method ObjectBase.SetClient should have comment or be unexported
object.go:123:1: exported method ObjectBase.IsTransient should have comment or be unexported
object.go:127:1: exported method ObjectBase.GetField should have comment or be unexported
object.go:131:1: exported method ObjectBase.UnmarshalCommon should have comment or be unexported
object.go:163:1: comment on exported method ObjectBase.MarshalId should be of the form "MarshalId ..."
object.go:164:24: method MarshalId should be MarshalID
object.go:184:1: comment on exported method ObjectBase.MarshalCommon should be of the form "MarshalCommon ..."
object.go:210:6: type referenceUuidSorter should be referenceUUIDSorter
object.go:259:1: comment on exported method ObjectBase.UpdateReference should be of the form "UpdateReference ..."
object_test.go:164:3: should replace t.Error(fmt.Sprintf(...)) with t.Errorf(...)
object_test.go:229:3: should replace t.Error(fmt.Sprintf(...)) with t.Errorf(...)
reference.go:7:6: exported type LinkAttribute should have comment or be unexported
reference.go:14:2: struct field Uuid should be UUID
reference.go:19:6: exported type ReferenceList should have comment or be unexported
reference.go:21:6: exported type ReferencePair should have comment or be unexported
reference.go:26:1: comment on exported type ReferenceUpdateMsg should be of the form "ReferenceUpdateMsg ..." (with optional leading article)
reference.go:31:2: struct field Uuid should be UUID
reference.go:35:2: struct field RefUuid should be RefUUID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment