naudo/n_plus_one_bad.html.erb

Created August 13, 2012 00:05

Star () You must be signed in to star a gist
Fork () You must be signed in to fork a gist

Learn more about clone URLs
Clone this repository at <script src="https://gist.github.com/naudo/3335597.js"></script>
Save naudo/3335597 to your computer and use it in GitHub Desktop.

Download ZIP

A simple view to show how easy writing n + 1 queries really is.

Raw

n_plus_one_bad.html.erb

	<% User.all.each do \|user\| %>
	<p> <%= user.name %> </p>
	<ul>
	<% user.pets.each do \|pet\| %>
	<li> <%= pet.name %> </li>
	<% end %>
	</ul>
	<% end %>

statianzo commented Aug 13, 2012

Not to mention, User.all is unwise. While it doesn't ever seem slow when you're in development, it's certainly a ticking time bomb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment