-
-
Save ndwade/6621018 to your computer and use it in GitHub Desktop.
package scratch | |
// scalatest 2.0.M8 | |
import org.scalatest.WordSpec | |
import org.scalatest.matchers.ShouldMatchers | |
import org.scalatest.concurrent.AsyncAssertions | |
import org.scalatest.time.{ Span, Millis } | |
class WaiterSpec extends WordSpec with ShouldMatchers with AsyncAssertions { | |
"A Waiter instance" should { | |
"not break when beaten on" in { | |
val n = 100000 | |
val w = new Waiter | |
new Thread(new Runnable { | |
override def run(): Unit = { | |
var i = 0 | |
while (i < n) { w.dismiss(); i += 1 } | |
println(s"i=$i") | |
} | |
}).start | |
w.await(timeout(Span(2000, Millis)), dismissals(n)) | |
} | |
} | |
} |
Sorry it took me a while to get enough focused time to study this. I think your reasoning makes sense. Can you submit a pull request?
Also we have added instructions on building ScalaTest to the scalatest.org site and the github project. With the advent of Scala 2.10.3 it has become much easier (because of a memory-leak fix in the Scala compiler that affected ScalaTest badly). Previously I couldn't build it with sbt on my laptop with 8Gb (though I could with ant)! Now the sbt build works fine in much less memory, so I'd recommend using that instead of ant now. We also as of this morning made a tweak that enables ScalaTest to be built on JDK 7 as well as JDK6. The problem was that some Swing classes, which were raw in JDK6, were generified in JDK7. We had to use code gen to deal with that, but that was another thing that made ScalaTest hard to build.
Thanks.
Bill
Huzzah! Scalatest built and tests ran ok. Instructions were a big help. (Yeah I'd discovered the memory and JDK-7 issues.)
Now working on integrating my fix.
OK, pull request made. Happy to iterate if necessary.
Having some trouble building scalatest on my machine. I hacked up a version with the patches below and compiled it outside of scalatest in a different package, and it passes the WaiterSpec posted above, and works great for testing my code.
I pushed it to my fork of the scalatest repo in the waiter-race-fix2 branch, if you want to look at the whole file. Obviously won't do a pull request until I get scalatest building ok.
Reference: Java Concurrency in Practice, chapter 14, first few sections.