Skip to content

Instantly share code, notes, and snippets.

@neheb
Created May 31, 2018 23:36
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save neheb/d647e0e453e2fa5390108b2fc6c2f420 to your computer and use it in GitHub Desktop.
Save neheb/d647e0e453e2fa5390108b2fc6c2f420 to your computer and use it in GitHub Desktop.
From e1369e9d897218d23cbb77533e857c0ce84122c0 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Thu, 31 May 2018 16:25:58 -0700
Subject: [PATCH 1/2] ramips: mt7621: fix pcie related warnings in mt7621.dtsi
List of warnings:
Node /pcie@1e140000/pcie0 node name is not "pci" or "pcie"
Node /pcie@1e140000/pcie0 missing ranges for PCI bridge (or not a bridge)
Node /pcie@1e140000/pcie0 missing bus-range for PCI bridge
Node /pcie@1e140000/pcie1 node name is not "pci" or "pcie"
Node /pcie@1e140000/pcie1 missing ranges for PCI bridge (or not a bridge)
Node /pcie@1e140000/pcie1 missing bus-range for PCI bridge
Node /pcie@1e140000/pcie2 node name is not "pci" or "pcie"
Node /pcie@1e140000/pcie2 missing ranges for PCI bridge (or not a bridge)
Node /pcie@1e140000/pcie2 missing bus-range for PCI bridge
Warning (unit_address_format): Failed prerequisite 'pci_bridge'
Warning (pci_device_reg): Failed prerequisite 'pci_bridge'
Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge'
v2: This now also fixes some weird issue where the IRQs for the pcie ports
were offset by 1. The end result is that dmesg errors with
[ 2.176977] pci 0000:00:00.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[ 2.193140] pci 0000:00:01.0: bridge configuration invalid ([bus 00-00]), reconfiguring
[ 2.209383] pci 0000:00:02.0: bridge configuration invalid ([bus 00-00]), reconfiguring
While the dtsi file is misconfigured, this should hopefully fix issues with
mt76 not working.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
target/linux/ramips/dts/mt7621.dtsi | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/target/linux/ramips/dts/mt7621.dtsi b/target/linux/ramips/dts/mt7621.dtsi
index 5de7fd86cd..1bdced6870 100644
--- a/target/linux/ramips/dts/mt7621.dtsi
+++ b/target/linux/ramips/dts/mt7621.dtsi
@@ -463,30 +463,36 @@
clocks = <&clkctrl 24 &clkctrl 25 &clkctrl 26>;
clock-names = "pcie0", "pcie1", "pcie2";
- pcie0 {
+ pcie0: pcie@0,0 {
reg = <0x0000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
+ range;
+ bus-range = <0x00 0xff>;
device_type = "pci";
};
- pcie1 {
+ pcie1: pcie@1,0 {
reg = <0x0800 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
+ range;
+ bus-range = <0x00 0xff>;
device_type = "pci";
};
- pcie2 {
+ pcie2: pcie@2,0 {
reg = <0x1000 0 0 0 0>;
#address-cells = <3>;
#size-cells = <2>;
+ range;
+ bus-range = <0x00 0xff>;
device_type = "pci";
};
};
--
2.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment