Skip to content

Instantly share code, notes, and snippets.

@nelsonpecora
Created January 23, 2018 17:25
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nelsonpecora/5d0df3a9f60d6cd160812e7bb26e1603 to your computer and use it in GitHub Desktop.
Save nelsonpecora/5d0df3a9f60d6cd160812e7bb26e1603 to your computer and use it in GitHub Desktop.
Possible roadmap to amphora updates
  1. page history / pass user to plugins (for specific page updates)
  2. break out amphora-fs plugin
  3. break out amphora-memoization plugin
  4. deprecate lists
    • autocomplete → elasticsearch
    • new page templates api
  5. nginx / kong
  6. streams!
  7. break out amphora-scheduling plugin
  8. break out amphora-webhooks plugin
  9. renderers terminate request
    • amphora v5.x
    • resolveMedia → renderers
    • streaming renderers
    • remove scheduler
    • remove webhooks
    • remove auth, sessions, route WAF (nginx)
@jonwinton
Copy link

Number 2 doesn't seem necessary. Let the packages decide for themselves how to memoize. Amphora just uses lodash's function

@jonwinton
Copy link

Number 6 can be done piecemeal, focusing on utility functions first and then just calling .toPromise on them. Maybe we could but down sections of the codebase in the same way we handled model.js conversions: Pick a route, pick an action (save, render, etc) and then make it's handler be streamed up until the very last possible point.

@jonwinton
Copy link

Webhooks and scheduling would be breaking changes, so that would be v5.x as well.

@jonwinton
Copy link

Last thing: we still need to underscore routes and update all the appropriate packages/services/provide a DB transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment