Skip to content

Instantly share code, notes, and snippets.

@nickb-minted

nickb-minted/manage_sla_todo.md

Last active April 9, 2016 01:28
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nickb-minted/cf6d6ed7e1b788f13df33b9403504a6e to your computer and use it in GitHub Desktop.
Save nickb-minted/cf6d6ed7e1b788f13df33b9403504a6e to your computer and use it in GitHub Desktop.
Download ZIP
Raw
manage_sla_todo.md

TODO

Phase 1

  • Modify/Merge in PR with logging https://github.com/minted/minted/pull/10061
  • Test end to end to make sure logging is working. You can call the cron manually on vagrant and check that logs are working
  • Refactor the logic to do upgrades from Standard and Fast classes and move them to parent class (SLAManager)
  • Change the definition of def get_fulfiller_id(self): so that it just returns self.po.minted_fulfiller_id. No query required
  • Add the cron definition in puppet
Commits to patch

List of commits to patch

Phase 1.5

  • Create table for upgrade shipping log
  • Add code to insert into table - International | Standard | Fast - see tech design upgrade shipment method
  • Get data from Rich for Average Base Transit Time
  • write a migration for the fulfiller pickup times - ask Grace (printer roll out doc)
  • Write migration for data from Rich
  • Write migration for supply chain ranking

Phase 2

Notes

  • Home delivery is currently disabled right now. That means that it will not be eligible to be selected in the subset of shipping values that will come back based on the new transit time
  • More logging needs to be added to the cron. I think that it is best to maybe define a logger in the cron and pass that a long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment