Skip to content

Instantly share code, notes, and snippets.

@nielk

nielk/Code-review-checklist.MD

Last active May 24, 2017 13:22
Show Gist options
  • Save nielk/1e3a1a25be48b8e8c00b6361e3213ddd to your computer and use it in GitHub Desktop.
Save nielk/1e3a1a25be48b8e8c00b6361e3213ddd to your computer and use it in GitHub Desktop.
Download ZIP
Raw
Code-review-checklist.MD

Description

Related PRs

Quality checklist

Code

  • Tests has been added to cover my changes.
  • All new and existing tests passed (npm run test).
  • Handle NULL And Empty Object Scenarios.
  • Code is commented where appropriate.
  • Keep the global scope clean.
  • Code handle exception properly.
  • Dead code has been deleted.
  • All new strings has been translated.

Archi

  • Keep components as independent as possible.
  • Do not data formating into controller, instead use services.

Miscs

  • The release note has been updated.
  • Work correctly in supported browsers.

Steps to Test or Reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment