Glusto skip

random_test.py

import pytest
from glusto.core import Glusto as g
from glustolibs.gluster.gluster_base_class import GlusterBaseClass, runs_on


@runs_on([['distributed-replicated', 'replicated', 'distributed',                                                                                                                                              
           'dispersed', 'distributed-dispersed'],                                                                                                                                                              
          ['glusterfs', 'cifs', 'nfs']])
class MySampleTest(GlusterBaseClass):
    
    def my_test(self):
        if g.config.get('test_env', 'upstream').lower() == 'upstream' and self.volume_type = 'cifs':
            pytest.skip('SKIPPED. Bug #123456')
        # do whatever
        pass

It's been awhile since I tested, but if a decorator on the class method has access to the class attributes created by runs_on at this point, would using the skip decorator(s) be cleaner?