Skip to content

Instantly share code, notes, and snippets.

@nirnaeth

nirnaeth/code-review-checklist.md

Forked from haacked/code-review-checklist.md
Created April 28, 2014 09:46
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nirnaeth/11367054 to your computer and use it in GitHub Desktop.
Save nirnaeth/11367054 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
code-review-checklist.md

General

  1. Unit tests: Review unit tests first. Unit tests are a fantastic way to grasp how code is meant to be used by others and to learn what the expected behavior is. Are there any test gaps that should be there?
  2. Method arguments" Make sure arguments to methods make sense and are validated.
  3. Null References" (Yah yah, we know. Use F# and this goes away. We get it already.) Null references are a bitch and it’s worth looking out for them specifically.
  4. Conventions Consistency" Make sure naming, formatting, etc. follow our conventions and are consistent. I like a codebase that’s fairly consistent so you know what to expect.
  5. Disposables: Make sure disposable things are disposed. Look for usages of resources that should be disposed but are not.
  6. Security: There is a whole threat and mitigation review process that falls under this bucket.

WPF + ReactiveUI

  1. Updating UI: Make sure view model properties are updated on the main scheduler (UI thread). This is because we bind the UI to these properties and the UI can only be updated on the UI thread.
  2. ObserveOn: When kicking off truly async operations, make sure we ObserveOn(RxApp.DeferredScheduler) soon after (related to previous).
  3. Over subscriptions: Make sure we're not over subscribing to deferred observables etc that could lead to multiple operations.
  4. ???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment