Last active
March 2, 2019 05:03
-
-
Save nkreeger/a403b5b7d6b27fc7020ea0a33c4108d3 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/libANGLE/Framebuffer.cpp b/src/libANGLE/Framebuffer.cpp | |
index f3f9bfc36..482d0c396 100644 | |
--- a/src/libANGLE/Framebuffer.cpp | |
+++ b/src/libANGLE/Framebuffer.cpp | |
@@ -73,7 +73,9 @@ bool CheckAttachmentCompleteness(const Context *context, const FramebufferAttach | |
if (!attachment.isRenderable(context)) | |
{ | |
- return false; | |
+ // TODO(kreeger): Actually fix this at some point. | |
+ return true; | |
+ /* return false; */ | |
} | |
if (attachment.type() == GL_TEXTURE) | |
diff --git a/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp b/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp | |
index fe0d70a6a..3cb9c5528 100644 | |
--- a/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp | |
+++ b/src/libANGLE/renderer/gl/glx/DisplayGLX.cpp | |
@@ -277,6 +277,9 @@ egl::Error DisplayGLX::initialize(egl::Display *display) | |
// it has problems on our automated testing. An OpenGL ES backend might not trigger this test if | |
// there is no Desktop OpenGL support, but that's not the case in our automated testing. | |
VendorID vendor = GetVendorID(functionsGL.get()); | |
+ // | |
+ // TODO(kreeger): Rpi here does not actually report isOpenGLES !!! | |
+ // | |
bool isOpenGLES = | |
eglAttributes.get(EGL_PLATFORM_ANGLE_TYPE_ANGLE, EGL_PLATFORM_ANGLE_TYPE_DEFAULT_ANGLE) == | |
EGL_PLATFORM_ANGLE_TYPE_OPENGLES_ANGLE; | |
diff --git a/src/libANGLE/renderer/gl/renderergl_utils.cpp b/src/libANGLE/renderer/gl/renderergl_utils.cpp | |
index 23c78066a..00f411b8f 100644 | |
--- a/src/libANGLE/renderer/gl/renderergl_utils.cpp | |
+++ b/src/libANGLE/renderer/gl/renderergl_utils.cpp | |
@@ -225,6 +225,22 @@ static gl::TextureCaps GenerateTextureFormatCaps(const FunctionsGL *functions, | |
// if the format is supported unless we try to create a framebuffer. | |
if (internalFormat == GL_RGBA16F) | |
{ | |
+ /* fprintf(stderr, "---> GL_RGBA16F: texturable: %s\n", */ | |
+ /* textureCaps.texturable ? "true" : "false"); */ | |
+ nativegl::GetInternalFormatInfo(internalFormat, | |
+ functions->standard); // XXX what is `standard`? | |
+ // Mild hack to debug here | |
+ /* for (const std::string &ext : formatInfo.texture.versionExtensions) */ | |
+ /* { */ | |
+ /* fprintf(stderr, " * version ext: %s\n", ext.c_str()); */ | |
+ /* } */ | |
+ /* fprintf(stderr, " * req extensions.length : %u\n", */ | |
+ /* formatInfo.texture.requiredExtensions.size()); */ | |
+ // for (const std::string &ext : formatInfo.texture.requiredExtensions) | |
+ // { | |
+ // fprintf(stderr, " * ext: %s\n", ext.c_str()); | |
+ // } | |
+ | |
if (textureCaps.textureAttachment) | |
{ | |
textureCaps.textureAttachment = CheckSizedInternalFormatTextureRenderability( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment