Skip to content

Instantly share code, notes, and snippets.

@nolanlawson
Last active July 26, 2017 16:27
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nolanlawson/54d29e82036bed5410adf9767d8cc64a to your computer and use it in GitHub Desktop.
Save nolanlawson/54d29e82036bed5410adf9767d8cc64a to your computer and use it in GitHub Desktop.
Try to repro fetch bug #391
<!doctype html>
<body>
<pre id=display></pre>
<script>
fetch('/foo', {
method: 'POST',
headers: {
"x-access-token": "example-key",
'Accept': 'application/json',
'Content-Type': 'application/json; charset=utf-8'
},
body: JSON.stringify({foo: 'bar'})
}).then(response => response.json())
.then(resp => {
display.innerHTML += JSON.stringify(resp) + '\n'
}).catch(console.log.bind(console))
</script>
</html>
var express = require('express')
var app = express()
app.post('/foo', (req, resp) => {
resp.json({ok: true})
})
app.use(express.static('./'))
app.listen(3000, () => console.log('listening on port 3000'))
The MIT License (MIT)
Copyright (c) 2016 Nolan Lawson
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE
OR OTHER DEALINGS IN THE SOFTWARE.
{
"name": "fetch-391",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"start": "node index.js"
},
"keywords": [],
"author": "Nolan Lawson <nolawson@microsoft.com>",
"license": "MIT",
"dependencies": {
"express": "^4.14.0"
}
}
@tswaters
Copy link

-  resp.json({ok: true})
+  resp.status(401).json({ok: true})

With this change, a TypeMismatch is thrown from fetch, and the response won't be parsed.

This appears to be fixed in Edge15... for older versions, we're getting around it with the following to ensure the polyfill is used instead:

var isEdge = navigator.userAgent.match(/Edge\/(\d+)/)
if (isEdge && parseInt(isEdge[1], 10) <= 14) { delete window.fetch; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment