Skip to content

Instantly share code, notes, and snippets.

@nturaga
Created December 5, 2019 21:37
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save nturaga/189b71ca4e6247747b72d4163a7b2bf1 to your computer and use it in GitHub Desktop.
Save nturaga/189b71ca4e6247747b72d4163a7b2bf1 to your computer and use it in GitHub Desktop.

BgeeCall review

BiocCheck

  • Basic run of BiocCheck('BgeeCall') on the package

      * ERROR: Packages providing 1 object(s) used in this package should
      be imported in the NAMESPACE file, otherwise packages importing
      this package may fail.
    
      package::object in function()
      graphics::mtext in plot_distributions()
    
  • File size too big, software packages need to be 5MB in size or less. Please check "BFG cleaner".

      * Checking individual file sizes...
      	* WARNING: The following files are over 5MB in size:
      '.git/objects/pack/pack-94ca9deb2be0a9e6fc630aa9c82ad98cb3dfbb24.pack'
    
  • Other issues,

* Checking for valid maintainer...
    * WARNING: Use Authors@R (preferred) or Author/Maintainer fields
      not both.
* Checking DESCRIPTION/NAMESPACE consistency...
    * WARNING: Import BgeeDB in NAMESPACE as well as DESCRIPTION.
* Checking vignette directory...
    This is a software package
    * WARNING: Vignette[s] still using 'VignetteIndexEntry{Vignette
      Title}' Update the following files from using template values:
        bgeecall-manual.Rmd
  • Coding practice issues,
* Checking coding practice...
    * NOTE: Avoid 1:...; use seq_len() or seq_along()
      Found in files:
        retrieveFromCommunity.R (line 27, column 27)
        retrieveFromCommunity.R (line 44, column 31)
		
* Checking man page documentation...
    * NOTE: Consider adding runnable examples to the following man
      pages which document exported objects:
      create_kallisto_index.Rd, generate_calls_workflow.Rd,

Please run BiocCheck('BgeeCall') on the package and make the appropriate changes. Install the package BiocCheck and run the function. We cannot make the change without fixing the issues given above.

You end up getting,

Summary:
ERROR count: 1
WARNING count: 5
NOTE count: 8

R CMD build

ok

R CMD INSTALL

ok

@nturaga
Copy link
Author

nturaga commented Jan 16, 2020

Hi @jwollbrett

I have reviewed your package and it seems good to be accepted. I've accepted officially and it is part of the software manifest now.

I've also updated the DESCRIPTION file to bump the version to 1.3.1. You should be able to see a build report tomorrow most likely, or maybe the day after at http://bioconductor.org/checkResults/devel/bioc-LATEST/.

So, please sync your Github repo with the Bioconductor git repo. You should be good to go for continuous development. If you have questions about how to maintain your package, please check http://bioconductor.org/developers/how-to/git/.

Best

Nitesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment