olov/ng-annotate_plus_assetgraph.txt

## ng-annotate_plus_assetgraph.txt
Process (almost) all files with ng-annotate options {add: true, regexp: "^$"}

I say almost because there should be no risk that already minified files (i.e. matching the filename pattern *.min.* or something similar) need processing by ng-annotate. So we're saving the nature and build times by excluding them.

Add means "add annotations but don't remove or rebuild those already existing, if any". That's what you want. The weird-looking regexp-option really just means disable the support for short declaration forms.

This is a short declaration form:
myMod.controller("MyCtrl", function($scope, $timeout) {
});

And this is a long declaration form (which is officially recommended by the angular team):
angular.module("MyMod").controller("MyCtrl", function($scope, $timeout) {
});

As you can see, executed on tens of millions of non-angular-app-code, having short form support enabled (with no limitations) will eventuelly probably cause a false positive (thus breaking the build). So I think that assetgraph should disable that by default, and then let the user opt-in on enabling it by overriding the regexp-option through an assetgraph configuration. The user would be able to enable it for everything with {regexp: ".*"}, or only enable it for modules called myMod with {regexp: "^myMod$"}. I want to stress here that this regexp is only there for optionally limiting matching of the short form module identifier name. All of the heavy lifting matching happens on the AST level.

You did mention that assetgraph doesn't process a project unless it found ng-app in an html file. Perhaps that, together with not processing already minified files (which I assume should mean most major third party libraries in most real world builds), could mean that you'd be able to keep short declaration forms enabled by default. It seems quite unlikely (although not impossible) to stuble upon false positive trigging code that looks like it (but isn't) in an angularjs application codebase.
	Process (almost) all files with ng-annotate options {add: true, regexp: "^$"}

	I say almost because there should be no risk that already minified files (i.e. matching the filename pattern .min. or something similar) need processing by ng-annotate. So we're saving the nature and build times by excluding them.

	Add means "add annotations but don't remove or rebuild those already existing, if any". That's what you want. The weird-looking regexp-option really just means disable the support for short declaration forms.

	This is a short declaration form:
	myMod.controller("MyCtrl", function($scope, $timeout) {
	});

	And this is a long declaration form (which is officially recommended by the angular team):
	angular.module("MyMod").controller("MyCtrl", function($scope, $timeout) {
	});

	As you can see, executed on tens of millions of non-angular-app-code, having short form support enabled (with no limitations) will eventuelly probably cause a false positive (thus breaking the build). So I think that assetgraph should disable that by default, and then let the user opt-in on enabling it by overriding the regexp-option through an assetgraph configuration. The user would be able to enable it for everything with {regexp: ".*"}, or only enable it for modules called myMod with {regexp: "^myMod$"}. I want to stress here that this regexp is only there for optionally limiting matching of the short form module identifier name. All of the heavy lifting matching happens on the AST level.

	You did mention that assetgraph doesn't process a project unless it found ng-app in an html file. Perhaps that, together with not processing already minified files (which I assume should mean most major third party libraries in most real world builds), could mean that you'd be able to keep short declaration forms enabled by default. It seems quite unlikely (although not impossible) to stuble upon false positive trigging code that looks like it (but isn't) in an angularjs application codebase.