gistfile1.java

//A) This
countries = ImmutableList.copyOf( Collections2.filter(
        Sets.newLinkedHashSet(Iterables.concat(someCountries, someOthers)),
        availableCountries));
		
//B) vs. That
countries = ImmutableList.copyOf(
                Collections2.filter(
                    Sets.newLinkedHashSet(Iterables.concat(someCountries, someOthers)),
                    availableCountries
                )
            );

// C) or this
Set<String> mergedCountries = Sets.newLinkedHashSet(Iterables.concat(someCountries, someOthers));
Collection<String> filteredCountries = Collections2.filter(mergedCountries,availableCountries);
countries = ImmutableList.copyOf(filteredCountries);

Definitively B.

But what about:

countries = ImmutableList.copyOf(
                filter( 
                     newLinkedHashSet(
                                 concat(someCountries, someOthers)
                     ), 
                     availableCountries
                )
            );

I mean, static imports remove a lot of noise.

@ElderMael with static import all the things?

countries = copyOf( 
    filter ( 
        newLinkedHashSet( concat( someCountries, someOthers ), 
        availableCountries 
     )
);

@karlthepagan Yeah, I notice it today :) mmmhhh too many temp vars... (2 haha)

Yeah, looking forward for Java 8, we should just use it the moment it is available... hahah

@oscarryz

Well... perhaps not all the things. I want to know the return type without having to backtrack to the variable declaration.

@ElderMael yeah, I like that