Downloads API proposal - Example 2 - separating concerns

gistfile1.txt

class AppDownload {
    WebExtension.DownloadItem mExtensionDownload;

    // Cancels the download
    GeckoResult<Void> cancel() {
        // Actually cancel the download
    }
    
    GeckoResult<DownloadItemUpdate> notifyExtension() {
        // Notifies extension
        mExtensionDownload.updateCanceled(true).commit();
    }

    void setDownloadItem(DownloadItem item) {
        mExtensionDownload = item;
    }
}

class AppDownloadController {
    // stuff ...

    @Override
    GeckoResult<DownloadItemUpdate> onCancel(DownloadItem item, WebExtension extension) {
        AppDownload download = mDownloads.byDownloadItem(item);
        // Update the download item in case it's out of date
        download.setDownloadItem(item);
        download.cancel();
        
        return download.notifyExtension();
    }
}

// UI Code

    onClick() {
        mDownload.cancel();
}