Skip to content

Instantly share code, notes, and snippets.

@oyiptong
Last active November 5, 2017 20:09
Show Gist options
  • Save oyiptong/fd383cb13bb0b500d5cd1b5a45ca0930 to your computer and use it in GitHub Desktop.
Save oyiptong/fd383cb13bb0b500d5cd1b5a45ca0930 to your computer and use it in GitHub Desktop.

Problems building due to NaCL:

$ gn gen out/macmac --args='cc_wrapper="ccache" is_component_build=true enable_nacl=false'
ERROR at //components/nacl/features.gni:6:1: Can't load input file.
import("//build/config/gclient_args.gni")
^---------------------------------------
Unable to load:
  /Users/olivier_yiptong/Projects/chromium/src/build/config/gclient_args.gni
I also checked in the secondary tree for:
  /Users/olivier_yiptong/Projects/chromium/src/build/secondary/build/config/gclient_args.gni
See //BUILD.gn:15:1: whence it was imported.
import("//components/nacl/features.gni")

After commenting out anything that could load NaCL:

diff --git a/BUILD.gn b/BUILD.gn
index cfcbd78d4cb0..e6215c63ca9e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -12,7 +12,8 @@ import("//build/config/compiler/compiler.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
-import("//components/nacl/features.gni")
+#import("//components/nacl/features.gni")
+enable_nacl = false
 import("//device/vr/features/features.gni")
 import("//extensions/features/features.gni")
 import("//media/media_options.gni")
@@ -91,7 +92,7 @@ group("gn_all") {

   if (!is_fuchsia) {
     deps += [
-      "//components:components_unittests",
+      #"//components:components_unittests",
       "//services:services_unittests",
       "//services/service_manager/public/cpp",
       "//tools/metrics:metrics_metadata",

Still having issues, this time with skia:

$ gn gen out/macmac --args='cc_wrapper="ccache" is_component_build=true enable_nacl=false'
ERROR at //skia/BUILD.gn:274:13: Undefined identifier
  defines = skia_core_defines
            ^----------------
See //BUILD.gn:79:5: which caused the file to be included.
    "//skia:skia_unittests",
    ^----------------------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment